diff options
| author | paulg@google.com <paulg@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-11-14 01:51:18 +0000 |
|---|---|---|
| committer | paulg@google.com <paulg@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-11-14 01:51:18 +0000 |
| commit | fc76de1cddd3c1b47fb2e9280c87dafce3010f41 (patch) | |
| tree | d789fa0c0bcd48dd42e14713f0cf7c6a3fb51fc0 /chrome | |
| parent | 80222765316f54aefb3c14a48b6336e282522804 (diff) | |
| download | chromium_src-fc76de1cddd3c1b47fb2e9280c87dafce3010f41.zip chromium_src-fc76de1cddd3c1b47fb2e9280c87dafce3010f41.tar.gz chromium_src-fc76de1cddd3c1b47fb2e9280c87dafce3010f41.tar.bz2 | |
Update the user delay histogram for the SafeBrowsing.
Review URL: http://codereview.chromium.org/10916
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5434 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome')
| -rw-r--r-- | chrome/browser/resource_dispatcher_host.cc | 6 | ||||
| -rw-r--r-- | chrome/browser/safe_browsing/safe_browsing_service.cc | 6 | ||||
| -rw-r--r-- | chrome/browser/safe_browsing/safe_browsing_service.h | 2 |
3 files changed, 8 insertions, 6 deletions
diff --git a/chrome/browser/resource_dispatcher_host.cc b/chrome/browser/resource_dispatcher_host.cc index 60ba658..f990a26 100644 --- a/chrome/browser/resource_dispatcher_host.cc +++ b/chrome/browser/resource_dispatcher_host.cc @@ -633,7 +633,7 @@ class SafeBrowsingEventHandler resource_type_(resource_type) { if (safe_browsing_->CheckUrl(url, this)) { safe_browsing_result_ = SafeBrowsingService::URL_SAFE; - SafeBrowsingService::LogPauseDelay(TimeDelta()); + safe_browsing_->LogPauseDelay(TimeDelta()); // No delay. } else { AddRef(); in_safe_browsing_check_ = true; @@ -654,7 +654,7 @@ class SafeBrowsingEventHandler if (safe_browsing_->CheckUrl(new_url, this)) { safe_browsing_result_ = SafeBrowsingService::URL_SAFE; - SafeBrowsingService::LogPauseDelay(TimeDelta()); + safe_browsing_->LogPauseDelay(TimeDelta()); // No delay. } else { AddRef(); in_safe_browsing_check_ = true; @@ -733,7 +733,7 @@ class SafeBrowsingEventHandler TimeDelta pause_delta; if (!pause_time_.is_null()) pause_delta = Time::Now() - pause_time_; - SafeBrowsingService::LogPauseDelay(pause_delta); + safe_browsing_->LogPauseDelay(pause_delta); if (queued_error_.get()) { next_handler_->OnResponseCompleted( diff --git a/chrome/browser/safe_browsing/safe_browsing_service.cc b/chrome/browser/safe_browsing/safe_browsing_service.cc index a2c62a2..e38bcc4 100644 --- a/chrome/browser/safe_browsing/safe_browsing_service.cc +++ b/chrome/browser/safe_browsing/safe_browsing_service.cc @@ -641,9 +641,11 @@ SafeBrowsingService::UrlCheckResult SafeBrowsingService::GetResultFromListname( return URL_SAFE; } -// static void SafeBrowsingService::LogPauseDelay(TimeDelta time) { - UMA_HISTOGRAM_LONG_TIMES(L"SB.Delay", time); + if (new_safe_browsing_) + UMA_HISTOGRAM_LONG_TIMES(L"SB2.Delay", time); + else + UMA_HISTOGRAM_LONG_TIMES(L"SB.Delay", time); } void SafeBrowsingService::CacheHashResults( diff --git a/chrome/browser/safe_browsing/safe_browsing_service.h b/chrome/browser/safe_browsing/safe_browsing_service.h index 485819f..761acb2 100644 --- a/chrome/browser/safe_browsing/safe_browsing_service.h +++ b/chrome/browser/safe_browsing/safe_browsing_service.h @@ -167,7 +167,7 @@ class SafeBrowsingService // delta starting from when we would have started reading data from the // network, and ending when the SafeBrowsing check completes indicating that // the current page is 'safe'. - static void LogPauseDelay(base::TimeDelta time); + void LogPauseDelay(base::TimeDelta time); // We defer SafeBrowsing work for a short duration when the computer comes // out of a suspend state to avoid thrashing the disk. |