summaryrefslogtreecommitdiffstats
path: root/chrome
diff options
context:
space:
mode:
authorkoz@chromium.org <koz@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-03-21 05:35:35 +0000
committerkoz@chromium.org <koz@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-03-21 05:35:35 +0000
commit07ed1d6e7deb9e78fa4bc53ca9f01eeed86f8e80 (patch)
treeba1a30a3d77a225617d81e032d27f4ac65cb1a5c /chrome
parent4b73733d3afeb6c7d987fc349c89af4b82b2e858 (diff)
downloadchromium_src-07ed1d6e7deb9e78fa4bc53ca9f01eeed86f8e80.zip
chromium_src-07ed1d6e7deb9e78fa4bc53ca9f01eeed86f8e80.tar.gz
chromium_src-07ed1d6e7deb9e78fa4bc53ca9f01eeed86f8e80.tar.bz2
Fix a memory leak in ModuleSystemTest.
BUG=118575,115296 TEST=existing unit tests Review URL: http://codereview.chromium.org/9794005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127907 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome')
-rw-r--r--chrome/renderer/module_system_unittest.cc5
1 files changed, 3 insertions, 2 deletions
diff --git a/chrome/renderer/module_system_unittest.cc b/chrome/renderer/module_system_unittest.cc
index ff520ac..abe4780 100644
--- a/chrome/renderer/module_system_unittest.cc
+++ b/chrome/renderer/module_system_unittest.cc
@@ -38,6 +38,7 @@ class AssertNatives : public NativeHandler {
class StringSourceMap : public ModuleSystem::SourceMap {
public:
StringSourceMap() {}
+ virtual ~StringSourceMap() {}
v8::Handle<v8::Value> GetSource(const std::string& name) OVERRIDE {
if (source_map_.count(name) == 0)
@@ -83,7 +84,7 @@ class ModuleSystemTest : public testing::Test {
source_map_(new StringSourceMap()) {
context_->Enter();
assert_natives_ = new AssertNatives();
- module_system_.reset(new ModuleSystem(source_map_));
+ module_system_.reset(new ModuleSystem(source_map_.get()));
module_system_->RegisterNativeHandler("assert", scoped_ptr<NativeHandler>(
assert_natives_));
RegisterModule("add", "exports.Add = function(x, y) { return x + y; };");
@@ -109,7 +110,7 @@ class ModuleSystemTest : public testing::Test {
v8::HandleScope handle_scope_;
v8::TryCatch try_catch_;
AssertNatives* assert_natives_;
- StringSourceMap* source_map_;
+ scoped_ptr<StringSourceMap> source_map_;
scoped_ptr<ModuleSystem> module_system_;
};