diff options
| author | darin@chromium.org <darin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-27 19:28:12 +0000 |
|---|---|---|
| committer | darin@chromium.org <darin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-27 19:28:12 +0000 |
| commit | ad0aab3bc2e48b3e42eea132d8f0a413547a13c0 (patch) | |
| tree | e34b6eb0277034620cac57555a0abab502dc2933 /chrome | |
| parent | 17be1a6d0436e18cc1a83ce54b18896ffc8f6be7 (diff) | |
| download | chromium_src-ad0aab3bc2e48b3e42eea132d8f0a413547a13c0.zip chromium_src-ad0aab3bc2e48b3e42eea132d8f0a413547a13c0.tar.gz chromium_src-ad0aab3bc2e48b3e42eea132d8f0a413547a13c0.tar.bz2 | |
Fix unit tests for the ResourceDispatcherHost.
A field of the ViewHostMsg_Resource_Request structure was uninitialized.
Also, includes a fix for an ASSERT_EQ that listed the expected value second
instead of first.
R=oshima
BUG=50002
TEST=none
Review URL: http://codereview.chromium.org/3052014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53820 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome')
| -rw-r--r-- | chrome/browser/renderer_host/resource_dispatcher_host_unittest.cc | 3 | ||||
| -rw-r--r-- | chrome/test/data/valgrind/unit_tests.gtest_mac.txt | 3 |
2 files changed, 2 insertions, 4 deletions
diff --git a/chrome/browser/renderer_host/resource_dispatcher_host_unittest.cc b/chrome/browser/renderer_host/resource_dispatcher_host_unittest.cc index c6a07c1..4cbee1a 100644 --- a/chrome/browser/renderer_host/resource_dispatcher_host_unittest.cc +++ b/chrome/browser/renderer_host/resource_dispatcher_host_unittest.cc @@ -73,6 +73,7 @@ static ViewHostMsg_Resource_Request CreateResourceRequest( request.resource_type = type; request.request_context = 0; request.appcache_host_id = appcache::kNoHostId; + request.download_to_file = false; request.host_renderer_id = -1; request.host_render_view_id = -1; return request; @@ -309,7 +310,7 @@ void CheckSuccessfulRequest(const std::vector<IPC::Message>& messages, // // This function verifies that we received 4 messages and that they // are appropriate. - ASSERT_EQ(messages.size(), 3U); + ASSERT_EQ(3U, messages.size()); // The first messages should be received response ASSERT_EQ(ViewMsg_Resource_ReceivedResponse::ID, messages[0].type()); diff --git a/chrome/test/data/valgrind/unit_tests.gtest_mac.txt b/chrome/test/data/valgrind/unit_tests.gtest_mac.txt index d5d9372..a013c37 100644 --- a/chrome/test/data/valgrind/unit_tests.gtest_mac.txt +++ b/chrome/test/data/valgrind/unit_tests.gtest_mac.txt @@ -36,6 +36,3 @@ RenderViewTest.Print* TabStripControllerTest.AddRemoveTabs # See http://crbug.com/30398. TaskManagerWindowControllerTest.* -# See http://crbug.com/50002. -ResourceDispatcherHostTest.* - |