diff options
| author | jorlow@chromium.org <jorlow@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-09-16 09:14:06 +0000 |
|---|---|---|
| committer | jorlow@chromium.org <jorlow@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-09-16 09:14:06 +0000 |
| commit | 505d7caf228069affc3e751452bc2e5d2fd68aea (patch) | |
| tree | 756bd6464614bba233f6e14a9a4868d598dd8116 /chrome | |
| parent | 4a74a1650cf0f402dd98d33c62f4158256dd1351 (diff) | |
| download | chromium_src-505d7caf228069affc3e751452bc2e5d2fd68aea.zip chromium_src-505d7caf228069affc3e751452bc2e5d2fd68aea.tar.gz chromium_src-505d7caf228069affc3e751452bc2e5d2fd68aea.tar.bz2 | |
Clarify some comments from a recent patch that changes TabContents.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/3423004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59626 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome')
| -rw-r--r-- | chrome/browser/renderer_host/render_view_host.h | 10 | ||||
| -rw-r--r-- | chrome/browser/tab_contents/navigation_controller.h | 4 | ||||
| -rw-r--r-- | chrome/browser/tab_contents/tab_contents.h | 4 |
3 files changed, 8 insertions, 10 deletions
diff --git a/chrome/browser/renderer_host/render_view_host.h b/chrome/browser/renderer_host/render_view_host.h index 151727b..47d337a 100644 --- a/chrome/browser/renderer_host/render_view_host.h +++ b/chrome/browser/renderer_host/render_view_host.h @@ -100,10 +100,12 @@ class RenderViewHost : public RenderWidgetHost { static RenderViewHost* FromID(int render_process_id, int render_view_id); // routing_id could be a valid route id, or it could be MSG_ROUTING_NONE, in - // which case RenderWidgetHost will create a new one. The session storage - // namespace parameter allows multiple render views to share the same session - // storage (part of the WebStorage spec) space. Passing in NULL simply - // allocates a new one (which is useful for testing). + // which case RenderWidgetHost will create a new one. + // + // The session storage namespace parameter allows multiple render views and + // tab contentses to share the same session storage (part of the WebStorage + // spec) space. This is useful when restoring tabs, but most callers should + // pass in NULL which will cause a new SessionStorageNamespace to be created. RenderViewHost(SiteInstance* instance, RenderViewHostDelegate* delegate, int routing_id, diff --git a/chrome/browser/tab_contents/navigation_controller.h b/chrome/browser/tab_contents/navigation_controller.h index be0be4b..574425a 100644 --- a/chrome/browser/tab_contents/navigation_controller.h +++ b/chrome/browser/tab_contents/navigation_controller.h @@ -138,10 +138,6 @@ class NavigationController { // --------------------------------------------------------------------------- - // The session storage namespace parameter allows multiple render views and - // tab contentses to share the same session storage (part of the WebStorage - // spec) space. Passing in NULL simply allocates a new one which is often the - // correct thing to do (especially in tests. NavigationController(TabContents* tab_contents, Profile* profile, SessionStorageNamespace* session_storage_namespace); diff --git a/chrome/browser/tab_contents/tab_contents.h b/chrome/browser/tab_contents/tab_contents.h index 63759b4..90ded2e 100644 --- a/chrome/browser/tab_contents/tab_contents.h +++ b/chrome/browser/tab_contents/tab_contents.h @@ -122,8 +122,8 @@ class TabContents : public PageNavigator, // // The session storage namespace parameter allows multiple render views and // tab contentses to share the same session storage (part of the WebStorage - // spec) space. Passing in NULL simply allocates a new one (which is useful - // for testing). + // spec) space. This is useful when restoring tabs, but most callers should + // pass in NULL which will cause a new SessionStorageNamespace to be created. TabContents(Profile* profile, SiteInstance* site_instance, int routing_id, |