diff options
author | limasdf@gmail.com <limasdf@gmail.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-04-18 10:26:40 +0000 |
---|---|---|
committer | limasdf@gmail.com <limasdf@gmail.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-04-18 10:26:40 +0000 |
commit | 9b44832024e41de8398265737601ab1992ffebc5 (patch) | |
tree | 6c9d0da9e58699ddfb3f0404b455493849874e5f /chrome | |
parent | 65d906a6ab188025db5809a3674b7965eaa07f12 (diff) | |
download | chromium_src-9b44832024e41de8398265737601ab1992ffebc5.zip chromium_src-9b44832024e41de8398265737601ab1992ffebc5.tar.gz chromium_src-9b44832024e41de8398265737601ab1992ffebc5.tar.bz2 |
Use EventRouter instead of ExtensionSystem::Get->event_router()
all clean-up
BUG=362672
Review URL: https://codereview.chromium.org/238633009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264765 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome')
49 files changed, 197 insertions, 288 deletions
diff --git a/chrome/browser/apps/app_browsertest.cc b/chrome/browser/apps/app_browsertest.cc index 1fd3e70..c87b2bf6 100644 --- a/chrome/browser/apps/app_browsertest.cc +++ b/chrome/browser/apps/app_browsertest.cc @@ -1017,8 +1017,8 @@ IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest, ExtensionPrefs* extension_prefs = ExtensionPrefs::Get(browser()->profile()); // Clear the registered events to ensure they are updated. - extensions::ExtensionSystem::Get(browser()->profile())->event_router()-> - SetRegisteredEvents(extension->id(), std::set<std::string>()); + extensions::EventRouter::Get(browser()->profile()) + ->SetRegisteredEvents(extension->id(), std::set<std::string>()); DictionaryPrefUpdate update(extension_prefs->pref_service(), extensions::pref_names::kExtensions); @@ -1196,7 +1196,7 @@ IN_PROC_BROWSER_TEST_F(PlatformAppIncognitoBrowserTest, IncognitoComponentApp) { // Wait until the file manager has had a chance to register its listener // for the launch event. - EventRouter* router = ExtensionSystem::Get(incognito_profile)->event_router(); + EventRouter* router = EventRouter::Get(incognito_profile); ASSERT_TRUE(router != NULL); while (!router->ExtensionHasEventListener( file_manager->id(), app_runtime::OnLaunched::kEventName)) { diff --git a/chrome/browser/apps/ephemeral_app_browsertest.cc b/chrome/browser/apps/ephemeral_app_browsertest.cc index 67c52e5..b7a6885 100644 --- a/chrome/browser/apps/ephemeral_app_browsertest.cc +++ b/chrome/browser/apps/ephemeral_app_browsertest.cc @@ -204,8 +204,7 @@ IN_PROC_BROWSER_TEST_F(EphemeralAppBrowserTest, EventDispatchWhenLaunched) { // Send a fake alarm event to the app and verify that a response is // received. - EventRouter* event_router = - ExtensionSystem::Get(browser()->profile())->event_router(); + EventRouter* event_router = EventRouter::Get(browser()->profile()); ASSERT_TRUE(event_router); ExtensionTestMessageListener alarm_received_listener("alarm_received", false); diff --git a/chrome/browser/chromeos/extensions/file_manager/event_router.cc b/chrome/browser/chromeos/extensions/file_manager/event_router.cc index 5179248..ae98987 100644 --- a/chrome/browser/chromeos/extensions/file_manager/event_router.cc +++ b/chrome/browser/chromeos/extensions/file_manager/event_router.cc @@ -172,9 +172,8 @@ bool IsRecoveryToolRunning(Profile* profile) { void BroadcastEvent(Profile* profile, const std::string& event_name, scoped_ptr<base::ListValue> event_args) { - extensions::ExtensionSystem::Get(profile)->event_router()-> - BroadcastEvent(make_scoped_ptr( - new extensions::Event(event_name, event_args.Pass()))); + extensions::EventRouter::Get(profile)->BroadcastEvent( + make_scoped_ptr(new extensions::Event(event_name, event_args.Pass()))); } file_browser_private::MountCompletedStatus @@ -559,8 +558,7 @@ void EventRouter::OnCopyProgress( } void EventRouter::DefaultNetworkChanged(const chromeos::NetworkState* network) { - if (!profile_ || - !extensions::ExtensionSystem::Get(profile_)->event_router()) { + if (!profile_ || !extensions::EventRouter::Get(profile_)) { NOTREACHED(); return; } @@ -572,8 +570,7 @@ void EventRouter::DefaultNetworkChanged(const chromeos::NetworkState* network) { } void EventRouter::OnFileManagerPrefsChanged() { - if (!profile_ || - !extensions::ExtensionSystem::Get(profile_)->event_router()) { + if (!profile_ || !extensions::EventRouter::Get(profile_)) { NOTREACHED(); return; } diff --git a/chrome/browser/chromeos/file_manager/file_browser_handlers.cc b/chrome/browser/chromeos/file_manager/file_browser_handlers.cc index 96728e8..e5935e4 100644 --- a/chrome/browser/chromeos/file_manager/file_browser_handlers.cc +++ b/chrome/browser/chromeos/file_manager/file_browser_handlers.cc @@ -359,9 +359,8 @@ void FileBrowserHandlerExecutor::SetupPermissionsAndDispatchEvent( return; } - extensions::EventRouter* event_router = - extensions::ExtensionSystem::Get(profile_)->event_router(); - if (!event_router) { + extensions::EventRouter* router = extensions::EventRouter::Get(profile_); + if (!router) { ExecuteDoneOnUIThread(false); return; } @@ -394,7 +393,7 @@ void FileBrowserHandlerExecutor::SetupPermissionsAndDispatchEvent( scoped_ptr<extensions::Event> event(new extensions::Event( "fileBrowserHandler.onExecute", event_args.Pass())); event->restrict_to_browser_context = profile_; - event_router->DispatchEventToExtension(extension_->id(), event.Pass()); + router->DispatchEventToExtension(extension_->id(), event.Pass()); ExecuteDoneOnUIThread(true); } diff --git a/chrome/browser/chromeos/file_system_provider/service.cc b/chrome/browser/chromeos/file_system_provider/service.cc index 3bc173c..9f4151c 100644 --- a/chrome/browser/chromeos/file_system_provider/service.cc +++ b/chrome/browser/chromeos/file_system_provider/service.cc @@ -13,7 +13,7 @@ #include "chrome/browser/chromeos/file_system_provider/provided_file_system_interface.h" #include "chrome/browser/chromeos/file_system_provider/service_factory.h" #include "content/public/browser/browser_thread.h" -#include "extensions/browser/extension_system.h" +#include "extensions/browser/event_router.h" #include "webkit/browser/fileapi/external_mount_points.h" namespace chromeos { @@ -113,11 +113,10 @@ int Service::MountFileSystem(const std::string& extension_id, extension_id, file_system_id, file_system_name, mount_point_path); // The event router may be NULL for unit tests. - extensions::EventRouter* event_router = - extensions::ExtensionSystem::Get(profile_)->event_router(); + extensions::EventRouter* router = extensions::EventRouter::Get(profile_); ProvidedFileSystemInterface* file_system = - file_system_factory_.Run(event_router, file_system_info); + file_system_factory_.Run(router, file_system_info); DCHECK(file_system); file_system_map_[file_system_id] = file_system; diff --git a/chrome/browser/chromeos/login/wallpaper_manager.cc b/chrome/browser/chromeos/login/wallpaper_manager.cc index a0017cb..751bcc3 100644 --- a/chrome/browser/chromeos/login/wallpaper_manager.cc +++ b/chrome/browser/chromeos/login/wallpaper_manager.cc @@ -984,15 +984,14 @@ void WallpaperManager::RemoveObserver(WallpaperManager::Observer* observer) { void WallpaperManager::EnableSurpriseMe() { Profile* profile = ProfileManager::GetActiveUserProfile(); DCHECK(profile); - DCHECK(extensions::ExtensionSystem::Get(profile)->event_router()); + DCHECK(extensions::EventRouter::Get(profile)); scoped_ptr<extensions::Event> event( new extensions::Event( extensions::api::wallpaper_private::OnRequestEnableSurpriseMe::kEventName, extensions::api::wallpaper_private::OnRequestEnableSurpriseMe::Create())); - extensions::ExtensionSystem::Get(profile)->event_router() - ->DispatchEventToExtension(extension_misc::kWallpaperManagerId, - event.Pass()); + extensions::EventRouter::Get(profile)->DispatchEventToExtension( + extension_misc::kWallpaperManagerId, event.Pass()); } void WallpaperManager::NotifyAnimationFinished() { diff --git a/chrome/browser/extensions/api/activity_log_private/activity_log_private_api.cc b/chrome/browser/extensions/api/activity_log_private/activity_log_private_api.cc index c6c748c..bb99213 100644 --- a/chrome/browser/extensions/api/activity_log_private/activity_log_private_api.cc +++ b/chrome/browser/extensions/api/activity_log_private/activity_log_private_api.cc @@ -14,7 +14,6 @@ #include "chrome/common/extensions/api/activity_log_private.h" #include "chrome/common/pref_names.h" #include "content/public/browser/browser_context.h" -#include "extensions/browser/extension_system.h" #include "extensions/browser/extension_system_provider.h" #include "extensions/browser/extensions_browser_client.h" #include "extensions/common/features/feature.h" @@ -46,14 +45,13 @@ BrowserContextKeyedAPIFactory<ActivityLogAPI>::DeclareFactoryDependencies() { ActivityLogAPI::ActivityLogAPI(content::BrowserContext* context) : browser_context_(context), initialized_(false) { - if (!ExtensionSystem::Get(browser_context_) - ->event_router()) { // Check for testing. + if (!EventRouter::Get(browser_context_)) { // Check for testing. DVLOG(1) << "ExtensionSystem event_router does not exist."; return; } activity_log_ = extensions::ActivityLog::GetInstance(browser_context_); DCHECK(activity_log_); - ExtensionSystem::Get(browser_context_)->event_router()->RegisterObserver( + EventRouter::Get(browser_context_)->RegisterObserver( this, activity_log_private::OnExtensionActivity::kEventName); activity_log_->AddObserver(this); initialized_ = true; @@ -67,8 +65,7 @@ void ActivityLogAPI::Shutdown() { DVLOG(1) << "ExtensionSystem event_router does not exist."; return; } - ExtensionSystem::Get(browser_context_)->event_router()->UnregisterObserver( - this); + EventRouter::Get(browser_context_)->UnregisterObserver(this); activity_log_->RemoveObserver(this); } @@ -95,8 +92,7 @@ void ActivityLogAPI::OnExtensionActivity(scoped_refptr<Action> activity) { new Event(activity_log_private::OnExtensionActivity::kEventName, value.Pass())); event->restrict_to_browser_context = browser_context_; - ExtensionSystem::Get(browser_context_)->event_router()->BroadcastEvent( - event.Pass()); + EventRouter::Get(browser_context_)->BroadcastEvent(event.Pass()); } bool ActivityLogPrivateGetExtensionActivitiesFunction::RunImpl() { diff --git a/chrome/browser/extensions/api/audio/audio_api.cc b/chrome/browser/extensions/api/audio/audio_api.cc index ce252e6..70e849f 100644 --- a/chrome/browser/extensions/api/audio/audio_api.cc +++ b/chrome/browser/extensions/api/audio/audio_api.cc @@ -9,7 +9,6 @@ #include "chrome/browser/profiles/profile.h" #include "chrome/common/extensions/api/audio.h" #include "extensions/browser/event_router.h" -#include "extensions/browser/extension_system.h" namespace extensions { @@ -39,13 +38,11 @@ AudioService* AudioAPI::GetService() const { } void AudioAPI::OnDeviceChanged() { - if (browser_context_ && - ExtensionSystem::Get(browser_context_)->event_router()) { + if (browser_context_ && EventRouter::Get(browser_context_)) { scoped_ptr<Event> event(new Event( audio::OnDeviceChanged::kEventName, scoped_ptr<base::ListValue>(new base::ListValue()))); - ExtensionSystem::Get(browser_context_)->event_router()->BroadcastEvent( - event.Pass()); + EventRouter::Get(browser_context_)->BroadcastEvent(event.Pass()); } } diff --git a/chrome/browser/extensions/api/automation_internal/automation_internal_api.cc b/chrome/browser/extensions/api/automation_internal/automation_internal_api.cc index 26d0595..18f2ad4 100644 --- a/chrome/browser/extensions/api/automation_internal/automation_internal_api.cc +++ b/chrome/browser/extensions/api/automation_internal/automation_internal_api.cc @@ -25,7 +25,6 @@ #include "content/public/browser/render_widget_host_view.h" #include "content/public/browser/web_contents.h" #include "extensions/browser/event_router.h" -#include "extensions/browser/extension_system.h" #include "ui/accessibility/ax_enums.h" #include "ui/accessibility/ax_node_data.h" @@ -45,11 +44,13 @@ namespace { void DispatchEvent(content::BrowserContext* context, const std::string& event_name, scoped_ptr<base::ListValue> args) { - if (context && extensions::ExtensionSystem::Get(context)->event_router()) { - scoped_ptr<Event> event(new Event(event_name, args.Pass())); - event->restrict_to_browser_context = context; - ExtensionSystem::Get(context)->event_router()->BroadcastEvent(event.Pass()); - } + EventRouter* event_router = EventRouter::Get(context); + if (!event_router) + return; + + scoped_ptr<Event> event(new Event(event_name, args.Pass())); + event->restrict_to_browser_context = context; + event_router->BroadcastEvent(event.Pass()); } } // namespace diff --git a/chrome/browser/extensions/api/bluetooth/bluetooth_api.cc b/chrome/browser/extensions/api/bluetooth/bluetooth_api.cc index ce04129..0a67615 100644 --- a/chrome/browser/extensions/api/bluetooth/bluetooth_api.cc +++ b/chrome/browser/extensions/api/bluetooth/bluetooth_api.cc @@ -22,7 +22,6 @@ #include "device/bluetooth/bluetooth_service_record.h" #include "device/bluetooth/bluetooth_socket.h" #include "extensions/browser/event_router.h" -#include "extensions/browser/extension_system.h" #include "extensions/common/permissions/permissions_data.h" #include "net/base/io_buffer.h" @@ -155,14 +154,12 @@ BluetoothAPI::ConnectionParams::~ConnectionParams() {} BluetoothAPI::BluetoothAPI(content::BrowserContext* context) : browser_context_(context) { DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI)); - ExtensionSystem::Get(browser_context_)->event_router()->RegisterObserver( - this, bluetooth::OnAdapterStateChanged::kEventName); - ExtensionSystem::Get(browser_context_)->event_router()->RegisterObserver( - this, bluetooth::OnDeviceAdded::kEventName); - ExtensionSystem::Get(browser_context_)->event_router()->RegisterObserver( - this, bluetooth::OnDeviceChanged::kEventName); - ExtensionSystem::Get(browser_context_)->event_router()->RegisterObserver( - this, bluetooth::OnDeviceRemoved::kEventName); + EventRouter* event_router = EventRouter::Get(browser_context_); + event_router->RegisterObserver(this, + bluetooth::OnAdapterStateChanged::kEventName); + event_router->RegisterObserver(this, bluetooth::OnDeviceAdded::kEventName); + event_router->RegisterObserver(this, bluetooth::OnDeviceChanged::kEventName); + event_router->RegisterObserver(this, bluetooth::OnDeviceRemoved::kEventName); } BluetoothAPI::~BluetoothAPI() {} @@ -202,8 +199,7 @@ BluetoothAPI::socket_event_dispatcher() { void BluetoothAPI::Shutdown() { DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI)); - ExtensionSystem::Get(browser_context_)->event_router()->UnregisterObserver( - this); + EventRouter::Get(browser_context_)->UnregisterObserver(this); } void BluetoothAPI::OnListenerAdded(const EventListenerInfo& details) { @@ -293,7 +289,7 @@ void BluetoothAPI::RegisterSocketWithAdapterUI( scoped_ptr<Event> event( new Event(bluetooth::OnConnection::kEventName, args.Pass())); - EventRouter* router = ExtensionSystem::Get(context)->event_router(); + EventRouter* router = EventRouter::Get(context); if (router) router->DispatchEventToExtension(params.extension_id, event.Pass()); } diff --git a/chrome/browser/extensions/api/bluetooth/bluetooth_api_unittest.cc b/chrome/browser/extensions/api/bluetooth/bluetooth_api_unittest.cc index b13909f..45da930 100644 --- a/chrome/browser/extensions/api/bluetooth/bluetooth_api_unittest.cc +++ b/chrome/browser/extensions/api/bluetooth/bluetooth_api_unittest.cc @@ -157,8 +157,8 @@ TEST_F(ExtensionBluetoothApiTest, DispatchConnectionEvent) { // receiver(s). base::RunLoop().RunUntilIdle(); - FakeEventRouter* fake_event_router = static_cast<FakeEventRouter*>( - ExtensionSystem::Get(test_profile_)->event_router()); + FakeEventRouter* fake_event_router = + static_cast<FakeEventRouter*>(EventRouter::Get(test_profile_)); ASSERT_TRUE(fake_event_router->event()); EXPECT_STREQ(kTestExtensionId, fake_event_router->extension_id().c_str()); @@ -197,8 +197,8 @@ TEST_F(ExtensionBluetoothApiTest, DoNotDispatchConnectionEvent) { // receiver(s). base::RunLoop().RunUntilIdle(); - FakeEventRouter* fake_event_router = static_cast<FakeEventRouter*>( - ExtensionSystem::Get(test_profile_)->event_router()); + FakeEventRouter* fake_event_router = + static_cast<FakeEventRouter*>(EventRouter::Get(test_profile_)); EXPECT_TRUE(fake_event_router->event() == NULL); EXPECT_CALL(*mock_adapter_, RemoveObserver(testing::_)).Times(1); diff --git a/chrome/browser/extensions/api/bluetooth/bluetooth_event_router.cc b/chrome/browser/extensions/api/bluetooth/bluetooth_event_router.cc index a440c49..31a26c1 100644 --- a/chrome/browser/extensions/api/bluetooth/bluetooth_event_router.cc +++ b/chrome/browser/extensions/api/bluetooth/bluetooth_event_router.cc @@ -31,7 +31,6 @@ #include "device/bluetooth/bluetooth_socket.h" #include "extensions/browser/event_router.h" #include "extensions/browser/extension_host.h" -#include "extensions/browser/extension_system.h" namespace extensions { @@ -336,8 +335,7 @@ void BluetoothEventRouter::DispatchAdapterStateEvent() { scoped_ptr<Event> event(new Event( bluetooth::OnAdapterStateChanged::kEventName, args.Pass())); - ExtensionSystem::Get(browser_context_)->event_router()->BroadcastEvent( - event.Pass()); + EventRouter::Get(browser_context_)->BroadcastEvent(event.Pass()); } void BluetoothEventRouter::DispatchDeviceEvent( @@ -349,8 +347,7 @@ void BluetoothEventRouter::DispatchDeviceEvent( scoped_ptr<base::ListValue> args = bluetooth::OnDeviceAdded::Create(extension_device); scoped_ptr<Event> event(new Event(event_name, args.Pass())); - ExtensionSystem::Get(browser_context_)->event_router()->BroadcastEvent( - event.Pass()); + EventRouter::Get(browser_context_)->BroadcastEvent(event.Pass()); } void BluetoothEventRouter::CleanUpForExtension( diff --git a/chrome/browser/extensions/api/bluetooth/bluetooth_private_api.cc b/chrome/browser/extensions/api/bluetooth/bluetooth_private_api.cc index 6340d48..1ac35eb 100644 --- a/chrome/browser/extensions/api/bluetooth/bluetooth_private_api.cc +++ b/chrome/browser/extensions/api/bluetooth/bluetooth_private_api.cc @@ -12,7 +12,6 @@ #include "chrome/common/extensions/api/bluetooth_private.h" #include "device/bluetooth/bluetooth_adapter.h" #include "device/bluetooth/bluetooth_adapter_factory.h" -#include "extensions/browser/extension_system.h" namespace bt_private = extensions::api::bluetooth_private; @@ -29,15 +28,14 @@ BluetoothPrivateAPI::GetFactoryInstance() { BluetoothPrivateAPI::BluetoothPrivateAPI(content::BrowserContext* context) : browser_context_(context) { - ExtensionSystem::Get(browser_context_)->event_router()->RegisterObserver( - this, bt_private::OnPairing::kEventName); + EventRouter::Get(browser_context_) + ->RegisterObserver(this, bt_private::OnPairing::kEventName); } BluetoothPrivateAPI::~BluetoothPrivateAPI() {} void BluetoothPrivateAPI::Shutdown() { - ExtensionSystem::Get(browser_context_)->event_router()->UnregisterObserver( - this); + EventRouter::Get(browser_context_)->UnregisterObserver(this); } void BluetoothPrivateAPI::OnListenerAdded(const EventListenerInfo& details) { diff --git a/chrome/browser/extensions/api/bluetooth/bluetooth_socket_event_dispatcher.cc b/chrome/browser/extensions/api/bluetooth/bluetooth_socket_event_dispatcher.cc index ddd413c..6429ed474 100644 --- a/chrome/browser/extensions/api/bluetooth/bluetooth_socket_event_dispatcher.cc +++ b/chrome/browser/extensions/api/bluetooth/bluetooth_socket_event_dispatcher.cc @@ -8,7 +8,6 @@ #include "chrome/browser/extensions/api/bluetooth/bluetooth_api_socket.h" #include "chrome/common/extensions/api/bluetooth.h" #include "extensions/browser/event_router.h" -#include "extensions/browser/extension_system.h" #include "net/base/io_buffer.h" #include "net/base/net_errors.h" @@ -170,7 +169,7 @@ void BluetoothSocketEventDispatcher::DispatchEvent( if (!extensions::ExtensionsBrowserClient::Get()->IsValidContext(context)) return; - EventRouter* router = ExtensionSystem::Get(context)->event_router(); + EventRouter* router = EventRouter::Get(context); if (router) router->DispatchEventToExtension(extension_id, event.Pass()); } diff --git a/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc b/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc index 0a3be77..8193273 100644 --- a/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc +++ b/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc @@ -33,7 +33,6 @@ #include "content/public/browser/web_contents_view.h" #include "content/public/browser/web_ui.h" #include "extensions/browser/extension_function_dispatcher.h" -#include "extensions/browser/extension_system.h" #include "extensions/browser/view_type_utils.h" #include "grit/generated_resources.h" #include "ui/base/dragdrop/drag_drop_types.h" @@ -183,10 +182,8 @@ BookmarkManagerPrivateEventRouter::~BookmarkManagerPrivateEventRouter() { void BookmarkManagerPrivateEventRouter::DispatchEvent( const std::string& event_name, scoped_ptr<base::ListValue> event_args) { - extensions::ExtensionSystem::Get(browser_context_) - ->event_router() - ->BroadcastEvent(make_scoped_ptr( - new extensions::Event(event_name, event_args.Pass()))); + extensions::EventRouter::Get(browser_context_)->BroadcastEvent( + make_scoped_ptr(new extensions::Event(event_name, event_args.Pass()))); } void BookmarkManagerPrivateEventRouter::BookmarkModelChanged() {} @@ -207,8 +204,7 @@ void BookmarkManagerPrivateEventRouter::BookmarkMetaInfoChanged( BookmarkManagerPrivateAPI::BookmarkManagerPrivateAPI( content::BrowserContext* browser_context) : browser_context_(browser_context) { - EventRouter* event_router = - ExtensionSystem::Get(browser_context)->event_router(); + EventRouter* event_router = EventRouter::Get(browser_context); event_router->RegisterObserver( this, bookmark_manager_private::OnMetaInfoChanged::kEventName); } @@ -216,8 +212,7 @@ BookmarkManagerPrivateAPI::BookmarkManagerPrivateAPI( BookmarkManagerPrivateAPI::~BookmarkManagerPrivateAPI() {} void BookmarkManagerPrivateAPI::Shutdown() { - ExtensionSystem::Get(browser_context_)->event_router()->UnregisterObserver( - this); + EventRouter::Get(browser_context_)->UnregisterObserver(this); } static base::LazyInstance< @@ -232,8 +227,7 @@ BookmarkManagerPrivateAPI::GetFactoryInstance() { void BookmarkManagerPrivateAPI::OnListenerAdded( const EventListenerInfo& details) { - ExtensionSystem::Get(browser_context_)->event_router()->UnregisterObserver( - this); + EventRouter::Get(browser_context_)->UnregisterObserver(this); event_router_.reset(new BookmarkManagerPrivateEventRouter( browser_context_, BookmarkModelFactory::GetForProfile( @@ -260,11 +254,12 @@ BookmarkManagerPrivateDragEventRouter:: void BookmarkManagerPrivateDragEventRouter::DispatchEvent( const std::string& event_name, scoped_ptr<base::ListValue> args) { - if (!ExtensionSystem::Get(profile_)->event_router()) + EventRouter* event_router = EventRouter::Get(profile_); + if (!event_router) return; scoped_ptr<Event> event(new Event(event_name, args.Pass())); - ExtensionSystem::Get(profile_)->event_router()->BroadcastEvent(event.Pass()); + event_router->BroadcastEvent(event.Pass()); } void BookmarkManagerPrivateDragEventRouter::OnDragEnter( diff --git a/chrome/browser/extensions/api/bookmarks/bookmarks_api.cc b/chrome/browser/extensions/api/bookmarks/bookmarks_api.cc index 9fd2857..a49ca16 100644 --- a/chrome/browser/extensions/api/bookmarks/bookmarks_api.cc +++ b/chrome/browser/extensions/api/bookmarks/bookmarks_api.cc @@ -44,7 +44,6 @@ #include "content/public/browser/web_contents_view.h" #include "extensions/browser/event_router.h" #include "extensions/browser/extension_function_dispatcher.h" -#include "extensions/browser/extension_system.h" #include "extensions/browser/quota_service.h" #include "grit/generated_resources.h" #include "ui/base/l10n/l10n_util.h" @@ -173,11 +172,10 @@ BookmarkEventRouter::~BookmarkEventRouter() { void BookmarkEventRouter::DispatchEvent( const std::string& event_name, scoped_ptr<base::ListValue> event_args) { - if (extensions::ExtensionSystem::Get(browser_context_)->event_router()) { - extensions::ExtensionSystem::Get(browser_context_) - ->event_router() - ->BroadcastEvent(make_scoped_ptr( - new extensions::Event(event_name, event_args.Pass()))); + EventRouter* event_router = EventRouter::Get(browser_context_); + if (event_router) { + event_router->BroadcastEvent( + make_scoped_ptr(new extensions::Event(event_name, event_args.Pass()))); } } @@ -289,8 +287,7 @@ void BookmarkEventRouter::ExtensiveBookmarkChangesEnded(BookmarkModel* model) { BookmarksAPI::BookmarksAPI(BrowserContext* context) : browser_context_(context) { - EventRouter* event_router = - ExtensionSystem::Get(browser_context_)->event_router(); + EventRouter* event_router = EventRouter::Get(browser_context_); event_router->RegisterObserver(this, bookmarks::OnCreated::kEventName); event_router->RegisterObserver(this, bookmarks::OnRemoved::kEventName); event_router->RegisterObserver(this, bookmarks::OnChanged::kEventName); @@ -305,8 +302,7 @@ BookmarksAPI::~BookmarksAPI() { } void BookmarksAPI::Shutdown() { - ExtensionSystem::Get(browser_context_)->event_router()->UnregisterObserver( - this); + EventRouter::Get(browser_context_)->UnregisterObserver(this); } static base::LazyInstance<BrowserContextKeyedAPIFactory<BookmarksAPI> > @@ -323,8 +319,7 @@ void BookmarksAPI::OnListenerAdded(const EventListenerInfo& details) { browser_context_, BookmarkModelFactory::GetForProfile( Profile::FromBrowserContext(browser_context_)))); - ExtensionSystem::Get(browser_context_)->event_router()->UnregisterObserver( - this); + EventRouter::Get(browser_context_)->UnregisterObserver(this); } bool BookmarksGetFunction::RunImpl() { diff --git a/chrome/browser/extensions/api/braille_display_private/braille_display_private_api.cc b/chrome/browser/extensions/api/braille_display_private/braille_display_private_api.cc index 85a7af9..5cbcb34 100644 --- a/chrome/browser/extensions/api/braille_display_private/braille_display_private_api.cc +++ b/chrome/browser/extensions/api/braille_display_private/braille_display_private_api.cc @@ -8,7 +8,6 @@ #include "chrome/browser/extensions/api/braille_display_private/braille_controller.h" #include "chrome/browser/profiles/profile.h" #include "chrome/browser/profiles/profile_manager.h" -#include "extensions/browser/extension_system.h" #if defined(OS_CHROMEOS) #include "chrome/browser/chromeos/login/screen_locker.h" @@ -122,22 +121,22 @@ void BrailleDisplayPrivateAPI::OnListenerRemoved( BrailleDisplayPrivateAPI::DefaultEventDelegate::DefaultEventDelegate( EventRouter::Observer* observer, Profile* profile) : observer_(observer), profile_(profile) { - EventRouter* event_router = ExtensionSystem::Get(profile_)->event_router(); + EventRouter* event_router = EventRouter::Get(profile_); event_router->RegisterObserver(observer_, OnDisplayStateChanged::kEventName); event_router->RegisterObserver(observer_, OnKeyEvent::kEventName); } BrailleDisplayPrivateAPI::DefaultEventDelegate::~DefaultEventDelegate() { - ExtensionSystem::Get(profile_)->event_router()->UnregisterObserver(observer_); + EventRouter::Get(profile_)->UnregisterObserver(observer_); } void BrailleDisplayPrivateAPI::DefaultEventDelegate::BroadcastEvent( scoped_ptr<Event> event) { - ExtensionSystem::Get(profile_)->event_router()->BroadcastEvent(event.Pass()); + EventRouter::Get(profile_)->BroadcastEvent(event.Pass()); } bool BrailleDisplayPrivateAPI::DefaultEventDelegate::HasListener() { - EventRouter* event_router = ExtensionSystem::Get(profile_)->event_router(); + EventRouter* event_router = EventRouter::Get(profile_); return (event_router->HasEventListener(OnDisplayStateChanged::kEventName) || event_router->HasEventListener(OnKeyEvent::kEventName)); } diff --git a/chrome/browser/extensions/api/cookies/cookies_api.cc b/chrome/browser/extensions/api/cookies/cookies_api.cc index 78ff3d7..4df4ef0 100644 --- a/chrome/browser/extensions/api/cookies/cookies_api.cc +++ b/chrome/browser/extensions/api/cookies/cookies_api.cc @@ -25,7 +25,6 @@ #include "content/public/browser/browser_thread.h" #include "content/public/browser/notification_service.h" #include "extensions/browser/event_router.h" -#include "extensions/browser/extension_system.h" #include "extensions/common/error_utils.h" #include "extensions/common/extension.h" #include "extensions/common/permissions/permissions_data.h" @@ -134,9 +133,7 @@ void CookiesEventRouter::DispatchEvent(content::BrowserContext* context, const std::string& event_name, scoped_ptr<base::ListValue> event_args, GURL& cookie_domain) { - EventRouter* router = - context ? extensions::ExtensionSystem::Get(context)->event_router() - : NULL; + EventRouter* router = context ? extensions::EventRouter::Get(context) : NULL; if (!router) return; scoped_ptr<Event> event(new Event(event_name, event_args.Pass())); @@ -562,16 +559,15 @@ void CookiesGetAllCookieStoresFunction::Run() { CookiesAPI::CookiesAPI(content::BrowserContext* context) : browser_context_(context) { - ExtensionSystem::Get(browser_context_)->event_router()->RegisterObserver( - this, cookies::OnChanged::kEventName); + EventRouter::Get(browser_context_) + ->RegisterObserver(this, cookies::OnChanged::kEventName); } CookiesAPI::~CookiesAPI() { } void CookiesAPI::Shutdown() { - ExtensionSystem::Get(browser_context_)->event_router()->UnregisterObserver( - this); + EventRouter::Get(browser_context_)->UnregisterObserver(this); } static base::LazyInstance<BrowserContextKeyedAPIFactory<CookiesAPI> > @@ -585,8 +581,7 @@ BrowserContextKeyedAPIFactory<CookiesAPI>* CookiesAPI::GetFactoryInstance() { void CookiesAPI::OnListenerAdded( const extensions::EventListenerInfo& details) { cookies_event_router_.reset(new CookiesEventRouter(browser_context_)); - ExtensionSystem::Get(browser_context_)->event_router()->UnregisterObserver( - this); + EventRouter::Get(browser_context_)->UnregisterObserver(this); } } // namespace extensions diff --git a/chrome/browser/extensions/api/debugger/debugger_api.cc b/chrome/browser/extensions/api/debugger/debugger_api.cc index 839f999..9cf07a3 100644 --- a/chrome/browser/extensions/api/debugger/debugger_api.cc +++ b/chrome/browser/extensions/api/debugger/debugger_api.cc @@ -385,7 +385,7 @@ void ExtensionDevToolsClientHost::MarkAsDismissed() { } void ExtensionDevToolsClientHost::SendDetachedEvent() { - if (!extensions::ExtensionSystem::Get(profile_)->event_router()) + if (!extensions::EventRouter::Get(profile_)) return; scoped_ptr<base::ListValue> args(OnDetach::Create(debuggee_, @@ -393,8 +393,8 @@ void ExtensionDevToolsClientHost::SendDetachedEvent() { scoped_ptr<extensions::Event> event(new extensions::Event( OnDetach::kEventName, args.Pass())); event->restrict_to_browser_context = profile_; - extensions::ExtensionSystem::Get(profile_)->event_router()-> - DispatchEventToExtension(extension_id_, event.Pass()); + extensions::EventRouter::Get(profile_) + ->DispatchEventToExtension(extension_id_, event.Pass()); } void ExtensionDevToolsClientHost::Observe( @@ -419,7 +419,7 @@ void ExtensionDevToolsClientHost::Observe( void ExtensionDevToolsClientHost::DispatchOnInspectorFrontend( const std::string& message) { - if (!extensions::ExtensionSystem::Get(profile_)->event_router()) + if (!extensions::EventRouter::Get(profile_)) return; scoped_ptr<base::Value> result(base::JSONReader::Read(message)); @@ -444,8 +444,8 @@ void ExtensionDevToolsClientHost::DispatchOnInspectorFrontend( scoped_ptr<extensions::Event> event(new extensions::Event( OnEvent::kEventName, args.Pass())); event->restrict_to_browser_context = profile_; - extensions::ExtensionSystem::Get(profile_)->event_router()-> - DispatchEventToExtension(extension_id_, event.Pass()); + extensions::EventRouter::Get(profile_) + ->DispatchEventToExtension(extension_id_, event.Pass()); } else { DebuggerSendCommandFunction* function = pending_requests_[id].get(); if (!function) diff --git a/chrome/browser/extensions/api/developer_private/developer_private_api.cc b/chrome/browser/extensions/api/developer_private/developer_private_api.cc index 22954c2..3c79ed8 100644 --- a/chrome/browser/extensions/api/developer_private/developer_private_api.cc +++ b/chrome/browser/extensions/api/developer_private/developer_private_api.cc @@ -259,7 +259,7 @@ void DeveloperPrivateEventRouter::Observe( event_name = developer_private::OnItemStateChanged::kEventName; scoped_ptr<Event> event(new Event(event_name, args.Pass())); - ExtensionSystem::Get(profile)->event_router()->BroadcastEvent(event.Pass()); + EventRouter::Get(profile)->BroadcastEvent(event.Pass()); } void DeveloperPrivateEventRouter::OnErrorAdded(const ExtensionError* error) { @@ -276,9 +276,8 @@ void DeveloperPrivateEventRouter::OnErrorAdded(const ExtensionError* error) { scoped_ptr<base::ListValue> args(new base::ListValue); args->Append(event_data.ToValue().release()); - ExtensionSystem::Get(profile_)->event_router()->BroadcastEvent( - scoped_ptr<Event>(new Event( - developer_private::OnItemStateChanged::kEventName, args.Pass()))); + EventRouter::Get(profile_)->BroadcastEvent(scoped_ptr<Event>(new Event( + developer_private::OnItemStateChanged::kEventName, args.Pass()))); } void DeveloperPrivateAPI::SetLastUnpackedDirectory(const base::FilePath& path) { @@ -286,7 +285,7 @@ void DeveloperPrivateAPI::SetLastUnpackedDirectory(const base::FilePath& path) { } void DeveloperPrivateAPI::RegisterNotifications() { - ExtensionSystem::Get(profile_)->event_router()->RegisterObserver( + EventRouter::Get(profile_)->RegisterObserver( this, developer_private::OnItemStateChanged::kEventName); } @@ -306,8 +305,8 @@ void DeveloperPrivateAPI::OnListenerAdded( void DeveloperPrivateAPI::OnListenerRemoved( const EventListenerInfo& details) { - if (!ExtensionSystem::Get(profile_)->event_router()->HasEventListener( - developer_private::OnItemStateChanged::kEventName)) { + if (!EventRouter::Get(profile_)->HasEventListener( + developer_private::OnItemStateChanged::kEventName)) { developer_private_event_router_.reset(NULL); } else { developer_private_event_router_->RemoveExtensionId(details.extension_id); diff --git a/chrome/browser/extensions/api/dial/dial_api.cc b/chrome/browser/extensions/api/dial/dial_api.cc index 36f9805..f9a9539 100644 --- a/chrome/browser/extensions/api/dial/dial_api.cc +++ b/chrome/browser/extensions/api/dial/dial_api.cc @@ -39,8 +39,8 @@ namespace dial = api::dial; DialAPI::DialAPI(Profile* profile) : RefcountedBrowserContextKeyedService(BrowserThread::IO), profile_(profile) { - ExtensionSystem::Get(profile)->event_router()->RegisterObserver( - this, dial::OnDeviceList::kEventName); + EventRouter::Get(profile) + ->RegisterObserver(this, dial::OnDeviceList::kEventName); } DialAPI::~DialAPI() {} @@ -108,8 +108,7 @@ void DialAPI::SendEventOnUIThread(const DialRegistry::DeviceList& devices) { scoped_ptr<base::ListValue> results = api::dial::OnDeviceList::Create(args); scoped_ptr<Event> event( new Event(dial::OnDeviceList::kEventName, results.Pass())); - extensions::ExtensionSystem::Get(profile_)->event_router()-> - BroadcastEvent(event.Pass()); + EventRouter::Get(profile_)->BroadcastEvent(event.Pass()); } void DialAPI::SendErrorOnUIThread(const DialRegistry::DialErrorCode code) { @@ -139,8 +138,7 @@ void DialAPI::SendErrorOnUIThread(const DialRegistry::DialErrorCode code) { scoped_ptr<base::ListValue> results = api::dial::OnError::Create(dial_error); scoped_ptr<Event> event(new Event(dial::OnError::kEventName, results.Pass())); - extensions::ExtensionSystem::Get(profile_)->event_router()-> - BroadcastEvent(event.Pass()); + EventRouter::Get(profile_)->BroadcastEvent(event.Pass()); } void DialAPI::ShutdownOnUIThread() {} diff --git a/chrome/browser/extensions/api/downloads/downloads_api.cc b/chrome/browser/extensions/api/downloads/downloads_api.cc index 7342c694..616ccf3 100644 --- a/chrome/browser/extensions/api/downloads/downloads_api.cc +++ b/chrome/browser/extensions/api/downloads/downloads_api.cc @@ -1861,7 +1861,7 @@ void ExtensionDownloadsEventRouter::DispatchEvent( const extensions::Event::WillDispatchCallback& will_dispatch_callback, base::Value* arg) { DCHECK_CURRENTLY_ON(BrowserThread::UI); - if (!extensions::ExtensionSystem::Get(profile_)->event_router()) + if (!extensions::EventRouter::Get(profile_)) return; scoped_ptr<base::ListValue> args(new base::ListValue()); args->Append(arg); @@ -1877,8 +1877,7 @@ void ExtensionDownloadsEventRouter::DispatchEvent( event->restrict_to_browser_context = (include_incognito && !profile_->IsOffTheRecord()) ? NULL : profile_; event->will_dispatch_callback = will_dispatch_callback; - extensions::ExtensionSystem::Get(profile_)->event_router()-> - BroadcastEvent(event.Pass()); + extensions::EventRouter::Get(profile_)->BroadcastEvent(event.Pass()); DownloadsNotificationSource notification_source; notification_source.event_name = event_name; notification_source.profile = profile_; diff --git a/chrome/browser/extensions/api/extension_action/extension_action_api.cc b/chrome/browser/extensions/api/extension_action/extension_action_api.cc index d3f003e..4925b68 100644 --- a/chrome/browser/extensions/api/extension_action/extension_action_api.cc +++ b/chrome/browser/extensions/api/extension_action/extension_action_api.cc @@ -350,14 +350,14 @@ void ExtensionActionAPI::DispatchEventToExtension( const std::string& extension_id, const std::string& event_name, scoped_ptr<base::ListValue> event_args) { - if (!extensions::ExtensionSystem::Get(context)->event_router()) + if (!extensions::EventRouter::Get(context)) return; scoped_ptr<Event> event(new Event(event_name, event_args.Pass())); event->restrict_to_browser_context = context; event->user_gesture = EventRouter::USER_GESTURE_ENABLED; - ExtensionSystem::Get(context)->event_router()->DispatchEventToExtension( - extension_id, event.Pass()); + EventRouter::Get(context) + ->DispatchEventToExtension(extension_id, event.Pass()); } // static diff --git a/chrome/browser/extensions/api/feedback_private/feedback_private_api.cc b/chrome/browser/extensions/api/feedback_private/feedback_private_api.cc index bbbb789..5cbc565 100644 --- a/chrome/browser/extensions/api/feedback_private/feedback_private_api.cc +++ b/chrome/browser/extensions/api/feedback_private/feedback_private_api.cc @@ -14,7 +14,6 @@ #include "chrome/browser/feedback/tracing_manager.h" #include "chrome/browser/profiles/profile.h" #include "extensions/browser/event_router.h" -#include "extensions/browser/extension_system.h" #include "grit/generated_resources.h" #include "ui/base/l10n/l10n_util.h" #include "ui/base/webui/web_ui_util.h" @@ -69,8 +68,7 @@ void FeedbackPrivateAPI::RequestFeedback( const GURL& page_url) { // TODO(rkc): Remove logging once crbug.com/284662 is closed. LOG(WARNING) << "FEEDBACK_DEBUG: Feedback requested."; - if (browser_context_ && - ExtensionSystem::Get(browser_context_)->event_router()) { + if (browser_context_ && EventRouter::Get(browser_context_)) { FeedbackInfo info; info.description = description_template; info.category_tag = make_scoped_ptr(new std::string(category_tag)); @@ -90,8 +88,7 @@ void FeedbackPrivateAPI::RequestFeedback( // TODO(rkc): Remove logging once crbug.com/284662 is closed. LOG(WARNING) << "FEEDBACK_DEBUG: Dispatching onFeedbackRequested event."; - ExtensionSystem::Get(browser_context_) - ->event_router() + EventRouter::Get(browser_context_) ->DispatchEventToExtension(kFeedbackExtensionId, event.Pass()); } } diff --git a/chrome/browser/extensions/api/gcm/gcm_api.cc b/chrome/browser/extensions/api/gcm/gcm_api.cc index 65b1d49..7fe632a 100644 --- a/chrome/browser/extensions/api/gcm/gcm_api.cc +++ b/chrome/browser/extensions/api/gcm/gcm_api.cc @@ -15,7 +15,6 @@ #include "chrome/browser/services/gcm/gcm_profile_service.h" #include "chrome/browser/services/gcm/gcm_profile_service_factory.h" #include "chrome/common/extensions/api/gcm.h" -#include "extensions/browser/extension_system.h" #include "extensions/common/extension.h" namespace { @@ -197,19 +196,19 @@ bool GcmSendFunction::ValidateMessageData( } GcmJsEventRouter::GcmJsEventRouter(Profile* profile) : profile_(profile) { - if (ExtensionSystem::Get(profile_)->event_router()) { - ExtensionSystem::Get(profile_)->event_router()->RegisterObserver( - this, api::gcm::OnMessage::kEventName); - ExtensionSystem::Get(profile_)->event_router()->RegisterObserver( - this, api::gcm::OnMessagesDeleted::kEventName); - ExtensionSystem::Get(profile_)->event_router()->RegisterObserver( - this, api::gcm::OnSendError::kEventName); - } + EventRouter* event_router = EventRouter::Get(profile_); + if (!event_router) + return; + + event_router->RegisterObserver(this, api::gcm::OnMessage::kEventName); + event_router->RegisterObserver(this, api::gcm::OnMessagesDeleted::kEventName); + event_router->RegisterObserver(this, api::gcm::OnSendError::kEventName); } GcmJsEventRouter::~GcmJsEventRouter() { - if (ExtensionSystem::Get(profile_)->event_router()) - ExtensionSystem::Get(profile_)->event_router()->UnregisterObserver(this); + EventRouter* event_router = EventRouter::Get(profile_); + if (event_router) + event_router->UnregisterObserver(this); } void GcmJsEventRouter::OnMessage( @@ -224,8 +223,7 @@ void GcmJsEventRouter::OnMessage( api::gcm::OnMessage::kEventName, api::gcm::OnMessage::Create(message_arg).Pass(), profile_)); - ExtensionSystem::Get(profile_)->event_router()->DispatchEventToExtension( - app_id, event.Pass()); + EventRouter::Get(profile_)->DispatchEventToExtension(app_id, event.Pass()); } void GcmJsEventRouter::OnMessagesDeleted(const std::string& app_id) { @@ -233,8 +231,7 @@ void GcmJsEventRouter::OnMessagesDeleted(const std::string& app_id) { api::gcm::OnMessagesDeleted::kEventName, api::gcm::OnMessagesDeleted::Create().Pass(), profile_)); - ExtensionSystem::Get(profile_)->event_router()->DispatchEventToExtension( - app_id, event.Pass()); + EventRouter::Get(profile_)->DispatchEventToExtension(app_id, event.Pass()); } void GcmJsEventRouter::OnSendError( @@ -249,8 +246,7 @@ void GcmJsEventRouter::OnSendError( api::gcm::OnSendError::kEventName, api::gcm::OnSendError::Create(error).Pass(), profile_)); - ExtensionSystem::Get(profile_)->event_router()->DispatchEventToExtension( - app_id, event.Pass()); + EventRouter::Get(profile_)->DispatchEventToExtension(app_id, event.Pass()); } void GcmJsEventRouter::OnListenerAdded(const EventListenerInfo& details) { diff --git a/chrome/browser/extensions/api/history/history_api.cc b/chrome/browser/extensions/api/history/history_api.cc index 654e1d3..cd216a1 100644 --- a/chrome/browser/extensions/api/history/history_api.cc +++ b/chrome/browser/extensions/api/history/history_api.cc @@ -30,7 +30,6 @@ #include "content/public/browser/notification_details.h" #include "content/public/browser/notification_source.h" #include "extensions/browser/event_router.h" -#include "extensions/browser/extension_system.h" #include "extensions/browser/extension_system_provider.h" #include "extensions/browser/extensions_browser_client.h" @@ -193,29 +192,27 @@ void HistoryEventRouter::DispatchEvent( Profile* profile, const std::string& event_name, scoped_ptr<base::ListValue> event_args) { - if (profile && extensions::ExtensionSystem::Get(profile)->event_router()) { + if (profile && extensions::EventRouter::Get(profile)) { scoped_ptr<extensions::Event> event(new extensions::Event( event_name, event_args.Pass())); event->restrict_to_browser_context = profile; - extensions::ExtensionSystem::Get(profile)->event_router()-> - BroadcastEvent(event.Pass()); + extensions::EventRouter::Get(profile)->BroadcastEvent(event.Pass()); } } HistoryAPI::HistoryAPI(content::BrowserContext* context) : browser_context_(context) { - ExtensionSystem::Get(browser_context_)->event_router()->RegisterObserver( - this, api::history::OnVisited::kEventName); - ExtensionSystem::Get(browser_context_)->event_router()->RegisterObserver( - this, api::history::OnVisitRemoved::kEventName); + EventRouter* event_router = EventRouter::Get(browser_context_); + event_router->RegisterObserver(this, api::history::OnVisited::kEventName); + event_router->RegisterObserver(this, + api::history::OnVisitRemoved::kEventName); } HistoryAPI::~HistoryAPI() { } void HistoryAPI::Shutdown() { - ExtensionSystem::Get(browser_context_)->event_router()->UnregisterObserver( - this); + EventRouter::Get(browser_context_)->UnregisterObserver(this); } static base::LazyInstance<BrowserContextKeyedAPIFactory<HistoryAPI> > @@ -235,8 +232,7 @@ void BrowserContextKeyedAPIFactory<HistoryAPI>::DeclareFactoryDependencies() { void HistoryAPI::OnListenerAdded(const EventListenerInfo& details) { history_event_router_.reset( new HistoryEventRouter(Profile::FromBrowserContext(browser_context_))); - ExtensionSystem::Get(browser_context_)->event_router()->UnregisterObserver( - this); + EventRouter::Get(browser_context_)->UnregisterObserver(this); } void HistoryFunction::Run() { diff --git a/chrome/browser/extensions/api/hotword_private/hotword_private_api.cc b/chrome/browser/extensions/api/hotword_private/hotword_private_api.cc index 1e1c7ef..dc86119 100644 --- a/chrome/browser/extensions/api/hotword_private/hotword_private_api.cc +++ b/chrome/browser/extensions/api/hotword_private/hotword_private_api.cc @@ -11,7 +11,6 @@ #include "chrome/browser/search/hotword_service_factory.h" #include "chrome/common/pref_names.h" #include "extensions/browser/event_router.h" -#include "extensions/browser/extension_system.h" namespace extensions { @@ -58,7 +57,7 @@ void HotwordPrivateEventService::OnEnabledChanged( void HotwordPrivateEventService::SignalEvent() { using OnEnabledChanged::kEventName; - EventRouter* router = ExtensionSystem::Get(profile_)->event_router(); + EventRouter* router = EventRouter::Get(profile_); if (!router || !router->HasEventListener(kEventName)) return; scoped_ptr<base::ListValue> args(new base::ListValue()); diff --git a/chrome/browser/extensions/api/identity/identity_api.cc b/chrome/browser/extensions/api/identity/identity_api.cc index 3b580e3..3a096e9 100644 --- a/chrome/browser/extensions/api/identity/identity_api.cc +++ b/chrome/browser/extensions/api/identity/identity_api.cc @@ -30,7 +30,6 @@ #include "components/signin/core/browser/signin_manager.h" #include "extensions/browser/event_router.h" #include "extensions/browser/extension_function_dispatcher.h" -#include "extensions/browser/extension_system.h" #include "extensions/common/extension.h" #include "google_apis/gaia/gaia_urls.h" #include "url/gurl.h" @@ -207,8 +206,7 @@ void IdentityAPI::OnAccountSignInChanged(const AccountIds& ids, args.Pass(), browser_context_)); - ExtensionSystem::Get(browser_context_)->event_router()->BroadcastEvent( - event.Pass()); + EventRouter::Get(browser_context_)->BroadcastEvent(event.Pass()); } void IdentityAPI::AddShutdownObserver(ShutdownObserver* observer) { diff --git a/chrome/browser/extensions/api/idle/idle_manager.cc b/chrome/browser/extensions/api/idle/idle_manager.cc index 450270d..e9fa969 100644 --- a/chrome/browser/extensions/api/idle/idle_manager.cc +++ b/chrome/browser/extensions/api/idle/idle_manager.cc @@ -15,7 +15,6 @@ #include "content/public/browser/notification_details.h" #include "content/public/browser/notification_source.h" #include "extensions/browser/event_router.h" -#include "extensions/browser/extension_system.h" #include "extensions/common/extension.h" namespace keys = extensions::idle_api_constants; @@ -56,21 +55,20 @@ void DefaultEventDelegate::OnStateChanged(const std::string& extension_id, scoped_ptr<Event> event(new Event(idle::OnStateChanged::kEventName, args.Pass())); event->restrict_to_browser_context = profile_; - ExtensionSystem::Get(profile_)->event_router()->DispatchEventToExtension( - extension_id, event.Pass()); + EventRouter::Get(profile_) + ->DispatchEventToExtension(extension_id, event.Pass()); } void DefaultEventDelegate::RegisterObserver( EventRouter::Observer* observer) { - ExtensionSystem::Get(profile_)->event_router()->RegisterObserver( - observer, idle::OnStateChanged::kEventName); + EventRouter::Get(profile_) + ->RegisterObserver(observer, idle::OnStateChanged::kEventName); } void DefaultEventDelegate::UnregisterObserver(EventRouter::Observer* observer) { - ExtensionSystem::Get(profile_)->event_router()->UnregisterObserver(observer); + EventRouter::Get(profile_)->UnregisterObserver(observer); } - class DefaultIdleProvider : public IdleManager::IdleTimeProvider { public: DefaultIdleProvider(); diff --git a/chrome/browser/extensions/api/image_writer_private/operation_manager.cc b/chrome/browser/extensions/api/image_writer_private/operation_manager.cc index 794858b..fa99aff 100644 --- a/chrome/browser/extensions/api/image_writer_private/operation_manager.cc +++ b/chrome/browser/extensions/api/image_writer_private/operation_manager.cc @@ -18,7 +18,6 @@ #include "content/public/browser/notification_service.h" #include "extensions/browser/event_router.h" #include "extensions/browser/extension_host.h" -#include "extensions/browser/extension_system.h" namespace image_writer_api = extensions::api::image_writer_private; @@ -150,8 +149,8 @@ void OperationManager::OnProgress(const ExtensionId& extension_id, scoped_ptr<Event> event(new Event( image_writer_api::OnWriteProgress::kEventName, args.Pass())); - ExtensionSystem::Get(profile_)->event_router()-> - DispatchEventToExtension(extension_id, event.Pass()); + EventRouter::Get(profile_) + ->DispatchEventToExtension(extension_id, event.Pass()); } void OperationManager::OnComplete(const ExtensionId& extension_id) { @@ -161,8 +160,8 @@ void OperationManager::OnComplete(const ExtensionId& extension_id) { scoped_ptr<Event> event(new Event( image_writer_api::OnWriteComplete::kEventName, args.Pass())); - ExtensionSystem::Get(profile_)->event_router()-> - DispatchEventToExtension(extension_id, event.Pass()); + EventRouter::Get(profile_) + ->DispatchEventToExtension(extension_id, event.Pass()); DeleteOperation(extension_id); } @@ -184,8 +183,8 @@ void OperationManager::OnError(const ExtensionId& extension_id, scoped_ptr<Event> event(new Event( image_writer_api::OnWriteError::kEventName, args.Pass())); - ExtensionSystem::Get(profile_)->event_router()-> - DispatchEventToExtension(extension_id, event.Pass()); + EventRouter::Get(profile_) + ->DispatchEventToExtension(extension_id, event.Pass()); DeleteOperation(extension_id); } diff --git a/chrome/browser/extensions/api/input_ime/input_ime_api.cc b/chrome/browser/extensions/api/input_ime/input_ime_api.cc index 31d5966..b97b427 100644 --- a/chrome/browser/extensions/api/input_ime/input_ime_api.cc +++ b/chrome/browser/extensions/api/input_ime/input_ime_api.cc @@ -15,7 +15,6 @@ #include "content/public/browser/notification_source.h" #include "extensions/browser/event_router.h" #include "extensions/browser/extension_function_registry.h" -#include "extensions/browser/extension_system.h" #if defined(USE_X11) #include "chrome/browser/chromeos/input_method/input_method_engine.h" @@ -79,8 +78,8 @@ static void DispatchEventToExtension(Profile* profile, scoped_ptr<extensions::Event> event(new extensions::Event( event_name, args.Pass())); event->restrict_to_browser_context = profile; - extensions::ExtensionSystem::Get(profile)->event_router()-> - DispatchEventToExtension(extension_id, event.Pass()); + extensions::EventRouter::Get(profile) + ->DispatchEventToExtension(extension_id, event.Pass()); } } // namespace @@ -280,8 +279,7 @@ class ImeObserver : public InputMethodEngineInterface::Observer { private: bool HasKeyEventListener() const { - return extensions::ExtensionSystem::Get(profile_) - ->event_router() + return extensions::EventRouter::Get(profile_) ->ExtensionHasEventListener(extension_id_, input_ime::OnKeyEvent::kEventName); } @@ -786,13 +784,13 @@ InputImeAPI::InputImeAPI(content::BrowserContext* context) chrome::NOTIFICATION_EXTENSION_UNLOADED_DEPRECATED, content::Source<Profile>(profile_)); - EventRouter* event_router = ExtensionSystem::Get(profile_)->event_router(); + EventRouter* event_router = EventRouter::Get(profile_); event_router->RegisterObserver(this, input_ime::OnActivate::kEventName); event_router->RegisterObserver(this, input_ime::OnFocus::kEventName); } InputImeAPI::~InputImeAPI() { - ExtensionSystem::Get(profile_)->event_router()->UnregisterObserver(this); + EventRouter::Get(profile_)->UnregisterObserver(this); } static base::LazyInstance<BrowserContextKeyedAPIFactory<InputImeAPI> > diff --git a/chrome/browser/extensions/api/location/location_manager.cc b/chrome/browser/extensions/api/location/location_manager.cc index 35ed634..7a07980 100644 --- a/chrome/browser/extensions/api/location/location_manager.cc +++ b/chrome/browser/extensions/api/location/location_manager.cc @@ -393,8 +393,8 @@ void LocationManager::SendLocationUpdate( scoped_ptr<Event> event(new Event(event_name, args.Pass())); - ExtensionSystem::Get(profile_)->event_router()-> - DispatchEventToExtension(extension_id, event.Pass()); + EventRouter::Get(profile_) + ->DispatchEventToExtension(extension_id, event.Pass()); } void LocationManager::Observe(int type, diff --git a/chrome/browser/extensions/api/log_private/log_private_api_chromeos.cc b/chrome/browser/extensions/api/log_private/log_private_api_chromeos.cc index 2a595cc..bd3d2a1 100644 --- a/chrome/browser/extensions/api/log_private/log_private_api_chromeos.cc +++ b/chrome/browser/extensions/api/log_private/log_private_api_chromeos.cc @@ -26,7 +26,6 @@ #include "content/public/browser/notification_source.h" #include "extensions/browser/event_router.h" #include "extensions/browser/extension_function.h" -#include "extensions/browser/extension_system.h" using content::BrowserThread; @@ -134,8 +133,7 @@ void LogPrivateAPI::AddEntriesOnUI(scoped_ptr<base::ListValue> value) { event_args->Append(value->DeepCopy()); scoped_ptr<Event> event(new Event(events::kOnAddNetInternalsEntries, event_args.Pass())); - ExtensionSystem::Get(profile_)->event_router()->DispatchEventToExtension( - *ix, event.Pass()); + EventRouter::Get(profile_)->DispatchEventToExtension(*ix, event.Pass()); } } diff --git a/chrome/browser/extensions/api/management/management_api.cc b/chrome/browser/extensions/api/management/management_api.cc index c4473fd..e34ba8e 100644 --- a/chrome/browser/extensions/api/management/management_api.cc +++ b/chrome/browser/extensions/api/management/management_api.cc @@ -714,13 +714,12 @@ void ManagementEventRouter::Observe( } scoped_ptr<Event> event(new Event(event_name, args.Pass())); - ExtensionSystem::Get(profile)->event_router()->BroadcastEvent(event.Pass()); + EventRouter::Get(profile)->BroadcastEvent(event.Pass()); } ManagementAPI::ManagementAPI(content::BrowserContext* context) : browser_context_(context) { - EventRouter* event_router = - ExtensionSystem::Get(browser_context_)->event_router(); + EventRouter* event_router = EventRouter::Get(browser_context_); event_router->RegisterObserver(this, management::OnInstalled::kEventName); event_router->RegisterObserver(this, management::OnUninstalled::kEventName); event_router->RegisterObserver(this, management::OnEnabled::kEventName); @@ -731,8 +730,7 @@ ManagementAPI::~ManagementAPI() { } void ManagementAPI::Shutdown() { - ExtensionSystem::Get(browser_context_)->event_router()->UnregisterObserver( - this); + EventRouter::Get(browser_context_)->UnregisterObserver(this); } static base::LazyInstance<BrowserContextKeyedAPIFactory<ManagementAPI> > @@ -747,8 +745,7 @@ ManagementAPI::GetFactoryInstance() { void ManagementAPI::OnListenerAdded(const EventListenerInfo& details) { management_event_router_.reset( new ManagementEventRouter(Profile::FromBrowserContext(browser_context_))); - ExtensionSystem::Get(browser_context_)->event_router()->UnregisterObserver( - this); + EventRouter::Get(browser_context_)->UnregisterObserver(this); } } // namespace extensions diff --git a/chrome/browser/extensions/api/mdns/mdns_api.cc b/chrome/browser/extensions/api/mdns/mdns_api.cc index b67e4a5..2e61ec9 100644 --- a/chrome/browser/extensions/api/mdns/mdns_api.cc +++ b/chrome/browser/extensions/api/mdns/mdns_api.cc @@ -9,7 +9,6 @@ #include "base/lazy_instance.h" #include "chrome/browser/extensions/extension_service.h" #include "chrome/common/extensions/api/mdns.h" -#include "extensions/browser/extension_system.h" namespace extensions { @@ -32,8 +31,8 @@ bool IsServiceTypeWhitelisted(const std::string& service_type) { MDnsAPI::MDnsAPI(content::BrowserContext* context) : browser_context_(context) { DCHECK(browser_context_); - ExtensionSystem::Get(context)->event_router()->RegisterObserver( - this, mdns::OnServiceList::kEventName); + EventRouter::Get(context) + ->RegisterObserver(this, mdns::OnServiceList::kEventName); } MDnsAPI::~MDnsAPI() { @@ -84,8 +83,7 @@ void MDnsAPI::UpdateMDnsListeners(const EventListenerInfo& details) { // Check all listeners for service type filers. const EventListenerMap::ListenerList& listeners = - extensions::ExtensionSystem::Get(browser_context_) - ->event_router() + extensions::EventRouter::Get(browser_context_) ->listeners() .GetEventListenersByName(details.event_name); for (EventListenerMap::ListenerList::const_iterator it = listeners.begin(); @@ -149,9 +147,7 @@ void MDnsAPI::OnDnsSdEvent(const std::string& service_type, // TODO(justinlin): To avoid having listeners without filters getting all // events, modify API to have this event require filters. - extensions::ExtensionSystem::Get(browser_context_) - ->event_router() - ->BroadcastEvent(event.Pass()); + extensions::EventRouter::Get(browser_context_)->BroadcastEvent(event.Pass()); } } // namespace extensions diff --git a/chrome/browser/extensions/api/media_galleries/media_galleries_api.cc b/chrome/browser/extensions/api/media_galleries/media_galleries_api.cc index 170f01a..171111b 100644 --- a/chrome/browser/extensions/api/media_galleries/media_galleries_api.cc +++ b/chrome/browser/extensions/api/media_galleries/media_galleries_api.cc @@ -302,10 +302,8 @@ MediaGalleriesEventRouter* MediaGalleriesEventRouter::Get( bool MediaGalleriesEventRouter::ExtensionHasScanProgressListener( const std::string& extension_id) const { - EventRouter* router = ExtensionSystem::Get(profile_)->event_router(); - return router->ExtensionHasEventListener( - extension_id, - MediaGalleries::OnScanProgress::kEventName); + return EventRouter::Get(profile_)->ExtensionHasEventListener( + extension_id, MediaGalleries::OnScanProgress::kEventName); } void MediaGalleriesEventRouter::OnScanStarted(const std::string& extension_id) { @@ -358,8 +356,7 @@ void MediaGalleriesEventRouter::DispatchEventToExtension( const std::string& event_name, scoped_ptr<base::ListValue> event_args) { DCHECK_CURRENTLY_ON(content::BrowserThread::UI); - EventRouter* router = - extensions::ExtensionSystem::Get(profile_)->event_router(); + EventRouter* router = EventRouter::Get(profile_); if (!router->ExtensionHasEventListener(extension_id, event_name)) return; diff --git a/chrome/browser/extensions/api/media_galleries_private/media_galleries_private_api.cc b/chrome/browser/extensions/api/media_galleries_private/media_galleries_private_api.cc index f5801f0..3bd212a 100644 --- a/chrome/browser/extensions/api/media_galleries_private/media_galleries_private_api.cc +++ b/chrome/browser/extensions/api/media_galleries_private/media_galleries_private_api.cc @@ -84,7 +84,7 @@ MediaGalleriesPrivateAPI::MediaGalleriesPrivateAPI( content::BrowserContext* context) : profile_(Profile::FromBrowserContext(context)), weak_ptr_factory_(this) { DCHECK(profile_); - EventRouter* event_router = ExtensionSystem::Get(profile_)->event_router(); + EventRouter* event_router = EventRouter::Get(profile_); event_router->RegisterObserver( this, media_galleries_private::OnGalleryChanged::kEventName); } @@ -93,7 +93,7 @@ MediaGalleriesPrivateAPI::~MediaGalleriesPrivateAPI() { } void MediaGalleriesPrivateAPI::Shutdown() { - ExtensionSystem::Get(profile_)->event_router()->UnregisterObserver(this); + EventRouter::Get(profile_)->UnregisterObserver(this); weak_ptr_factory_.InvalidateWeakPtrs(); content::BrowserThread::PostTask( content::BrowserThread::FILE, FROM_HERE, diff --git a/chrome/browser/extensions/api/media_galleries_private/media_galleries_private_event_router.cc b/chrome/browser/extensions/api/media_galleries_private/media_galleries_private_event_router.cc index 51f8450..64598da 100644 --- a/chrome/browser/extensions/api/media_galleries_private/media_galleries_private_event_router.cc +++ b/chrome/browser/extensions/api/media_galleries_private/media_galleries_private_event_router.cc @@ -11,7 +11,6 @@ #include "chrome/common/extensions/api/media_galleries_private.h" #include "content/public/browser/browser_thread.h" #include "extensions/browser/event_router.h" -#include "extensions/browser/extension_system.h" namespace media_galleries_private = extensions::api::media_galleries_private; @@ -34,8 +33,7 @@ void MediaGalleriesPrivateEventRouter::OnGalleryChanged( MediaGalleryPrefId gallery_id, const std::set<std::string>& extension_ids) { DCHECK_CURRENTLY_ON(content::BrowserThread::UI); - EventRouter* router = - extensions::ExtensionSystem::Get(profile_)->event_router(); + EventRouter* router = EventRouter::Get(profile_); if (!router->HasEventListener( media_galleries_private::OnGalleryChanged::kEventName)) return; diff --git a/chrome/browser/extensions/api/networking_private/networking_private_event_router_chromeos.cc b/chrome/browser/extensions/api/networking_private/networking_private_event_router_chromeos.cc index 69ed66d..73f3a63 100644 --- a/chrome/browser/extensions/api/networking_private/networking_private_event_router_chromeos.cc +++ b/chrome/browser/extensions/api/networking_private/networking_private_event_router_chromeos.cc @@ -74,7 +74,7 @@ NetworkingPrivateEventRouterImpl::NetworkingPrivateEventRouterImpl( // our events. We first check and see if there *is* an event router, because // some unit tests try to create all profile services, but don't initialize // the event router first. - EventRouter* event_router = ExtensionSystem::Get(profile_)->event_router(); + EventRouter* event_router = EventRouter::Get(profile_); if (event_router) { event_router->RegisterObserver( this, api::networking_private::OnNetworksChanged::kEventName); @@ -94,7 +94,7 @@ void NetworkingPrivateEventRouterImpl::Shutdown() { // Unregister with the event router. We first check and see if there *is* an // event router, because some unit tests try to shutdown all profile services, // but didn't initialize the event router first. - EventRouter* event_router = ExtensionSystem::Get(profile_)->event_router(); + EventRouter* event_router = EventRouter::Get(profile_); if (event_router) event_router->UnregisterObserver(this); @@ -119,7 +119,7 @@ void NetworkingPrivateEventRouterImpl::OnListenerRemoved( } void NetworkingPrivateEventRouterImpl::StartOrStopListeningForNetworkChanges() { - EventRouter* event_router = ExtensionSystem::Get(profile_)->event_router(); + EventRouter* event_router = EventRouter::Get(profile_); bool should_listen = event_router->HasEventListener( api::networking_private::OnNetworksChanged::kEventName) || @@ -141,7 +141,7 @@ void NetworkingPrivateEventRouterImpl::StartOrStopListeningForNetworkChanges() { } void NetworkingPrivateEventRouterImpl::NetworkListChanged() { - EventRouter* event_router = ExtensionSystem::Get(profile_)->event_router(); + EventRouter* event_router = EventRouter::Get(profile_); NetworkStateHandler::NetworkStateList networks; NetworkHandler::Get()->network_state_handler()->GetNetworkList(&networks); if (!event_router->HasEventListener( @@ -174,7 +174,7 @@ void NetworkingPrivateEventRouterImpl::NetworkListChanged() { void NetworkingPrivateEventRouterImpl::NetworkPropertiesUpdated( const NetworkState* network) { - EventRouter* event_router = ExtensionSystem::Get(profile_)->event_router(); + EventRouter* event_router = EventRouter::Get(profile_); if (!event_router->HasEventListener( api::networking_private::OnNetworksChanged::kEventName)) { NET_LOG_EVENT("NetworkingPrivate.NetworkPropertiesUpdated: No Listeners", @@ -196,7 +196,7 @@ void NetworkingPrivateEventRouterImpl::OnPortalDetectionCompleted( const NetworkPortalDetector::CaptivePortalState& state) { const std::string path = network ? network->path() : std::string(); - EventRouter* event_router = ExtensionSystem::Get(profile_)->event_router(); + EventRouter* event_router = EventRouter::Get(profile_); if (!event_router->HasEventListener( api::networking_private::OnPortalDetectionCompleted::kEventName)) { NET_LOG_EVENT("NetworkingPrivate.OnPortalDetectionCompleted: No Listeners", diff --git a/chrome/browser/extensions/api/networking_private/networking_private_event_router_nonchromeos.cc b/chrome/browser/extensions/api/networking_private/networking_private_event_router_nonchromeos.cc index 71d74f6..d0e5319 100644 --- a/chrome/browser/extensions/api/networking_private/networking_private_event_router_nonchromeos.cc +++ b/chrome/browser/extensions/api/networking_private/networking_private_event_router_nonchromeos.cc @@ -9,7 +9,6 @@ #include "chrome/browser/extensions/api/networking_private/networking_private_service_client_factory.h" #include "chrome/browser/profiles/profile.h" #include "chrome/common/extensions/api/networking_private.h" -#include "extensions/browser/extension_system.h" namespace extensions { @@ -56,7 +55,7 @@ NetworkingPrivateEventRouterImpl::NetworkingPrivateEventRouterImpl( // our events. We first check and see if there *is* an event router, because // some unit tests try to create all profile services, but don't initialize // the event router first. - EventRouter* event_router = ExtensionSystem::Get(profile_)->event_router(); + EventRouter* event_router = EventRouter::Get(profile_); if (!event_router) return; event_router->RegisterObserver( @@ -74,7 +73,7 @@ void NetworkingPrivateEventRouterImpl::Shutdown() { // Unregister with the event router. We first check and see if there *is* an // event router, because some unit tests try to shutdown all profile services, // but didn't initialize the event router first. - EventRouter* event_router = ExtensionSystem::Get(profile_)->event_router(); + EventRouter* event_router = EventRouter::Get(profile_); if (event_router) event_router->UnregisterObserver(this); @@ -100,7 +99,7 @@ void NetworkingPrivateEventRouterImpl::OnListenerRemoved( } void NetworkingPrivateEventRouterImpl::StartOrStopListeningForNetworkChanges() { - EventRouter* event_router = ExtensionSystem::Get(profile_)->event_router(); + EventRouter* event_router = EventRouter::Get(profile_); if (!event_router) return; bool should_listen = @@ -126,7 +125,7 @@ void NetworkingPrivateEventRouterImpl::StartOrStopListeningForNetworkChanges() { void NetworkingPrivateEventRouterImpl::OnNetworksChangedEvent( const std::vector<std::string>& network_guids) { - EventRouter* event_router = ExtensionSystem::Get(profile_)->event_router(); + EventRouter* event_router = EventRouter::Get(profile_); if (!event_router) return; scoped_ptr<base::ListValue> args( @@ -138,7 +137,7 @@ void NetworkingPrivateEventRouterImpl::OnNetworksChangedEvent( void NetworkingPrivateEventRouterImpl::OnNetworkListChangedEvent( const std::vector<std::string>& network_guids) { - EventRouter* event_router = ExtensionSystem::Get(profile_)->event_router(); + EventRouter* event_router = EventRouter::Get(profile_); if (!event_router) return; scoped_ptr<base::ListValue> args( diff --git a/chrome/browser/extensions/api/notifications/notifications_api.cc b/chrome/browser/extensions/api/notifications/notifications_api.cc index 590eaa6..c8e68a4 100644 --- a/chrome/browser/extensions/api/notifications/notifications_api.cc +++ b/chrome/browser/extensions/api/notifications/notifications_api.cc @@ -21,7 +21,6 @@ #include "content/public/browser/render_view_host.h" #include "content/public/browser/web_contents.h" #include "extensions/browser/event_router.h" -#include "extensions/browser/extension_system.h" #include "extensions/common/extension.h" #include "extensions/common/features/feature.h" #include "third_party/skia/include/core/SkBitmap.h" @@ -158,7 +157,7 @@ class NotificationsApiDelegate : public NotificationDelegate { } virtual bool HasClickedListener() OVERRIDE { - return ExtensionSystem::Get(profile_)->event_router()->HasEventListener( + return EventRouter::Get(profile_)->HasEventListener( notifications::OnClicked::kEventName); } @@ -198,8 +197,8 @@ class NotificationsApiDelegate : public NotificationDelegate { void SendEvent(const std::string& name, scoped_ptr<base::ListValue> args) { scoped_ptr<Event> event(new Event(name, args.Pass())); - ExtensionSystem::Get(profile_)->event_router()->DispatchEventToExtension( - extension_id_, event.Pass()); + EventRouter::Get(profile_)->DispatchEventToExtension(extension_id_, + event.Pass()); } scoped_ptr<base::ListValue> CreateBaseEventArgs() { diff --git a/chrome/browser/extensions/api/omnibox/omnibox_api.cc b/chrome/browser/extensions/api/omnibox/omnibox_api.cc index 2e0a43d..6ae1b53 100644 --- a/chrome/browser/extensions/api/omnibox/omnibox_api.cc +++ b/chrome/browser/extensions/api/omnibox/omnibox_api.cc @@ -24,7 +24,6 @@ #include "extensions/browser/extension_prefs.h" #include "extensions/browser/extension_prefs_factory.h" #include "extensions/browser/extension_registry.h" -#include "extensions/browser/extension_system.h" #include "extensions/browser/extension_system_provider.h" #include "extensions/browser/extensions_browser_client.h" #include "extensions/common/extension.h" @@ -103,16 +102,17 @@ void ExtensionOmniboxEventRouter::OnInputStarted( omnibox::OnInputStarted::kEventName, make_scoped_ptr(new base::ListValue()))); event->restrict_to_browser_context = profile; - ExtensionSystem::Get(profile)->event_router()-> - DispatchEventToExtension(extension_id, event.Pass()); + EventRouter::Get(profile) + ->DispatchEventToExtension(extension_id, event.Pass()); } // static bool ExtensionOmniboxEventRouter::OnInputChanged( Profile* profile, const std::string& extension_id, const std::string& input, int suggest_id) { - if (!ExtensionSystem::Get(profile)->event_router()->ExtensionHasEventListener( - extension_id, omnibox::OnInputChanged::kEventName)) + EventRouter* event_router = EventRouter::Get(profile); + if (!event_router->ExtensionHasEventListener( + extension_id, omnibox::OnInputChanged::kEventName)) return false; scoped_ptr<base::ListValue> args(new base::ListValue()); @@ -122,8 +122,7 @@ bool ExtensionOmniboxEventRouter::OnInputChanged( scoped_ptr<Event> event(new Event(omnibox::OnInputChanged::kEventName, args.Pass())); event->restrict_to_browser_context = profile; - ExtensionSystem::Get(profile)->event_router()-> - DispatchEventToExtension(extension_id, event.Pass()); + event_router->DispatchEventToExtension(extension_id, event.Pass()); return true; } @@ -155,8 +154,8 @@ void ExtensionOmniboxEventRouter::OnInputEntered( scoped_ptr<Event> event(new Event(omnibox::OnInputEntered::kEventName, args.Pass())); event->restrict_to_browser_context = profile; - ExtensionSystem::Get(profile)->event_router()-> - DispatchEventToExtension(extension_id, event.Pass()); + EventRouter::Get(profile) + ->DispatchEventToExtension(extension_id, event.Pass()); content::NotificationService::current()->Notify( chrome::NOTIFICATION_EXTENSION_OMNIBOX_INPUT_ENTERED, @@ -171,8 +170,8 @@ void ExtensionOmniboxEventRouter::OnInputCancelled( omnibox::OnInputCancelled::kEventName, make_scoped_ptr(new base::ListValue()))); event->restrict_to_browser_context = profile; - ExtensionSystem::Get(profile)->event_router()-> - DispatchEventToExtension(extension_id, event.Pass()); + EventRouter::Get(profile) + ->DispatchEventToExtension(extension_id, event.Pass()); } OmniboxAPI::OmniboxAPI(content::BrowserContext* context) diff --git a/chrome/browser/extensions/api/preference/chrome_direct_setting_api.cc b/chrome/browser/extensions/api/preference/chrome_direct_setting_api.cc index d122cfe..c83f80f 100644 --- a/chrome/browser/extensions/api/preference/chrome_direct_setting_api.cc +++ b/chrome/browser/extensions/api/preference/chrome_direct_setting_api.cc @@ -42,9 +42,7 @@ class PreferenceWhitelist { std::string event_name = base::StringPrintf( kOnPrefChangeFormat, (*iter).c_str()); - ExtensionSystem::Get(profile)->event_router()->RegisterObserver( - observer, - event_name); + EventRouter::Get(profile)->RegisterObserver(observer, event_name); } } @@ -94,7 +92,7 @@ ChromeDirectSettingAPI::GetFactoryInstance() { // EventRouter::Observer implementation. void ChromeDirectSettingAPI::OnListenerAdded(const EventListenerInfo& details) { - ExtensionSystem::Get(profile_)->event_router()->UnregisterObserver(this); + EventRouter::Get(profile_)->UnregisterObserver(this); registrar_.Init(profile_->GetPrefs()); preference_whitelist.Get().RegisterPropertyListeners( profile_, @@ -123,7 +121,7 @@ void ChromeDirectSettingAPI::OnPrefChanged( PrefService* pref_service, const std::string& pref_key) { std::string event_name = base::StringPrintf(kOnPrefChangeFormat, pref_key.c_str()); - EventRouter* router = ExtensionSystem::Get(profile_)->event_router(); + EventRouter* router = EventRouter::Get(profile_); if (router && router->HasEventListener(event_name)) { const PrefService::Preference* preference = profile_->GetPrefs()->FindPreference(pref_key.c_str()); diff --git a/chrome/browser/extensions/api/preference/preference_api.cc b/chrome/browser/extensions/api/preference/preference_api.cc index a964595..26a088f 100644 --- a/chrome/browser/extensions/api/preference/preference_api.cc +++ b/chrome/browser/extensions/api/preference/preference_api.cc @@ -27,7 +27,6 @@ #include "extensions/browser/extension_pref_value_map.h" #include "extensions/browser/extension_pref_value_map_factory.h" #include "extensions/browser/extension_prefs_factory.h" -#include "extensions/browser/extension_system.h" #include "extensions/browser/extension_system_provider.h" #include "extensions/browser/extensions_browser_client.h" #include "extensions/browser/pref_names.h" @@ -413,8 +412,7 @@ PreferenceAPI::PreferenceAPI(content::BrowserContext* context) bool rv = PrefMapping::GetInstance()->FindEventForBrowserPref( kPrefMapping[i].browser_pref, &event_name, &permission); DCHECK(rv); - ExtensionSystem::Get(profile_)->event_router()->RegisterObserver( - this, event_name); + EventRouter::Get(profile_)->RegisterObserver(this, event_name); } content_settings_store()->AddObserver(this); } @@ -423,7 +421,7 @@ PreferenceAPI::~PreferenceAPI() { } void PreferenceAPI::Shutdown() { - ExtensionSystem::Get(profile_)->event_router()->UnregisterObserver(this); + EventRouter::Get(profile_)->UnregisterObserver(this); if (!extension_prefs()->extensions_disabled()) ClearIncognitoSessionOnlyContentSettings(); content_settings_store()->RemoveObserver(this); @@ -445,7 +443,7 @@ PreferenceAPI* PreferenceAPI::Get(content::BrowserContext* context) { void PreferenceAPI::OnListenerAdded(const EventListenerInfo& details) { preference_event_router_.reset(new PreferenceEventRouter(profile_)); - ExtensionSystem::Get(profile_)->event_router()->UnregisterObserver(this); + EventRouter::Get(profile_)->UnregisterObserver(this); } void PreferenceAPI::OnContentSettingChanged(const std::string& extension_id, diff --git a/chrome/browser/extensions/api/preference/preference_helpers.cc b/chrome/browser/extensions/api/preference/preference_helpers.cc index fe55fd7..09b00f3 100644 --- a/chrome/browser/extensions/api/preference/preference_helpers.cc +++ b/chrome/browser/extensions/api/preference/preference_helpers.cc @@ -89,8 +89,7 @@ void DispatchEventToExtensions( APIPermission::ID permission, bool incognito, const std::string& browser_pref) { - EventRouter* router = - ExtensionSystem::Get(profile)->event_router(); + EventRouter* router = EventRouter::Get(profile); if (!router || !router->HasEventListener(event_name)) return; ExtensionService* extension_service = diff --git a/chrome/browser/extensions/api/processes/processes_api.cc b/chrome/browser/extensions/api/processes/processes_api.cc index 852a64c..70bc204 100644 --- a/chrome/browser/extensions/api/processes/processes_api.cc +++ b/chrome/browser/extensions/api/processes/processes_api.cc @@ -34,7 +34,6 @@ #include "extensions/browser/event_router.h" #include "extensions/browser/extension_function_registry.h" #include "extensions/browser/extension_function_util.h" -#include "extensions/browser/extension_system.h" #include "extensions/common/error_utils.h" namespace extensions { @@ -470,29 +469,25 @@ void ProcessesEventRouter::ProcessClosedEvent( void ProcessesEventRouter::DispatchEvent( const std::string& event_name, scoped_ptr<base::ListValue> event_args) { - if (extensions::ExtensionSystem::Get(browser_context_)->event_router()) { + EventRouter* event_router = EventRouter::Get(browser_context_); + if (event_router) { scoped_ptr<extensions::Event> event(new extensions::Event( event_name, event_args.Pass())); - extensions::ExtensionSystem::Get(browser_context_) - ->event_router() - ->BroadcastEvent(event.Pass()); + event_router->BroadcastEvent(event.Pass()); } } bool ProcessesEventRouter::HasEventListeners(const std::string& event_name) { - extensions::EventRouter* router = - extensions::ExtensionSystem::Get(browser_context_)->event_router(); - if (router && router->HasEventListener(event_name)) - return true; - return false; + EventRouter* event_router = EventRouter::Get(browser_context_); + return event_router && event_router->HasEventListener(event_name); } ProcessesAPI::ProcessesAPI(content::BrowserContext* context) : browser_context_(context) { - ExtensionSystem::Get(browser_context_)->event_router()->RegisterObserver( - this, processes_api_constants::kOnUpdated); - ExtensionSystem::Get(browser_context_)->event_router()->RegisterObserver( - this, processes_api_constants::kOnUpdatedWithMemory); + EventRouter* event_router = EventRouter::Get(browser_context_); + event_router->RegisterObserver(this, processes_api_constants::kOnUpdated); + event_router->RegisterObserver(this, + processes_api_constants::kOnUpdatedWithMemory); ExtensionFunctionRegistry* registry = ExtensionFunctionRegistry::GetInstance(); registry->RegisterFunction<extensions::GetProcessIdForTabFunction>(); @@ -504,8 +499,7 @@ ProcessesAPI::~ProcessesAPI() { } void ProcessesAPI::Shutdown() { - ExtensionSystem::Get(browser_context_)->event_router()->UnregisterObserver( - this); + EventRouter::Get(browser_context_)->UnregisterObserver(this); } static base::LazyInstance<BrowserContextKeyedAPIFactory<ProcessesAPI> > diff --git a/chrome/browser/extensions/api/streams_private/streams_private_apitest.cc b/chrome/browser/extensions/api/streams_private/streams_private_apitest.cc index fd418c9..ddcbc0f 100644 --- a/chrome/browser/extensions/api/streams_private/streams_private_apitest.cc +++ b/chrome/browser/extensions/api/streams_private/streams_private_apitest.cc @@ -174,8 +174,8 @@ class StreamsPrivateApiTest : public ExtensionApiTest { new Event(streams_private::OnExecuteMimeTypeHandler::kEventName, streams_private::OnExecuteMimeTypeHandler::Create(info))); - ExtensionSystem::Get(browser()->profile())->event_router()-> - DispatchEventToExtension(test_extension_id_, event.Pass()); + extensions::EventRouter::Get(browser()->profile()) + ->DispatchEventToExtension(test_extension_id_, event.Pass()); } // Loads the test extension and set's up its file_browser_handler to handle diff --git a/chrome/browser/extensions/extension_messages_apitest.cc b/chrome/browser/extensions/extension_messages_apitest.cc index 047e232..cc14174 100644 --- a/chrome/browser/extensions/extension_messages_apitest.cc +++ b/chrome/browser/extensions/extension_messages_apitest.cc @@ -72,8 +72,8 @@ class MessageSender : public content::NotificationObserver { virtual void Observe(int type, const content::NotificationSource& source, const content::NotificationDetails& details) OVERRIDE { - EventRouter* event_router = ExtensionSystem::Get( - content::Source<Profile>(source).ptr())->event_router(); + EventRouter* event_router = + EventRouter::Get(content::Source<Profile>(source).ptr()); // Sends four messages to the extension. All but the third message sent // from the origin http://b.com/ are supposed to arrive. diff --git a/chrome/browser/extensions/menu_manager.cc b/chrome/browser/extensions/menu_manager.cc index 6002ef3..a5d7923 100644 --- a/chrome/browser/extensions/menu_manager.cc +++ b/chrome/browser/extensions/menu_manager.cc @@ -607,8 +607,7 @@ void MenuManager::ExecuteCommand(Profile* profile, WebContents* web_contents, const content::ContextMenuParams& params, const MenuItem::Id& menu_item_id) { - EventRouter* event_router = extensions::ExtensionSystem::Get(profile)-> - event_router(); + EventRouter* event_router = EventRouter::Get(profile); if (!event_router) return; |