diff options
| author | kmadhusu@chromium.org <kmadhusu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-10-16 01:31:44 +0000 |
|---|---|---|
| committer | kmadhusu@chromium.org <kmadhusu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-10-16 01:31:44 +0000 |
| commit | dcb1c39139328aff4af71b547b69c29257f38e58 (patch) | |
| tree | b76c10e4ff2dcead761e5a0fb413eff4a535bb57 /chrome | |
| parent | ef1daf230a9e73fdd68daa421e3528d2134f4e43 (diff) | |
| download | chromium_src-dcb1c39139328aff4af71b547b69c29257f38e58.zip chromium_src-dcb1c39139328aff4af71b547b69c29257f38e58.tar.gz chromium_src-dcb1c39139328aff4af71b547b69c29257f38e58.tar.bz2 | |
[Coverity] Fix deference after null check error.
|extension_| may be NULL in ExtensionInstallPrompt::FetchOAuthIssueAdviceIfNeeded() function. ShowConfirmation() tries to dereference |extension_|. Therefore, modified code to call ShowConfirmation() only when |extension_| is not NULL.
CID=106034
BUG=none
TEST=none
TBR=kalman@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11013035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162028 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome')
| -rw-r--r-- | chrome/browser/extensions/extension_install_prompt.cc | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/chrome/browser/extensions/extension_install_prompt.cc b/chrome/browser/extensions/extension_install_prompt.cc index 42ea62e..d00b79c 100644 --- a/chrome/browser/extensions/extension_install_prompt.cc +++ b/chrome/browser/extensions/extension_install_prompt.cc @@ -562,8 +562,8 @@ void ExtensionInstallPrompt::ShowConfirmation() { prompt_.set_type(prompt_type_); if (permissions_) { - Extension::Type extension_type = prompt_type_ == BUNDLE_INSTALL_PROMPT ? - Extension::TYPE_UNKNOWN : extension_->GetType(); + Extension::Type extension_type = extension_ ? extension_->GetType() : + Extension::TYPE_UNKNOWN; prompt_.SetPermissions(permissions_->GetWarningMessages(extension_type)); } |