diff options
author | brettw@google.com <brettw@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-12-02 22:35:42 +0000 |
---|---|---|
committer | brettw@google.com <brettw@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-12-02 22:35:42 +0000 |
commit | 004a96a015b5dfcadaad4ea1b192c97c415b75de (patch) | |
tree | cb32d3809e4366c07e837416a106a3083d2690a5 /chrome | |
parent | f8ed412acb7bcab9855d0ebd9d29f7e38a3a8f92 (diff) | |
download | chromium_src-004a96a015b5dfcadaad4ea1b192c97c415b75de.zip chromium_src-004a96a015b5dfcadaad4ea1b192c97c415b75de.tar.gz chromium_src-004a96a015b5dfcadaad4ea1b192c97c415b75de.tar.bz2 |
Move convolver, image_operations, and skia_utils from base/gfx to skia/ext.
This changes the namespace in those files from "gfx" to "skia".
I split skia_utils into two parts, the Windows specific part is now in a separate file called skia_utils_win.
There were several obsolete includes of these headers which I removed. I also removed img_resize_perftest which isn't used and has bitrotted.
Review URL: http://codereview.chromium.org/12842
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6248 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome')
22 files changed, 57 insertions, 69 deletions
diff --git a/chrome/browser/autocomplete/autocomplete_edit.cc b/chrome/browser/autocomplete/autocomplete_edit.cc index cfef6a6..4cd2d76 100644 --- a/chrome/browser/autocomplete/autocomplete_edit.cc +++ b/chrome/browser/autocomplete/autocomplete_edit.cc @@ -8,7 +8,6 @@ #include "base/base_drag_source.h" #include "base/clipboard.h" -#include "base/gfx/skia_utils.h" #include "base/iat_patch.h" #include "base/ref_counted.h" #include "base/scoped_clipboard_writer.h" diff --git a/chrome/browser/download/download_util.cc b/chrome/browser/download/download_util.cc index 262c507..5af7c47 100644 --- a/chrome/browser/download/download_util.cc +++ b/chrome/browser/download/download_util.cc @@ -11,7 +11,6 @@ #include "base/base_drag_source.h" #include "base/file_util.h" #include "base/scoped_clipboard_writer.h" -#include "base/gfx/image_operations.h" #include "base/string_util.h" #include "chrome/app/locales/locale_settings.h" #include "chrome/app/theme/theme_resources.h" @@ -25,6 +24,7 @@ #include "chrome/common/resource_bundle.h" #include "chrome/views/view.h" #include "generated_resources.h" +#include "skia/ext/image_operations.h" #include "SkPath.h" #include "SkShader.h" diff --git a/chrome/browser/fav_icon_helper.cc b/chrome/browser/fav_icon_helper.cc index f77b05c..2f05357 100644 --- a/chrome/browser/fav_icon_helper.cc +++ b/chrome/browser/fav_icon_helper.cc @@ -4,7 +4,6 @@ #include "chrome/browser/fav_icon_helper.h" -#include "base/gfx/image_operations.h" #include "base/gfx/png_decoder.h" #include "base/gfx/png_encoder.h" #include "chrome/browser/navigation_entry.h" @@ -13,6 +12,7 @@ #include "chrome/browser/render_view_host.h" #include "chrome/browser/web_contents.h" #include "chrome/common/gfx/favicon_size.h" +#include "skia/ext/image_operations.h" FavIconHelper::FavIconHelper(WebContents* web_contents) : web_contents_(web_contents), @@ -257,8 +257,8 @@ SkBitmap FavIconHelper::ConvertToFavIconSize(const SkBitmap& image) { int height = image.height(); if (width > 0 && height > 0) { calc_favicon_target_size(&width, &height); - return gfx::ImageOperations::Resize( - image, gfx::ImageOperations::RESIZE_LANCZOS3, + return skia::ImageOperations::Resize( + image, skia::ImageOperations::RESIZE_LANCZOS3, gfx::Size(width, height)); } return image; diff --git a/chrome/browser/importer/importer.cc b/chrome/browser/importer/importer.cc index 3ce8996..a329cfb 100644 --- a/chrome/browser/importer/importer.cc +++ b/chrome/browser/importer/importer.cc @@ -8,7 +8,6 @@ #include <set> #include "base/file_util.h" -#include "base/gfx/image_operations.h" #include "base/gfx/png_encoder.h" #include "base/string_util.h" #include "chrome/browser/bookmarks/bookmark_model.h" @@ -31,6 +30,7 @@ #include "chrome/common/pref_service.h" #include "chrome/common/win_util.h" #include "chrome/views/window.h" +#include "skia/ext/image_operations.h" #include "webkit/glue/image_decoder.h" #include "generated_resources.h" @@ -384,8 +384,8 @@ bool Importer::ReencodeFavicon(const unsigned char* src_data, size_t src_len, int new_width = decoded.width(); int new_height = decoded.height(); calc_favicon_target_size(&new_width, &new_height); - decoded = gfx::ImageOperations::Resize( - decoded, gfx::ImageOperations::RESIZE_LANCZOS3, + decoded = skia::ImageOperations::Resize( + decoded, skia::ImageOperations::RESIZE_LANCZOS3, gfx::Size(new_width, new_height)); } diff --git a/chrome/browser/views/bookmark_bar_view.cc b/chrome/browser/views/bookmark_bar_view.cc index aaca5af..49d817b 100644 --- a/chrome/browser/views/bookmark_bar_view.cc +++ b/chrome/browser/views/bookmark_bar_view.cc @@ -7,7 +7,6 @@ #include <limits> #include "base/base_drag_source.h" -#include "base/gfx/skia_utils.h" #include "chrome/app/theme/theme_resources.h" #include "chrome/browser/bookmarks/bookmark_context_menu.h" #include "chrome/browser/bookmarks/bookmark_utils.h" @@ -45,6 +44,7 @@ #include "chrome/views/widget.h" #include "chrome/views/window.h" #include "generated_resources.h" +#include "skia/ext/skia_utils.h" using views::BaseButton; using views::DropTargetEvent; @@ -255,7 +255,7 @@ class BookmarkButton : public views::TextButton { // the parent's actual bounds because they differ from what is painted. SkPaint paint; paint.setAlpha(static_cast<int>((1.0 - animation_value) * 255)); - paint.setShader(gfx::CreateGradientShader(0, + paint.setShader(skia::CreateGradientShader(0, view->height() + kTopMargin + kBottomMargin, kTopBorderColor, kBackgroundColor))->safeUnref(); @@ -603,16 +603,16 @@ class ButtonSeparatorView : public views::View { virtual void Paint(ChromeCanvas* canvas) { SkPaint paint; - paint.setShader(gfx::CreateGradientShader(0, - height() / 2, - kTopBorderColor, - kSeparatorColor))->safeUnref(); + paint.setShader(skia::CreateGradientShader(0, + height() / 2, + kTopBorderColor, + kSeparatorColor))->safeUnref(); SkRect rc = {SkIntToScalar(kSeparatorStartX), SkIntToScalar(0), SkIntToScalar(1), SkIntToScalar(height() / 2) }; canvas->drawRect(rc, paint); SkPaint paint_down; - paint_down.setShader(gfx::CreateGradientShader(height() / 2, + paint_down.setShader(skia::CreateGradientShader(height() / 2, height(), kSeparatorColor, kBackgroundColor))->safeUnref(); @@ -904,10 +904,10 @@ void BookmarkBarView::Paint(ChromeCanvas* canvas) { // Draw our background. SkPaint paint; paint.setAntiAlias(true); - paint.setShader(gfx::CreateGradientShader(0, - height(), - kTopBorderColor, - kBackgroundColor))->safeUnref(); + paint.setShader(skia::CreateGradientShader(0, + height(), + kTopBorderColor, + kBackgroundColor))->safeUnref(); canvas->drawRoundRect(rect, SkDoubleToScalar(roundness), @@ -924,10 +924,10 @@ void BookmarkBarView::Paint(ChromeCanvas* canvas) { SkDoubleToScalar(roundness), border_paint); } else { SkPaint paint; - paint.setShader(gfx::CreateGradientShader(0, - height(), - kTopBorderColor, - kBackgroundColor))->safeUnref(); + paint.setShader(skia::CreateGradientShader(0, + height(), + kTopBorderColor, + kBackgroundColor))->safeUnref(); canvas->FillRectInt(0, 0, width(), height(), paint); canvas->FillRectInt(kTopBorderColor, 0, 0, width(), 1); diff --git a/chrome/browser/views/bookmark_manager_view.cc b/chrome/browser/views/bookmark_manager_view.cc index c0c307e..684c252 100644 --- a/chrome/browser/views/bookmark_manager_view.cc +++ b/chrome/browser/views/bookmark_manager_view.cc @@ -6,7 +6,6 @@ #include <algorithm> -#include "base/gfx/skia_utils.h" #include "chrome/app/locales/locale_settings.h" #include "chrome/browser/bookmarks/bookmark_folder_tree_model.h" #include "chrome/browser/bookmarks/bookmark_html_writer.h" @@ -31,8 +30,8 @@ #include "chrome/views/menu_button.h" #include "chrome/views/single_split_view.h" #include "chrome/views/window.h" - #include "generated_resources.h" +#include "skia/ext/skia_utils.h" // If non-null, there is an open editor and this is the window it is contained // in it. @@ -299,7 +298,7 @@ void BookmarkManagerView::PaintBackground(ChromeCanvas* canvas) { canvas->drawColor(kBackgroundColorBottom, SkPorterDuff::kSrc_Mode); SkPaint paint; - paint.setShader(gfx::CreateGradientShader(0, kBackgroundGradientHeight, + paint.setShader(skia::CreateGradientShader(0, kBackgroundGradientHeight, kBackgroundColorTop, kBackgroundColorBottom))->safeUnref(); canvas->FillRectInt(0, 0, width(), kBackgroundGradientHeight, paint); diff --git a/chrome/browser/views/options/content_page_view.cc b/chrome/browser/views/options/content_page_view.cc index e4e443d..a534a4b 100644 --- a/chrome/browser/views/options/content_page_view.cc +++ b/chrome/browser/views/options/content_page_view.cc @@ -11,7 +11,6 @@ #include "base/file_util.h" #include "base/gfx/native_theme.h" -#include "base/gfx/skia_utils.h" #include "chrome/app/theme/theme_resources.h" #include "chrome/browser/browser_process.h" #include "chrome/browser/shell_dialogs.h" @@ -31,6 +30,7 @@ #include "chrome/views/text_field.h" #include "chrome/views/widget.h" #include "generated_resources.h" +#include "skia/ext/skia_utils_win.h" #include "skia/include/SkBitmap.h" namespace { @@ -102,7 +102,7 @@ void FileDisplayArea::Paint(ChromeCanvas* canvas) { RECT rect = { 0, 0, width(), height() }; gfx::NativeTheme::instance()->PaintTextField( dc, EP_EDITTEXT, ETS_READONLY, 0, &rect, - gfx::SkColorToCOLORREF(text_field_background_color_), true, true); + skia::SkColorToCOLORREF(text_field_background_color_), true, true); canvas->endPlatformPaint(); canvas->DrawBitmapInt(default_folder_icon_, icon_bounds_.x(), icon_bounds_.y()); diff --git a/chrome/browser/views/options/fonts_page_view.cc b/chrome/browser/views/options/fonts_page_view.cc index b41fb55..d73191b 100644 --- a/chrome/browser/views/options/fonts_page_view.cc +++ b/chrome/browser/views/options/fonts_page_view.cc @@ -10,7 +10,6 @@ #include "base/file_util.h" #include "base/gfx/native_theme.h" -#include "base/gfx/skia_utils.h" #include "base/string_util.h" #include "chrome/app/theme/theme_resources.h" #include "chrome/app/locales/locale_settings.h" diff --git a/chrome/browser/views/options/languages_page_view.cc b/chrome/browser/views/options/languages_page_view.cc index 118ac10..e9a1e8b 100644 --- a/chrome/browser/views/options/languages_page_view.cc +++ b/chrome/browser/views/options/languages_page_view.cc @@ -11,7 +11,6 @@ #include "base/file_util.h" #include "base/string_util.h" #include "base/gfx/native_theme.h" -#include "base/gfx/skia_utils.h" #include "base/string_util.h" #include "chrome/app/theme/theme_resources.h" #include "chrome/browser/browser_process.h" diff --git a/chrome/browser/views/options/options_group_view.cc b/chrome/browser/views/options/options_group_view.cc index bdf76ea..9ff07f5 100644 --- a/chrome/browser/views/options/options_group_view.cc +++ b/chrome/browser/views/options/options_group_view.cc @@ -8,7 +8,6 @@ #include "chrome/browser/views/options/options_group_view.h" #include "base/gfx/native_theme.h" -#include "base/gfx/skia_utils.h" #include "chrome/app/locales/locale_settings.h" #include "chrome/browser/views/standard_layout.h" #include "chrome/common/gfx/chrome_font.h" diff --git a/chrome/browser/views/sad_tab_view.cc b/chrome/browser/views/sad_tab_view.cc index 7b34bcb..e22aea2 100644 --- a/chrome/browser/views/sad_tab_view.cc +++ b/chrome/browser/views/sad_tab_view.cc @@ -10,6 +10,7 @@ #include "chrome/common/l10n_util.h" #include "chrome/common/resource_bundle.h" #include "generated_resources.h" +#include "skia/ext/skia_utils.h" #include "skia/include/SkGradientShader.h" static const int kSadTabOffset = -64; @@ -34,17 +35,9 @@ SadTabView::SadTabView() { InitClass(); } -static SkShader* CreateGradientShader(int end_point) { - SkColor grad_colors[2] = { kBackgroundColor, kBackgroundEndColor }; - SkPoint grad_points[2]; - grad_points[0].set(SkIntToScalar(0), SkIntToScalar(0)); - grad_points[1].set(SkIntToScalar(0), SkIntToScalar(end_point)); - return SkGradientShader::CreateLinear( - grad_points, grad_colors, NULL, 2, SkShader::kRepeat_TileMode); -} - void SadTabView::Paint(ChromeCanvas* canvas) { - SkShader* background_shader = CreateGradientShader(height()); + SkShader* background_shader = skia::CreateGradientShader( + 0, height(), kBackgroundColor, kBackgroundEndColor); SkPaint paint; paint.setShader(background_shader); background_shader->unref(); diff --git a/chrome/browser/views/tabs/tab_renderer.cc b/chrome/browser/views/tabs/tab_renderer.cc index f1d00b3..4581f6d 100644 --- a/chrome/browser/views/tabs/tab_renderer.cc +++ b/chrome/browser/views/tabs/tab_renderer.cc @@ -6,7 +6,6 @@ #include "chrome/browser/views/tabs/tab_renderer.h" -#include "base/gfx/image_operations.h" #include "chrome/app/theme/theme_resources.h" #include "chrome/browser/browser.h" #include "chrome/browser/tabs/tab_strip_model.h" @@ -17,6 +16,7 @@ #include "chrome/common/resource_bundle.h" #include "chrome/common/win_util.h" #include "generated_resources.h" +#include "skia/ext/image_operations.h" static const int kLeftPadding = 16; static const int kTopPadding = 6; @@ -586,13 +586,13 @@ void TabRenderer::PaintActiveTabBackground(ChromeCanvas* canvas) { void TabRenderer::PaintHoverTabBackground(ChromeCanvas* canvas, double opacity) { bool is_otr = data_.off_the_record; - SkBitmap left = gfx::ImageOperations::CreateBlendedBitmap( + SkBitmap left = skia::ImageOperations::CreateBlendedBitmap( (is_otr ? *tab_inactive_otr_l : *tab_inactive_l), *tab_hover_l, opacity); - SkBitmap center = gfx::ImageOperations::CreateBlendedBitmap( + SkBitmap center = skia::ImageOperations::CreateBlendedBitmap( (is_otr ? *tab_inactive_otr_c : *tab_inactive_c), *tab_hover_c, opacity); - SkBitmap right = gfx::ImageOperations::CreateBlendedBitmap( + SkBitmap right = skia::ImageOperations::CreateBlendedBitmap( (is_otr ? *tab_inactive_otr_r : *tab_inactive_r), *tab_hover_r, opacity); diff --git a/chrome/common/gfx/color_utils.cc b/chrome/common/gfx/color_utils.cc index 0b40436..cdb4c0c 100644 --- a/chrome/common/gfx/color_utils.cc +++ b/chrome/common/gfx/color_utils.cc @@ -12,10 +12,13 @@ #include "chrome/common/gfx/color_utils.h" #include "base/basictypes.h" -#include "base/gfx/skia_utils.h" #include "base/logging.h" #include "skia/include/SkBitmap.h" +#if defined(OS_WIN) +#include "skia/ext/skia_utils_win.h" +#endif + namespace color_utils { // These transformations are based on the equations in: @@ -252,7 +255,7 @@ SkColor SetColorAlpha(SkColor c, SkAlpha alpha) { SkColor GetSysSkColor(int which) { #if defined(OS_WIN) - return gfx::COLORREFToSkColor(::GetSysColor(which)); + return skia::COLORREFToSkColor(::GetSysColor(which)); #else NOTIMPLEMENTED(); return SK_ColorLTGRAY; diff --git a/chrome/common/gfx/icon_util.cc b/chrome/common/gfx/icon_util.cc index e717c79..ae5e174 100644 --- a/chrome/common/gfx/icon_util.cc +++ b/chrome/common/gfx/icon_util.cc @@ -3,11 +3,12 @@ // found in the LICENSE file. #include "chrome/common/gfx/icon_util.h" + #include "base/file_util.h" -#include "base/gfx/image_operations.h" #include "base/gfx/size.h" #include "base/logging.h" #include "chrome/common/win_util.h" +#include "skia/ext/image_operations.h" #include "skia/include/SkBitmap.h" // Defining the dimensions for the icon images. We store only one value because @@ -403,8 +404,8 @@ void IconUtil::CreateResizedBitmapSet(const SkBitmap& bitmap_to_resize, inserted_original_bitmap = true; } } - bitmaps->push_back(gfx::ImageOperations::Resize( - bitmap_to_resize, gfx::ImageOperations::RESIZE_LANCZOS3, + bitmaps->push_back(skia::ImageOperations::Resize( + bitmap_to_resize, skia::ImageOperations::RESIZE_LANCZOS3, gfx::Size(icon_dimensions_[i], icon_dimensions_[i]))); } diff --git a/chrome/renderer/render_view.cc b/chrome/renderer/render_view.cc index 23fab18..e28a6c7 100644 --- a/chrome/renderer/render_view.cc +++ b/chrome/renderer/render_view.cc @@ -10,7 +10,6 @@ #include "base/command_line.h" #include "base/gfx/gdi_util.h" -#include "base/gfx/image_operations.h" #include "base/gfx/native_theme.h" #include "base/gfx/png_encoder.h" #include "base/string_piece.h" @@ -38,6 +37,7 @@ #include "net/base/escape.h" #include "net/base/net_errors.h" #include "skia/ext/bitmap_platform_device.h" +#include "skia/ext/image_operations.h" #include "skia/ext/vector_canvas.h" #include "webkit/default_plugin/default_plugin_shared.h" #include "webkit/glue/dom_operations.h" @@ -57,7 +57,6 @@ #include "webkit/glue/weburlrequest.h" #include "webkit/glue/webview.h" #include "webkit/glue/plugins/webplugin_delegate_impl.h" -//#include "webkit/port/platform/graphics/PlatformContextSkia.h" #include "generated_resources.h" @@ -798,8 +797,8 @@ bool RenderView::CaptureThumbnail(WebFrame* frame, device->accessBitmap(false).extractSubset(&subset, src_rect); // Resample the subset that we want to get it the right size. - *thumbnail = gfx::ImageOperations::Resize( - subset, gfx::ImageOperations::RESIZE_LANCZOS3, gfx::Size(w, h)); + *thumbnail = skia::ImageOperations::Resize( + subset, skia::ImageOperations::RESIZE_LANCZOS3, gfx::Size(w, h)); score->boring_score = CalculateBoringScore(thumbnail); diff --git a/chrome/views/background.cc b/chrome/views/background.cc index 72352b7..1aa631e 100644 --- a/chrome/views/background.cc +++ b/chrome/views/background.cc @@ -4,11 +4,11 @@ #include "chrome/views/background.h" -#include "base/gfx/skia_utils.h" #include "base/logging.h" #include "chrome/common/gfx/chrome_canvas.h" #include "chrome/views/painter.h" #include "chrome/views/view.h" +#include "skia/ext/skia_utils_win.h" #include "skia/include/SkPaint.h" namespace views { @@ -68,7 +68,7 @@ Background::~Background() { void Background::SetNativeControlColor(SkColor color) { DeleteObject(native_control_brush_); - native_control_brush_ = CreateSolidBrush(gfx::SkColorToCOLORREF(color)); + native_control_brush_ = CreateSolidBrush(skia::SkColorToCOLORREF(color)); } //static diff --git a/chrome/views/button.cc b/chrome/views/button.cc index 93e2e3c..36c228a 100644 --- a/chrome/views/button.cc +++ b/chrome/views/button.cc @@ -7,12 +7,12 @@ #include <atlbase.h> #include <atlapp.h> -#include "base/gfx/image_operations.h" #include "chrome/app/chrome_dll_resource.h" #include "chrome/common/gfx/chrome_canvas.h" #include "chrome/common/l10n_util.h" #include "chrome/common/throb_animation.h" #include "chrome/views/event.h" +#include "skia/ext/image_operations.h" #include "generated_resources.h" @@ -105,7 +105,7 @@ SkBitmap Button::GetImageToPaint() { SkBitmap img; if (!images_[BS_HOT].isNull() && hover_animation_->IsAnimating()) { - img = gfx::ImageOperations::CreateBlendedBitmap(images_[BS_NORMAL], + img = skia::ImageOperations::CreateBlendedBitmap(images_[BS_NORMAL], images_[BS_HOT], hover_animation_->GetCurrentValue()); } else { img = images_[GetState()]; diff --git a/chrome/views/chrome_menu.cc b/chrome/views/chrome_menu.cc index 549bedf..4d12f3b 100644 --- a/chrome/views/chrome_menu.cc +++ b/chrome/views/chrome_menu.cc @@ -10,7 +10,6 @@ #include "base/base_drag_source.h" #include "base/gfx/native_theme.h" -#include "base/gfx/skia_utils.h" #include "base/message_loop.h" #include "base/task.h" #include "base/timer.h" diff --git a/chrome/views/single_split_view.cc b/chrome/views/single_split_view.cc index 2550c57..a7832b6 100644 --- a/chrome/views/single_split_view.cc +++ b/chrome/views/single_split_view.cc @@ -4,9 +4,9 @@ #include "chrome/views/single_split_view.h" -#include "base/gfx/skia_utils.h" #include "chrome/common/gfx/chrome_canvas.h" #include "chrome/views/background.h" +#include "skia/ext/skia_utils_win.h" namespace views { @@ -19,7 +19,7 @@ SingleSplitView::SingleSplitView(View* leading, View* trailing) AddChildView(trailing); set_background( views::Background::CreateSolidBackground( - gfx::COLORREFToSkColor(GetSysColor(COLOR_3DFACE)))); + skia::COLORREFToSkColor(GetSysColor(COLOR_3DFACE)))); } void SingleSplitView::Layout() { diff --git a/chrome/views/tabbed_pane.cc b/chrome/views/tabbed_pane.cc index 2638972..4a63b47 100644 --- a/chrome/views/tabbed_pane.cc +++ b/chrome/views/tabbed_pane.cc @@ -7,7 +7,6 @@ #include <vssym32.h> #include "base/gfx/native_theme.h" -#include "base/gfx/skia_utils.h" #include "base/logging.h" #include "chrome/common/gfx/chrome_canvas.h" #include "chrome/common/gfx/chrome_font.h" diff --git a/chrome/views/table_view.cc b/chrome/views/table_view.cc index 208a38b..52ed457 100644 --- a/chrome/views/table_view.cc +++ b/chrome/views/table_view.cc @@ -9,7 +9,6 @@ #include "base/string_util.h" #include "base/win_util.h" -#include "base/gfx/skia_utils.h" #include "chrome/common/gfx/chrome_canvas.h" #include "chrome/common/gfx/favicon_size.h" #include "chrome/common/gfx/icon_util.h" @@ -18,6 +17,7 @@ #include "chrome/views/hwnd_view.h" #include "SkBitmap.h" #include "SkColorFilter.h" +#include "skia/ext/skia_utils_win.h" namespace views { @@ -1175,10 +1175,10 @@ LRESULT TableView::OnCustomDraw(NMLVCUSTOMDRAW* draw_info) { custom_cell_font_ = CreateFontIndirect(&logfont); SelectObject(draw_info->nmcd.hdc, custom_cell_font_); draw_info->clrText = foreground.color_is_set - ? gfx::SkColorToCOLORREF(foreground.color) + ? skia::SkColorToCOLORREF(foreground.color) : CLR_DEFAULT; draw_info->clrTextBk = background.color_is_set - ? gfx::SkColorToCOLORREF(background.color) + ? skia::SkColorToCOLORREF(background.color) : CLR_DEFAULT; return CDRF_NEWFONT; } @@ -1228,7 +1228,7 @@ LRESULT TableView::OnCustomDraw(NMLVCUSTOMDRAW* draw_info) { // background (or rather windows paints background, then invokes // this twice). As such, we always fill in the background. canvas.drawColor( - gfx::COLORREFToSkColor(GetSysColor(bg_color_index)), + skia::COLORREFToSkColor(GetSysColor(bg_color_index)), SkPorterDuff::kSrc_Mode); // + 1 for padding (we declared the image as 18x18 in the list- // view when they are 16x16 so we get an extra pixel of padding). diff --git a/chrome/views/text_field.cc b/chrome/views/text_field.cc index 24fdc5a..92797a4 100644 --- a/chrome/views/text_field.cc +++ b/chrome/views/text_field.cc @@ -12,7 +12,6 @@ #include <vsstyle.h> #include "base/gfx/native_theme.h" -#include "base/gfx/skia_utils.h" #include "base/scoped_clipboard_writer.h" #include "base/string_util.h" #include "base/win_util.h" @@ -25,8 +24,8 @@ #include "chrome/views/hwnd_view.h" #include "chrome/views/menu.h" #include "chrome/views/widget.h" - #include "generated_resources.h" +#include "skia/ext/skia_utils_win.h" using gfx::NativeTheme; @@ -1087,7 +1086,7 @@ void TextField::UpdateEditBackgroundColor() { COLORREF bg_color; if (!use_default_background_color_) - bg_color = gfx::SkColorToCOLORREF(background_color_); + bg_color = skia::SkColorToCOLORREF(background_color_); else bg_color = GetSysColor(read_only_ ? COLOR_3DFACE : COLOR_WINDOW); edit_->SetBackgroundColor(bg_color); |