diff options
author | jeremy@chromium.org <jeremy@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-01-17 08:19:53 +0000 |
---|---|---|
committer | jeremy@chromium.org <jeremy@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-01-17 08:19:53 +0000 |
commit | 352de89080246d48bcf30a939b7e3418513b1572 (patch) | |
tree | 62e4853e147886312470475b9b7f833edd017b17 /chrome | |
parent | 2edb5be9a3a08a9527cd04ad302ba2376a22c4d6 (diff) | |
download | chromium_src-352de89080246d48bcf30a939b7e3418513b1572.zip chromium_src-352de89080246d48bcf30a939b7e3418513b1572.tar.gz chromium_src-352de89080246d48bcf30a939b7e3418513b1572.tar.bz2 |
Small cleanup to Mac Sandbox code.
Add NOTREACHED() to branch of Sandbox code that we should never hit.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/536060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36467 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome')
-rw-r--r-- | chrome/common/sandbox_init_wrapper_mac.cc | 10 |
1 files changed, 8 insertions, 2 deletions
diff --git a/chrome/common/sandbox_init_wrapper_mac.cc b/chrome/common/sandbox_init_wrapper_mac.cc index b57727b..3341b08 100644 --- a/chrome/common/sandbox_init_wrapper_mac.cc +++ b/chrome/common/sandbox_init_wrapper_mac.cc @@ -23,8 +23,14 @@ bool SandboxInitWrapper::InitializeSandbox(const CommandLine& command_line, // Renderer process sandbox. sandbox_process_type = sandbox::SANDBOX_TYPE_RENDERER; } else if (process_type == switches::kExtensionProcess) { - // Extension process sandbox. - sandbox_process_type = sandbox::SANDBOX_TYPE_RENDERER; + // Extension processes are just renderers [they use RenderMain()] with a + // different set of command line flags. + // If we ever get here it means something has changed in regards + // to the extension process mechanics and we should probably reexamine + // how we sandbox extension processes since they are no longer identical + // to renderers. + NOTREACHED(); + return true; } else if (process_type == switches::kUtilityProcess) { // Utility process sandbox. sandbox_process_type = sandbox::SANDBOX_TYPE_UTILITY; |