diff options
| author | levin@chromium.org <levin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-06-14 00:04:35 +0000 |
|---|---|---|
| committer | levin@chromium.org <levin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-06-14 00:04:35 +0000 |
| commit | 5e19311473285a6fbeb41d270c27fdc8347af9dd (patch) | |
| tree | 07ec25cfd19cbaad94dce9d8b3e54c1af44880b0 /chrome | |
| parent | 5cec5aac575e225a592f03f177307ad2c707972f (diff) | |
| download | chromium_src-5e19311473285a6fbeb41d270c27fdc8347af9dd.zip chromium_src-5e19311473285a6fbeb41d270c27fdc8347af9dd.tar.gz chromium_src-5e19311473285a6fbeb41d270c27fdc8347af9dd.tar.bz2 | |
Remove FLAKY designation as this test seems to always be passing now.
The passing rate is seen here: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=ui_tests&tests=SearchProviderTest.FLAKY_TestIsSearchProviderInstalled
Platforms which are not passing are not running the test. (It was failing due to
http://code.google.com/p/chromium/issues/detail?id=78233.)
Either it was due to some network flakiness or my recent change to close
the tab after the test is done ensured that any previous network connections
are cleaned up (which is a known issue with our test http server -- that it
only services one connection at a time).
BUG=62777
TEST=SearchProviderTest.TestIsSearchProviderInstalled
Review URL: http://codereview.chromium.org/7146003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88926 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome')
| -rw-r--r-- | chrome/renderer/external_extension_uitest.cc | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/chrome/renderer/external_extension_uitest.cc b/chrome/renderer/external_extension_uitest.cc index a5d8475..736a85f 100644 --- a/chrome/renderer/external_extension_uitest.cc +++ b/chrome/renderer/external_extension_uitest.cc @@ -128,8 +128,7 @@ void SearchProviderTest::FinishIsSearchProviderInstalledTest( EXPECT_TRUE(data.tab->Close(true)); } -// http://code.google.com/p/chromium/issues/detail?id=62777 -TEST_F(SearchProviderTest, FLAKY_TestIsSearchProviderInstalled) { +TEST_F(SearchProviderTest, TestIsSearchProviderInstalled) { ASSERT_TRUE(test_server_started_); // Use the default search provider, other installed search provider, and |