diff options
| author | jcampan@chromium.org <jcampan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-04-09 01:03:11 +0000 |
|---|---|---|
| committer | jcampan@chromium.org <jcampan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-04-09 01:03:11 +0000 |
| commit | e0fcc5605cc7e64fc2b4f9e3c9db150a280e3007 (patch) | |
| tree | a8b57e720b3df5b5fa12aaf6b6b02cddcef43de1 /chrome | |
| parent | b12d1d8a6ff6ea430ccf8c39f6907c2f9cdde97f (diff) | |
| download | chromium_src-e0fcc5605cc7e64fc2b4f9e3c9db150a280e3007.zip chromium_src-e0fcc5605cc7e64fc2b4f9e3c9db150a280e3007.tar.gz chromium_src-e0fcc5605cc7e64fc2b4f9e3c9db150a280e3007.tar.bz2 | |
When a DOMUI dialog contains HTML with a select or a text-field which would have auto-fill, bringing the popup crashes the browser. This is because the WebContentView may not have a delegate.
BUG=None
TEST=Requires code change, adding a select or a text-field to the Gears dialog for example.
Review URL: http://codereview.chromium.org/63146
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13398 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome')
| -rw-r--r-- | chrome/browser/tab_contents/web_contents_view.cc | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/chrome/browser/tab_contents/web_contents_view.cc b/chrome/browser/tab_contents/web_contents_view.cc index 689ce7e..feb8266 100644 --- a/chrome/browser/tab_contents/web_contents_view.cc +++ b/chrome/browser/tab_contents/web_contents_view.cc @@ -112,6 +112,7 @@ void WebContentsView::ShowCreatedWidgetInternal( widget_host_view->InitAsPopup( web_contents_->render_widget_host_view(), initial_pos); - web_contents_->delegate()->RenderWidgetShowing(); + if (web_contents_->delegate()) + web_contents_->delegate()->RenderWidgetShowing(); widget_host->Init(); } |