diff options
author | jam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-05-16 21:29:33 +0000 |
---|---|---|
committer | jam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-05-16 21:29:33 +0000 |
commit | e44d13473dd9d81a8d3e1d26f2024be4e4a7c503 (patch) | |
tree | 4a66307f49ed83f6de7faba305cd6355a649b355 /chrome | |
parent | 51f81dae305d1bdfda139b18be3632f8fbf4959f (diff) | |
download | chromium_src-e44d13473dd9d81a8d3e1d26f2024be4e4a7c503.zip chromium_src-e44d13473dd9d81a8d3e1d26f2024be4e4a7c503.tar.gz chromium_src-e44d13473dd9d81a8d3e1d26f2024be4e4a7c503.tar.bz2 |
Remove IPC_BEGIN_MESSAGE_MAP_EX macro since r270839 made all bad IPCs kill their child processes.
R=avi@chromium.org
Review URL: https://codereview.chromium.org/292443004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271096 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome')
29 files changed, 46 insertions, 77 deletions
diff --git a/chrome/browser/chrome_net_benchmarking_message_filter.cc b/chrome/browser/chrome_net_benchmarking_message_filter.cc index 35c771c..1b01f1d 100644 --- a/chrome/browser/chrome_net_benchmarking_message_filter.cc +++ b/chrome/browser/chrome_net_benchmarking_message_filter.cc @@ -43,10 +43,9 @@ ChromeNetBenchmarkingMessageFilter::~ChromeNetBenchmarkingMessageFilter() { } bool ChromeNetBenchmarkingMessageFilter::OnMessageReceived( - const IPC::Message& message, bool* message_was_ok) { + const IPC::Message& message) { bool handled = true; - IPC_BEGIN_MESSAGE_MAP_EX(ChromeNetBenchmarkingMessageFilter, message, - *message_was_ok) + IPC_BEGIN_MESSAGE_MAP(ChromeNetBenchmarkingMessageFilter, message) IPC_MESSAGE_HANDLER(ChromeViewHostMsg_CloseCurrentConnections, OnCloseCurrentConnections) IPC_MESSAGE_HANDLER_DELAY_REPLY(ChromeViewHostMsg_ClearCache, OnClearCache) @@ -55,7 +54,7 @@ bool ChromeNetBenchmarkingMessageFilter::OnMessageReceived( IPC_MESSAGE_HANDLER(ChromeViewHostMsg_ClearPredictorCache, OnClearPredictorCache) IPC_MESSAGE_UNHANDLED(handled = false) - IPC_END_MESSAGE_MAP_EX() + IPC_END_MESSAGE_MAP() return handled; } diff --git a/chrome/browser/chrome_net_benchmarking_message_filter.h b/chrome/browser/chrome_net_benchmarking_message_filter.h index bb78496..7600dc5 100644 --- a/chrome/browser/chrome_net_benchmarking_message_filter.h +++ b/chrome/browser/chrome_net_benchmarking_message_filter.h @@ -23,8 +23,7 @@ class ChromeNetBenchmarkingMessageFilter net::URLRequestContextGetter* request_context); // content::BrowserMessageFilter methods: - virtual bool OnMessageReceived(const IPC::Message& message, - bool* message_was_ok) OVERRIDE; + virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE; private: virtual ~ChromeNetBenchmarkingMessageFilter(); diff --git a/chrome/browser/media/cast_transport_host_filter.cc b/chrome/browser/media/cast_transport_host_filter.cc index 2a06a5a..3db29fc 100644 --- a/chrome/browser/media/cast_transport_host_filter.cc +++ b/chrome/browser/media/cast_transport_host_filter.cc @@ -22,10 +22,9 @@ CastTransportHostFilter::CastTransportHostFilter() CastTransportHostFilter::~CastTransportHostFilter() {} -bool CastTransportHostFilter::OnMessageReceived(const IPC::Message& message, - bool* message_was_ok) { +bool CastTransportHostFilter::OnMessageReceived(const IPC::Message& message) { bool handled = true; - IPC_BEGIN_MESSAGE_MAP_EX(CastTransportHostFilter, message, *message_was_ok) + IPC_BEGIN_MESSAGE_MAP(CastTransportHostFilter, message) IPC_MESSAGE_HANDLER(CastHostMsg_New, OnNew) IPC_MESSAGE_HANDLER(CastHostMsg_Delete, OnDelete) IPC_MESSAGE_HANDLER(CastHostMsg_InitializeAudio, OnInitializeAudio) @@ -39,7 +38,7 @@ bool CastTransportHostFilter::OnMessageReceived(const IPC::Message& message, IPC_MESSAGE_HANDLER(CastHostMsg_ResendPackets, OnResendPackets) IPC_MESSAGE_UNHANDLED(handled = false); - IPC_END_MESSAGE_MAP_EX(); + IPC_END_MESSAGE_MAP(); return handled; } diff --git a/chrome/browser/media/cast_transport_host_filter.h b/chrome/browser/media/cast_transport_host_filter.h index 46830db..5ee545e 100644 --- a/chrome/browser/media/cast_transport_host_filter.h +++ b/chrome/browser/media/cast_transport_host_filter.h @@ -31,8 +31,7 @@ class CastTransportHostFilter : public content::BrowserMessageFilter { const std::vector<media::cast::PacketEvent>& packet_events); // BrowserMessageFilter implementation. - virtual bool OnMessageReceived(const IPC::Message& message, - bool* message_was_ok) OVERRIDE; + virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE; // Forwarding functions. void OnInitializeAudio( diff --git a/chrome/browser/media/cast_transport_host_filter_unittest.cc b/chrome/browser/media/cast_transport_host_filter_unittest.cc index e85b223..1ffdc4d 100644 --- a/chrome/browser/media/cast_transport_host_filter_unittest.cc +++ b/chrome/browser/media/cast_transport_host_filter_unittest.cc @@ -30,9 +30,7 @@ class CastTransportHostFilterTest : public testing::Test { protected: void FakeSend(const IPC::Message& message) { - bool message_was_ok; - EXPECT_TRUE(filter_->OnMessageReceived(message, &message_was_ok)); - EXPECT_TRUE(message_was_ok); + EXPECT_TRUE(filter_->OnMessageReceived(message)); } content::TestBrowserThreadBundle browser_thread_bundle_; diff --git a/chrome/browser/media/webrtc_logging_handler_host.cc b/chrome/browser/media/webrtc_logging_handler_host.cc index 816be38..cd0bdeda7 100644 --- a/chrome/browser/media/webrtc_logging_handler_host.cc +++ b/chrome/browser/media/webrtc_logging_handler_host.cc @@ -262,16 +262,15 @@ void WebRtcLoggingHandlerHost::OnDestruct() const { BrowserThread::DeleteOnIOThread::Destruct(this); } -bool WebRtcLoggingHandlerHost::OnMessageReceived(const IPC::Message& message, - bool* message_was_ok) { +bool WebRtcLoggingHandlerHost::OnMessageReceived(const IPC::Message& message) { DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO)); bool handled = true; - IPC_BEGIN_MESSAGE_MAP_EX(WebRtcLoggingHandlerHost, message, *message_was_ok) + IPC_BEGIN_MESSAGE_MAP(WebRtcLoggingHandlerHost, message) IPC_MESSAGE_HANDLER(WebRtcLoggingMsg_AddLogMessages, OnAddLogMessages) IPC_MESSAGE_HANDLER(WebRtcLoggingMsg_LoggingStopped, OnLoggingStoppedInRenderer) IPC_MESSAGE_UNHANDLED(handled = false) - IPC_END_MESSAGE_MAP_EX() + IPC_END_MESSAGE_MAP() return handled; } diff --git a/chrome/browser/media/webrtc_logging_handler_host.h b/chrome/browser/media/webrtc_logging_handler_host.h index 835fbda..002d4a4 100644 --- a/chrome/browser/media/webrtc_logging_handler_host.h +++ b/chrome/browser/media/webrtc_logging_handler_host.h @@ -117,8 +117,7 @@ class WebRtcLoggingHandlerHost : public content::BrowserMessageFilter { // BrowserMessageFilter implementation. virtual void OnChannelClosing() OVERRIDE; virtual void OnDestruct() const OVERRIDE; - virtual bool OnMessageReceived(const IPC::Message& message, - bool* message_was_ok) OVERRIDE; + virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE; // Handles log message requests from renderer process. void OnAddLogMessages(const std::vector<WebRtcLoggingMessageData>& messages); diff --git a/chrome/browser/plugins/plugin_info_message_filter.cc b/chrome/browser/plugins/plugin_info_message_filter.cc index 85b0995..12dc33d 100644 --- a/chrome/browser/plugins/plugin_info_message_filter.cc +++ b/chrome/browser/plugins/plugin_info_message_filter.cc @@ -96,9 +96,8 @@ PluginInfoMessageFilter::PluginInfoMessageFilter( weak_ptr_factory_(this) { } -bool PluginInfoMessageFilter::OnMessageReceived(const IPC::Message& message, - bool* message_was_ok) { - IPC_BEGIN_MESSAGE_MAP_EX(PluginInfoMessageFilter, message, *message_was_ok) +bool PluginInfoMessageFilter::OnMessageReceived(const IPC::Message& message) { + IPC_BEGIN_MESSAGE_MAP(PluginInfoMessageFilter, message) IPC_MESSAGE_HANDLER_DELAY_REPLY(ChromeViewHostMsg_GetPluginInfo, OnGetPluginInfo) IPC_MESSAGE_HANDLER( diff --git a/chrome/browser/plugins/plugin_info_message_filter.h b/chrome/browser/plugins/plugin_info_message_filter.h index fb1744d..09ad590 100644 --- a/chrome/browser/plugins/plugin_info_message_filter.h +++ b/chrome/browser/plugins/plugin_info_message_filter.h @@ -78,8 +78,7 @@ class PluginInfoMessageFilter : public content::BrowserMessageFilter { PluginInfoMessageFilter(int render_process_id, Profile* profile); // content::BrowserMessageFilter methods: - virtual bool OnMessageReceived(const IPC::Message& message, - bool* message_was_ok) OVERRIDE; + virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE; virtual void OnDestruct() const OVERRIDE; private: diff --git a/chrome/browser/prerender/prerender_browsertest.cc b/chrome/browser/prerender/prerender_browsertest.cc index 998d954..1d6a792 100644 --- a/chrome/browser/prerender/prerender_browsertest.cc +++ b/chrome/browser/prerender/prerender_browsertest.cc @@ -222,8 +222,7 @@ class ChannelDestructionWatcher { base::Unretained(watcher_))); } - virtual bool OnMessageReceived(const IPC::Message& message, - bool* message_was_ok) OVERRIDE { + virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE { return false; } diff --git a/chrome/browser/prerender/prerender_message_filter.cc b/chrome/browser/prerender/prerender_message_filter.cc index 808c23e..14b6beb 100644 --- a/chrome/browser/prerender/prerender_message_filter.cc +++ b/chrome/browser/prerender/prerender_message_filter.cc @@ -41,10 +41,9 @@ PrerenderMessageFilter::PrerenderMessageFilter(int render_process_id, PrerenderMessageFilter::~PrerenderMessageFilter() { } -bool PrerenderMessageFilter::OnMessageReceived(const IPC::Message& message, - bool* message_was_ok) { +bool PrerenderMessageFilter::OnMessageReceived(const IPC::Message& message) { bool handled = true; - IPC_BEGIN_MESSAGE_MAP_EX(PrerenderMessageFilter, message, *message_was_ok) + IPC_BEGIN_MESSAGE_MAP(PrerenderMessageFilter, message) IPC_MESSAGE_HANDLER(PrerenderHostMsg_AddLinkRelPrerender, OnAddPrerender) IPC_MESSAGE_HANDLER( PrerenderHostMsg_CancelLinkRelPrerender, OnCancelPrerender) diff --git a/chrome/browser/prerender/prerender_message_filter.h b/chrome/browser/prerender/prerender_message_filter.h index a5a7ac6..4c329bc 100644 --- a/chrome/browser/prerender/prerender_message_filter.h +++ b/chrome/browser/prerender/prerender_message_filter.h @@ -34,8 +34,7 @@ class PrerenderMessageFilter : public content::BrowserMessageFilter { virtual ~PrerenderMessageFilter(); // Overridden from content::BrowserMessageFilter. - virtual bool OnMessageReceived(const IPC::Message& message, - bool* message_was_ok) OVERRIDE; + virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE; virtual void OverrideThreadForMessage( const IPC::Message& message, content::BrowserThread::ID* thread) OVERRIDE; diff --git a/chrome/browser/printing/printing_message_filter.cc b/chrome/browser/printing/printing_message_filter.cc index 421cf49..485cff6 100644 --- a/chrome/browser/printing/printing_message_filter.cc +++ b/chrome/browser/printing/printing_message_filter.cc @@ -115,10 +115,9 @@ void PrintingMessageFilter::OverrideThreadForMessage( #endif } -bool PrintingMessageFilter::OnMessageReceived(const IPC::Message& message, - bool* message_was_ok) { +bool PrintingMessageFilter::OnMessageReceived(const IPC::Message& message) { bool handled = true; - IPC_BEGIN_MESSAGE_MAP_EX(PrintingMessageFilter, message, *message_was_ok) + IPC_BEGIN_MESSAGE_MAP(PrintingMessageFilter, message) #if defined(OS_WIN) IPC_MESSAGE_HANDLER(PrintHostMsg_DuplicateSection, OnDuplicateSection) #endif diff --git a/chrome/browser/printing/printing_message_filter.h b/chrome/browser/printing/printing_message_filter.h index 3c0bf88..7a16d2e 100644 --- a/chrome/browser/printing/printing_message_filter.h +++ b/chrome/browser/printing/printing_message_filter.h @@ -43,8 +43,7 @@ class PrintingMessageFilter : public content::BrowserMessageFilter { virtual void OverrideThreadForMessage( const IPC::Message& message, content::BrowserThread::ID* thread) OVERRIDE; - virtual bool OnMessageReceived(const IPC::Message& message, - bool* message_was_ok) OVERRIDE; + virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE; private: virtual ~PrintingMessageFilter(); diff --git a/chrome/browser/renderer_host/chrome_render_message_filter.cc b/chrome/browser/renderer_host/chrome_render_message_filter.cc index bb0ed1b..14a36a3 100644 --- a/chrome/browser/renderer_host/chrome_render_message_filter.cc +++ b/chrome/browser/renderer_host/chrome_render_message_filter.cc @@ -96,10 +96,9 @@ ChromeRenderMessageFilter::ChromeRenderMessageFilter( ChromeRenderMessageFilter::~ChromeRenderMessageFilter() { } -bool ChromeRenderMessageFilter::OnMessageReceived(const IPC::Message& message, - bool* message_was_ok) { +bool ChromeRenderMessageFilter::OnMessageReceived(const IPC::Message& message) { bool handled = true; - IPC_BEGIN_MESSAGE_MAP_EX(ChromeRenderMessageFilter, message, *message_was_ok) + IPC_BEGIN_MESSAGE_MAP(ChromeRenderMessageFilter, message) IPC_MESSAGE_HANDLER(ChromeViewHostMsg_DnsPrefetch, OnDnsPrefetch) IPC_MESSAGE_HANDLER(ChromeViewHostMsg_Preconnect, OnPreconnect) IPC_MESSAGE_HANDLER(ChromeViewHostMsg_ResourceTypeStats, diff --git a/chrome/browser/renderer_host/chrome_render_message_filter.h b/chrome/browser/renderer_host/chrome_render_message_filter.h index 7763c13..9270a04 100644 --- a/chrome/browser/renderer_host/chrome_render_message_filter.h +++ b/chrome/browser/renderer_host/chrome_render_message_filter.h @@ -52,8 +52,7 @@ class ChromeRenderMessageFilter : public content::BrowserMessageFilter { }; // content::BrowserMessageFilter methods: - virtual bool OnMessageReceived(const IPC::Message& message, - bool* message_was_ok) OVERRIDE; + virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE; virtual void OverrideThreadForMessage( const IPC::Message& message, content::BrowserThread::ID* thread) OVERRIDE; diff --git a/chrome/browser/search_engines/search_provider_install_state_message_filter.cc b/chrome/browser/search_engines/search_provider_install_state_message_filter.cc index c4ca4a0..a7ea757 100644 --- a/chrome/browser/search_engines/search_provider_install_state_message_filter.cc +++ b/chrome/browser/search_engines/search_provider_install_state_message_filter.cc @@ -31,12 +31,10 @@ SearchProviderInstallStateMessageFilter( } bool SearchProviderInstallStateMessageFilter::OnMessageReceived( - const IPC::Message& message, - bool* message_was_ok) { + const IPC::Message& message) { DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO)); bool handled = true; - IPC_BEGIN_MESSAGE_MAP_EX(SearchProviderInstallStateMessageFilter, message, - *message_was_ok) + IPC_BEGIN_MESSAGE_MAP(SearchProviderInstallStateMessageFilter, message) IPC_MESSAGE_HANDLER_DELAY_REPLY( ChromeViewHostMsg_GetSearchProviderInstallState, OnGetSearchProviderInstallState) diff --git a/chrome/browser/search_engines/search_provider_install_state_message_filter.h b/chrome/browser/search_engines/search_provider_install_state_message_filter.h index 8aa9c9c..a15601d 100644 --- a/chrome/browser/search_engines/search_provider_install_state_message_filter.h +++ b/chrome/browser/search_engines/search_provider_install_state_message_filter.h @@ -22,8 +22,7 @@ class SearchProviderInstallStateMessageFilter Profile* profile); // content::BrowserMessageFilter implementation. - virtual bool OnMessageReceived(const IPC::Message& message, - bool* message_was_ok) OVERRIDE; + virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE; private: virtual ~SearchProviderInstallStateMessageFilter(); diff --git a/chrome/browser/signin/principals_message_filter.cc b/chrome/browser/signin/principals_message_filter.cc index d047d80..ef8dd50 100644 --- a/chrome/browser/signin/principals_message_filter.cc +++ b/chrome/browser/signin/principals_message_filter.cc @@ -22,10 +22,9 @@ void PrincipalsMessageFilter::OverrideThreadForMessage( *thread = content::BrowserThread::UI; } -bool PrincipalsMessageFilter::OnMessageReceived(const IPC::Message& message, - bool* message_was_ok) { +bool PrincipalsMessageFilter::OnMessageReceived(const IPC::Message& message) { bool handled = true; - IPC_BEGIN_MESSAGE_MAP_EX(PrincipalsMessageFilter, message, *message_was_ok) + IPC_BEGIN_MESSAGE_MAP(PrincipalsMessageFilter, message) IPC_MESSAGE_HANDLER( ChromeViewHostMsg_GetManagedAccounts, OnMsgGetManagedAccounts) IPC_MESSAGE_HANDLER( diff --git a/chrome/browser/signin/principals_message_filter.h b/chrome/browser/signin/principals_message_filter.h index 156a9a9..eb7d858 100644 --- a/chrome/browser/signin/principals_message_filter.h +++ b/chrome/browser/signin/principals_message_filter.h @@ -20,8 +20,7 @@ class PrincipalsMessageFilter : public content::BrowserMessageFilter { virtual void OverrideThreadForMessage( const IPC::Message& message, content::BrowserThread::ID* thread) OVERRIDE; - virtual bool OnMessageReceived(const IPC::Message& message, - bool* message_was_ok) OVERRIDE; + virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE; private: virtual ~PrincipalsMessageFilter(); diff --git a/chrome/browser/speech/tts_message_filter.cc b/chrome/browser/speech/tts_message_filter.cc index 6488b36..789eac3 100644 --- a/chrome/browser/speech/tts_message_filter.cc +++ b/chrome/browser/speech/tts_message_filter.cc @@ -35,10 +35,9 @@ void TtsMessageFilter::OverrideThreadForMessage( } } -bool TtsMessageFilter::OnMessageReceived(const IPC::Message& message, - bool* message_was_ok) { +bool TtsMessageFilter::OnMessageReceived(const IPC::Message& message) { bool handled = true; - IPC_BEGIN_MESSAGE_MAP_EX(TtsMessageFilter, message, *message_was_ok) + IPC_BEGIN_MESSAGE_MAP(TtsMessageFilter, message) IPC_MESSAGE_HANDLER(TtsHostMsg_InitializeVoiceList, OnInitializeVoiceList) IPC_MESSAGE_HANDLER(TtsHostMsg_Speak, OnSpeak) IPC_MESSAGE_HANDLER(TtsHostMsg_Pause, OnPause) diff --git a/chrome/browser/speech/tts_message_filter.h b/chrome/browser/speech/tts_message_filter.h index b81c56c..629745c 100644 --- a/chrome/browser/speech/tts_message_filter.h +++ b/chrome/browser/speech/tts_message_filter.h @@ -24,8 +24,7 @@ class TtsMessageFilter virtual void OverrideThreadForMessage( const IPC::Message& message, content::BrowserThread::ID* thread) OVERRIDE; - virtual bool OnMessageReceived(const IPC::Message& message, - bool* message_was_ok) OVERRIDE; + virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE; virtual void OnChannelClosing() OVERRIDE; // UtteranceEventDelegate implementation. diff --git a/chrome/browser/spellchecker/spellcheck_message_filter.cc b/chrome/browser/spellchecker/spellcheck_message_filter.cc index e9265dd..024ce7f 100644 --- a/chrome/browser/spellchecker/spellcheck_message_filter.cc +++ b/chrome/browser/spellchecker/spellcheck_message_filter.cc @@ -43,10 +43,9 @@ void SpellCheckMessageFilter::OverrideThreadForMessage( #endif } -bool SpellCheckMessageFilter::OnMessageReceived(const IPC::Message& message, - bool* message_was_ok) { +bool SpellCheckMessageFilter::OnMessageReceived(const IPC::Message& message) { bool handled = true; - IPC_BEGIN_MESSAGE_MAP_EX(SpellCheckMessageFilter, message, *message_was_ok) + IPC_BEGIN_MESSAGE_MAP(SpellCheckMessageFilter, message) IPC_MESSAGE_HANDLER(SpellCheckHostMsg_RequestDictionary, OnSpellCheckerRequestDictionary) IPC_MESSAGE_HANDLER(SpellCheckHostMsg_NotifyChecked, diff --git a/chrome/browser/spellchecker/spellcheck_message_filter.h b/chrome/browser/spellchecker/spellcheck_message_filter.h index fb262ff..77002cc 100644 --- a/chrome/browser/spellchecker/spellcheck_message_filter.h +++ b/chrome/browser/spellchecker/spellcheck_message_filter.h @@ -24,8 +24,7 @@ class SpellCheckMessageFilter : public content::BrowserMessageFilter { virtual void OverrideThreadForMessage( const IPC::Message& message, content::BrowserThread::ID* thread) OVERRIDE; - virtual bool OnMessageReceived(const IPC::Message& message, - bool* message_was_ok) OVERRIDE; + virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE; private: friend class TestingSpellCheckMessageFilter; diff --git a/chrome/browser/spellchecker/spellcheck_message_filter_mac.cc b/chrome/browser/spellchecker/spellcheck_message_filter_mac.cc index b4eb556..d96cc55 100644 --- a/chrome/browser/spellchecker/spellcheck_message_filter_mac.cc +++ b/chrome/browser/spellchecker/spellcheck_message_filter_mac.cc @@ -200,10 +200,10 @@ void SpellCheckMessageFilterMac::OverrideThreadForMessage( *thread = BrowserThread::UI; } -bool SpellCheckMessageFilterMac::OnMessageReceived(const IPC::Message& message, - bool* message_was_ok) { +bool SpellCheckMessageFilterMac::OnMessageReceived( + const IPC::Message& message) { bool handled = true; - IPC_BEGIN_MESSAGE_MAP_EX(SpellCheckMessageFilterMac, message, *message_was_ok) + IPC_BEGIN_MESSAGE_MAP(SpellCheckMessageFilterMac, message) IPC_MESSAGE_HANDLER(SpellCheckHostMsg_CheckSpelling, OnCheckSpelling) IPC_MESSAGE_HANDLER(SpellCheckHostMsg_FillSuggestionList, diff --git a/chrome/browser/spellchecker/spellcheck_message_filter_mac.h b/chrome/browser/spellchecker/spellcheck_message_filter_mac.h index 944a1f0..dceda30 100644 --- a/chrome/browser/spellchecker/spellcheck_message_filter_mac.h +++ b/chrome/browser/spellchecker/spellcheck_message_filter_mac.h @@ -21,8 +21,7 @@ class SpellCheckMessageFilterMac : public content::BrowserMessageFilter { virtual void OverrideThreadForMessage( const IPC::Message& message, content::BrowserThread::ID* thread) OVERRIDE; - virtual bool OnMessageReceived(const IPC::Message& message, - bool* message_was_ok) OVERRIDE; + virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE; // Adjusts remote_results by examining local_results. Any result that's both // local and remote stays type SPELLING, all others are flagged GRAMMAR. diff --git a/chrome/browser/spellchecker/spellcheck_message_filter_mac_browsertest.cc b/chrome/browser/spellchecker/spellcheck_message_filter_mac_browsertest.cc index 2d3efc1..1114b7c 100644 --- a/chrome/browser/spellchecker/spellcheck_message_filter_mac_browsertest.cc +++ b/chrome/browser/spellchecker/spellcheck_message_filter_mac_browsertest.cc @@ -45,9 +45,7 @@ IN_PROC_BROWSER_TEST_F(SpellCheckMessageFilterMacBrowserTest, SpellCheckHostMsg_RequestTextCheck to_be_received( 123, 456, base::UTF8ToUTF16("zz."), std::vector<SpellCheckMarker>()); - bool handled = false; - target->OnMessageReceived(to_be_received, &handled); - EXPECT_TRUE(handled); + target->OnMessageReceived(to_be_received); base::MessageLoopForUI::current()->Run(); EXPECT_EQ(1U, target->sent_messages_.size()); diff --git a/chrome/renderer/chrome_mock_render_thread.cc b/chrome/renderer/chrome_mock_render_thread.cc index fa208d9..d624e4a 100644 --- a/chrome/renderer/chrome_mock_render_thread.cc +++ b/chrome/renderer/chrome_mock_render_thread.cc @@ -53,8 +53,7 @@ bool ChromeMockRenderThread::OnMessageReceived(const IPC::Message& msg) { // Some messages we do special handling. bool handled = true; - bool msg_is_ok = true; - IPC_BEGIN_MESSAGE_MAP_EX(ChromeMockRenderThread, msg, msg_is_ok) + IPC_BEGIN_MESSAGE_MAP(ChromeMockRenderThread, msg) IPC_MESSAGE_HANDLER(ExtensionHostMsg_OpenChannelToExtension, OnOpenChannelToExtension) #if defined(ENABLE_PRINTING) @@ -80,7 +79,7 @@ bool ChromeMockRenderThread::OnMessageReceived(const IPC::Message& msg) { #endif // defined(OS_CHROMEOS) #endif // defined(ENABLE_PRINTING) IPC_MESSAGE_UNHANDLED(handled = false) - IPC_END_MESSAGE_MAP_EX() + IPC_END_MESSAGE_MAP() return handled; } diff --git a/chrome/renderer/safe_browsing/phishing_classifier_delegate_browsertest.cc b/chrome/renderer/safe_browsing/phishing_classifier_delegate_browsertest.cc index e4908e9..f86a435 100644 --- a/chrome/renderer/safe_browsing/phishing_classifier_delegate_browsertest.cc +++ b/chrome/renderer/safe_browsing/phishing_classifier_delegate_browsertest.cc @@ -87,8 +87,7 @@ class InterceptingMessageFilter : public content::BrowserMessageFilter { } const ClientPhishingRequest* verdict() const { return verdict_.get(); } - virtual bool OnMessageReceived(const IPC::Message& message, - bool* message_was_ok) OVERRIDE { + virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE { bool handled = true; IPC_BEGIN_MESSAGE_MAP(InterceptingMessageFilter, message) IPC_MESSAGE_HANDLER(SafeBrowsingHostMsg_PhishingDetectionDone, |