diff options
| author | evan@chromium.org <evan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-07-13 21:14:39 +0000 |
|---|---|---|
| committer | evan@chromium.org <evan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-07-13 21:14:39 +0000 |
| commit | 97023ed4479530970d6c75ad2d2f86bda47d10d0 (patch) | |
| tree | a0275b3c042b1559fccb1e78f8c8ff8dc87fbb3f /chrome | |
| parent | 3c221847983a9707e391d42e2baf692c9165decc (diff) | |
| download | chromium_src-97023ed4479530970d6c75ad2d2f86bda47d10d0.zip chromium_src-97023ed4479530970d6c75ad2d2f86bda47d10d0.tar.gz chromium_src-97023ed4479530970d6c75ad2d2f86bda47d10d0.tar.bz2 | |
posix: drop a NOTIMPLEMENTED that is now implemented
Review URL: http://codereview.chromium.org/149550
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20530 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome')
| -rw-r--r-- | chrome/common/ipc_channel_proxy.cc | 13 |
1 files changed, 0 insertions, 13 deletions
diff --git a/chrome/common/ipc_channel_proxy.cc b/chrome/common/ipc_channel_proxy.cc index c77ee7e..c97e6f5 100644 --- a/chrome/common/ipc_channel_proxy.cc +++ b/chrome/common/ipc_channel_proxy.cc @@ -228,19 +228,6 @@ void ChannelProxy::Init(const std::string& channel_id, Channel::Mode mode, // to connect and get an error since the pipe doesn't exist yet. context_->CreateChannel(channel_id, mode); } else { -#if defined(OS_POSIX) - // TODO(playmobil): On POSIX, IPC::Channel uses a socketpair(), one side of - // which needs to be mapped into the child process' address space. - // To know the value of the client side FD we need to have already - // created a socketpair which currently occurs in IPC::Channel's - // constructor. - // If we lazilly construct the IPC::Channel then the caller has no way - // of knowing the FD #. - // - // We can solve this either by having the Channel's creation launch the - // subprocess itself or by creating the socketpair() externally. - NOTIMPLEMENTED(); -#endif // defined(OS_POSIX) context_->ipc_message_loop()->PostTask(FROM_HERE, NewRunnableMethod( context_.get(), &Context::CreateChannel, channel_id, mode)); } |