diff options
author | csharp@chromium.org <csharp@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-02-12 23:16:39 +0000 |
---|---|---|
committer | csharp@chromium.org <csharp@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-02-12 23:16:39 +0000 |
commit | 0f02ca43f8db0c72ef862b92867fc48248fbe566 (patch) | |
tree | 15057329fb4482981da66c472b6cb7251aa6569f /chrome | |
parent | cd2ef753628c0c797f5fa8f9df4f12d029705b2a (diff) | |
download | chromium_src-0f02ca43f8db0c72ef862b92867fc48248fbe566.zip chromium_src-0f02ca43f8db0c72ef862b92867fc48248fbe566.tar.gz chromium_src-0f02ca43f8db0c72ef862b92867fc48248fbe566.tar.bz2 |
Add a UMA stat to track if the Browser blacklist is Set on the Renderer
This shouldn't be happening, but we got some crash reports suggesting it
does. Unable to repo locally so this stat will verify it does occur and
then can be used to verify our fixes actually fix it.
BUG=329023
Review URL: https://codereview.chromium.org/140763008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250828 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome')
-rw-r--r-- | chrome/chrome_renderer.gypi | 3 | ||||
-rw-r--r-- | chrome/interactive_ui_tests.isolate | 1 | ||||
-rw-r--r-- | chrome/renderer/DEPS | 1 | ||||
-rw-r--r-- | chrome/renderer/chrome_content_renderer_client.cc | 17 | ||||
-rw-r--r-- | chrome/unit_tests.isolate | 3 |
5 files changed, 24 insertions, 1 deletions
diff --git a/chrome/chrome_renderer.gypi b/chrome/chrome_renderer.gypi index b546cd6..c1444cc 100644 --- a/chrome/chrome_renderer.gypi +++ b/chrome/chrome_renderer.gypi @@ -441,6 +441,9 @@ ], }], ['OS=="win"', { + 'dependencies': [ + '../chrome_elf/chrome_elf.gyp:chrome_elf', + ], 'include_dirs': [ '<(DEPTH)/third_party/wtl/include', ], diff --git a/chrome/interactive_ui_tests.isolate b/chrome/interactive_ui_tests.isolate index 248367e..ebd8ebe 100644 --- a/chrome/interactive_ui_tests.isolate +++ b/chrome/interactive_ui_tests.isolate @@ -76,6 +76,7 @@ 'isolate_dependency_tracked': [ '../net/data/ssl/certificates/foaf.me.chromium-test-cert.der', '../net/data/ssl/certificates/mit.davidben.der', + '<(PRODUCT_DIR)/chrome_elf.dll', '<(PRODUCT_DIR)/d3dcompiler_46.dll', '<(PRODUCT_DIR)/ffmpegsumo.dll', '<(PRODUCT_DIR)/libEGL.dll', diff --git a/chrome/renderer/DEPS b/chrome/renderer/DEPS index 14a782f..bf9a831f 100644 --- a/chrome/renderer/DEPS +++ b/chrome/renderer/DEPS @@ -1,4 +1,5 @@ include_rules = [ + "+chrome_elf", "+components/autofill/content/common", "+components/autofill/content/renderer", "+components/autofill/core/common", diff --git a/chrome/renderer/chrome_content_renderer_client.cc b/chrome/renderer/chrome_content_renderer_client.cc index 9318da9..35abf40 100644 --- a/chrome/renderer/chrome_content_renderer_client.cc +++ b/chrome/renderer/chrome_content_renderer_client.cc @@ -116,6 +116,10 @@ #include "chrome/renderer/spellchecker/spellcheck_provider.h" #endif +#if defined(OS_WIN) +#include "chrome_elf/blacklist/blacklist.h" +#endif // OS_WIN + using autofill::AutofillAgent; using autofill::PasswordAutofillAgent; using autofill::PasswordGenerationAgent; @@ -353,6 +357,19 @@ void ChromeContentRendererClient::RenderThreadStarted() { extensions::ExtensionsClient::Set( extensions::ChromeExtensionsClient::GetInstance()); + +#if defined(OS_WIN) + // Report if the renderer process has been patched by chrome_elf. + // TODO(csharp): Remove once the renderer is no longer getting + // patched this way. + typedef bool(*IsBlacklistInitializedFunc)(); + IsBlacklistInitializedFunc is_blacklist_initialized = + reinterpret_cast<IsBlacklistInitializedFunc>( + GetProcAddress(GetModuleHandle(L"chrome_elf.dll"), + "IsBlacklistInitialized")); + if (is_blacklist_initialized()) + UMA_HISTOGRAM_BOOLEAN("Blacklist.PatchedInRenderer", true); +#endif } void ChromeContentRendererClient::RenderFrameCreated( diff --git a/chrome/unit_tests.isolate b/chrome/unit_tests.isolate index 526b2e3..7a9d472 100644 --- a/chrome/unit_tests.isolate +++ b/chrome/unit_tests.isolate @@ -102,7 +102,8 @@ ['OS=="win"', { 'variables': { 'isolate_dependency_tracked': [ - '<(PRODUCT_DIR)/ffmpegsumo.dll', + '<(PRODUCT_DIR)/chrome_elf.dll', + '<(PRODUCT_DIR)/ffmpegsumo.dll', ], 'isolate_dependency_untracked': [ '../ppapi/lib/gl/include/KHR/', |