diff options
author | agl@chromium.org <agl@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-07-16 02:37:38 +0000 |
---|---|---|
committer | agl@chromium.org <agl@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-07-16 02:37:38 +0000 |
commit | 0195cd569f7dc020c1667b10075025f15620b072 (patch) | |
tree | ed205f963e7308198320ce82d48c3fb42180ec42 /chrome | |
parent | dcbbc67b1f2f8d93f3b085625c1827a7ce751b80 (diff) | |
download | chromium_src-0195cd569f7dc020c1667b10075025f15620b072.zip chromium_src-0195cd569f7dc020c1667b10075025f15620b072.tar.gz chromium_src-0195cd569f7dc020c1667b10075025f15620b072.tar.bz2 |
Revert "Linux: reap the sandbox helper process."
This reverts commit r20838: it broke unit tests on Linux.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20842 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome')
-rw-r--r-- | chrome/browser/zygote_host_linux.cc | 9 |
1 files changed, 0 insertions, 9 deletions
diff --git a/chrome/browser/zygote_host_linux.cc b/chrome/browser/zygote_host_linux.cc index 769a180..dad473b 100644 --- a/chrome/browser/zygote_host_linux.cc +++ b/chrome/browser/zygote_host_linux.cc @@ -21,7 +21,6 @@ #include "chrome/browser/renderer_host/render_sandbox_host_linux.h" #include "chrome/common/chrome_constants.h" #include "chrome/common/chrome_switches.h" -#include "chrome/common/process_watcher.h" ZygoteHost::ZygoteHost() { std::wstring chrome_path; @@ -44,7 +43,6 @@ ZygoteHost::ZygoteHost() { } const char* sandbox_binary = NULL; - bool sandbox_was_used = false; struct stat st; // In Chromium branded builds, developers can set an environment variable to @@ -72,7 +70,6 @@ ZygoteHost::ZygoteHost() { const char* ld_library_path = getenv("LD_LIBRARY_PATH"); if (ld_library_path) setenv("SANDBOX_LD_LIBRARY_PATH", ld_library_path, 1 /* overwrite */); - sandbox_was_used = true; } else { LOG(FATAL) << "The SUID sandbox helper binary was found, but is not " "configured correctly. Rather than run without sandboxing " @@ -90,12 +87,6 @@ ZygoteHost::ZygoteHost() { base::LaunchApp(cmd_line.argv(), fds_to_map, false, &process); CHECK(process != -1) << "Failed to launch zygote process"; - if (sandbox_was_used) { - // The sandbox binary will fork one or more times before running the zygote - // process. Thus, we need to reap the child. - ProcessWatcher::EnsureProcessTerminated(process); - } - close(fds[1]); control_fd_ = fds[0]; } |