diff options
author | kbr@google.com <kbr@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-01-11 19:50:40 +0000 |
---|---|---|
committer | kbr@google.com <kbr@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-01-11 19:50:40 +0000 |
commit | 49861ff21dace659d3da493b38551a07a611f4f4 (patch) | |
tree | c9d54f54ac8e3808a47730b9bc42b53d24c16e66 /chrome | |
parent | 80091c77e972d9797359388abf3baf2c46326716 (diff) | |
download | chromium_src-49861ff21dace659d3da493b38551a07a611f4f4.zip chromium_src-49861ff21dace659d3da493b38551a07a611f4f4.tar.gz chromium_src-49861ff21dace659d3da493b38551a07a611f4f4.tar.bz2 |
Move the in-process WebGL implementation from the WebKit to the
Chromium repository to break circular dependencies on Chromium's
OpenGL bindings in app/gfx/gl.
The minimal changes to the code were made in order to break
dependencies on WebCore types and to make the code fit the Google C++
style guide as closely as possible. There are many references to
undesirable types like "long" in the WebGraphicsContext3D interface,
which are the source of the majority of lint errors and which will be
fixed in follow-on work.
The upstream WebGraphicsContext3DDefaultImpl will be deleted after
this lands.
Tested:
- Various WebGL demos in Chrome
- Built and ran WebGL layout tests in DRT
BUG=none
TEST=none (see above)
Review URL: http://codereview.chromium.org/6100009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71069 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome')
-rw-r--r-- | chrome/chrome_renderer.gypi | 1 | ||||
-rw-r--r-- | chrome/renderer/DEPS | 1 | ||||
-rw-r--r-- | chrome/renderer/renderer_webkitclient_impl.cc | 5 |
3 files changed, 5 insertions, 2 deletions
diff --git a/chrome/chrome_renderer.gypi b/chrome/chrome_renderer.gypi index fe979af..ebbd838 100644 --- a/chrome/chrome_renderer.gypi +++ b/chrome/chrome_renderer.gypi @@ -26,6 +26,7 @@ '../third_party/npapi/npapi.gyp:npapi', '../third_party/WebKit/WebKit/chromium/WebKit.gyp:webkit', '../webkit/support/webkit_support.gyp:glue', + '../webkit/support/webkit_support.gyp:webkit_gpu', '../webkit/support/webkit_support.gyp:webkit_resources', ], 'include_dirs': [ diff --git a/chrome/renderer/DEPS b/chrome/renderer/DEPS index dfd8d21..3025ecf 100644 --- a/chrome/renderer/DEPS +++ b/chrome/renderer/DEPS @@ -14,6 +14,7 @@ include_rules = [ "+webkit/extensions", "+webkit/glue", "+webkit/glue/plugins", + "+webkit/gpu", "+webkit/plugins", "+v8/include", "+third_party/cld/encodings/compact_lang_det/win", diff --git a/chrome/renderer/renderer_webkitclient_impl.cc b/chrome/renderer/renderer_webkitclient_impl.cc index 1025e69..1683691 100644 --- a/chrome/renderer/renderer_webkitclient_impl.cc +++ b/chrome/renderer/renderer_webkitclient_impl.cc @@ -42,6 +42,7 @@ #include "webkit/glue/webclipboard_impl.h" #include "webkit/glue/webfileutilities_impl.h" #include "webkit/glue/webkit_glue.h" +#include "webkit/gpu/webgraphicscontext3d_in_process_impl.h" #if defined(OS_WIN) #include "third_party/WebKit/WebKit/chromium/public/win/WebSandboxSupport.h" @@ -504,11 +505,11 @@ RendererWebKitClientImpl::sharedWorkerRepository() { WebKit::WebGraphicsContext3D* RendererWebKitClientImpl::createGraphicsContext3D() { - // The WebGraphicsContext3D::createDefault code path is used for + // The WebGraphicsContext3DInProcessImpl code path is used for // layout tests (though not through this code) as well as for // debugging and bringing up new ports. if (CommandLine::ForCurrentProcess()->HasSwitch(switches::kInProcessWebGL)) { - return WebKit::WebGraphicsContext3D::createDefault(); + return new webkit_gpu::WebGraphicsContext3DInProcessImpl(); } else { #if defined(ENABLE_GPU) return new WebGraphicsContext3DCommandBufferImpl(); |