Fix a memory leak in ExtensionMessageService.

Also grasp at straws trying to fix a crash bug.

BUG=21201

Review URL: http://codereview.chromium.org/345058

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31024 0039d316-1c4b-4281-b951-d872f2087c98

2 files changed, 10 insertions, 7 deletions

diff --git a/chrome/browser/extensions/extension_message_service.cc b/chrome/browser/extensions/extension_message_service.cc
index 92c77a8..2957f71 100644
--- a/chrome/browser/extensions/extension_message_service.cc
+++ b/chrome/browser/extensions/extension_message_service.cc
@@ -126,6 +126,8 @@ ExtensionMessageService::ExtensionMessageService(Profile* profile)
 }
 
 ExtensionMessageService::~ExtensionMessageService() {
+  STLDeleteContainerPairSecondPointers(channels_.begin(), channels_.end());
+  channels_.clear();
 }
 
 void ExtensionMessageService::ProfileDestroyed() {
@@ -302,12 +304,13 @@ bool ExtensionMessageService::OpenChannelOnUIThreadImpl(
   // http://code.google.com/p/chromium/issues/detail?id=19067
   CHECK(receiver.sender);
 
-  linked_ptr<MessageChannel> channel(new MessageChannel);
+  MessageChannel* channel(new MessageChannel);
   channel->opener = MessagePort(source, MSG_ROUTING_CONTROL);
   channel->receiver = receiver;
 
   CHECK(receiver.sender);
 
+  CHECK(channels_.find(GET_CHANNEL_ID(receiver_port_id)) == channels_.end());
   channels_[GET_CHANNEL_ID(receiver_port_id)] = channel;
 
   CHECK(receiver.sender);
@@ -315,9 +318,9 @@ bool ExtensionMessageService::OpenChannelOnUIThreadImpl(
   // Include info about the opener's tab (if it was a tab).
   std::string tab_json = "null";
   if (source_contents) {
-    DictionaryValue* tab_value =
-        ExtensionTabUtil::CreateTabValue(source_contents);
-    base::JSONWriter::Write(tab_value, false, &tab_json);
+    scoped_ptr<DictionaryValue> tab_value(
+        ExtensionTabUtil::CreateTabValue(source_contents));
+    base::JSONWriter::Write(tab_value.get(), false, &tab_json);
   }
 
   CHECK(receiver.sender);
@@ -343,7 +346,7 @@ int ExtensionMessageService::OpenSpecialChannelToExtension(
 
   MessagePort receiver(
       profile_->GetExtensionProcessManager()->
-      GetExtensionProcess(extension_id),
+          GetExtensionProcess(extension_id),
       MSG_ROUTING_CONTROL);
   receiver.debug_info = 4;
   if (!OpenChannelOnUIThreadImpl(
@@ -397,6 +400,7 @@ void ExtensionMessageService::CloseChannelImpl(
 
   if (notify_other_port)
     DispatchOnDisconnect(port, GET_OPPOSITE_PORT_ID(closing_port_id));
+  delete channel_iter->second;
   channels_.erase(channel_iter);
 }
 
diff --git a/chrome/browser/extensions/extension_message_service.h b/chrome/browser/extensions/extension_message_service.h
index 0164cd2..cf52b65 100644
--- a/chrome/browser/extensions/extension_message_service.h
+++ b/chrome/browser/extensions/extension_message_service.h
@@ -9,7 +9,6 @@
 #include <set>
 #include <string>
 
-#include "base/linked_ptr.h"
 #include "base/lock.h"
 #include "base/ref_counted.h"
 #include "chrome/common/notification_registrar.h"
@@ -130,7 +129,7 @@ class ExtensionMessageService
 
  private:
   // A map of channel ID to its channel object.
-  typedef std::map<int, linked_ptr<MessageChannel> > MessageChannelMap;
+  typedef std::map<int, MessageChannel*> MessageChannelMap;
 
   // Allocates a pair of port ids.
   // NOTE: this can be called from any thread.