Handful of changes to get views building again. The tab.cc ifdefs are

only short term. I'll stub out parts of chrome_menu next so that these
can be removed.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/115406

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16178 0039d316-1c4b-4281-b951-d872f2087c98

7 files changed, 72 insertions, 7 deletions

diff --git a/chrome/browser/browser.cc b/chrome/browser/browser.cc
index c59f21e..9aaddee 100644
--- a/chrome/browser/browser.cc
+++ b/chrome/browser/browser.cc
@@ -67,7 +67,6 @@
 #include "chrome/browser/browser_url_handler.h"
 #include "chrome/browser/cert_store.h"
 #include "chrome/browser/debugger/debugger_window.h"
-#include "chrome/browser/dock_info.h"
 #include "chrome/browser/download/save_package.h"
 #include "chrome/browser/ssl/ssl_error_info.h"
 #include "chrome/browser/task_manager.h"
@@ -81,6 +80,10 @@
 #include "chrome/browser/window_sizer.h"
 #endif
 
+#if defined(TOOLKIT_VIEWS)
+#include "chrome/browser/dock_info.h"
+#endif
+
 using base::TimeDelta;
 
 // How long we wait before updating the browser chrome while loading a page.
diff --git a/chrome/browser/dock_info_gtk.cc b/chrome/browser/dock_info_gtk.cc
new file mode 100644
index 0000000..3a4d4cf
--- /dev/null
+++ b/chrome/browser/dock_info_gtk.cc
@@ -0,0 +1,33 @@
+// Copyright (c) 2009 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/dock_info.h"
+
+#include "base/gfx/native_widget_types.h"
+#include "base/logging.h"
+
+// static
+DockInfo DockInfo::GetDockInfoAtPoint(const gfx::Point& screen_point,
+                                      const std::set<GtkWindow*>& ignore) {
+  NOTIMPLEMENTED();
+  return DockInfo();
+}
+
+GtkWindow* DockInfo::GetLocalProcessWindowAtPoint(
+    const gfx::Point& screen_point,
+    const std::set<GtkWindow*>& ignore) {
+  NOTIMPLEMENTED();
+  if (factory_)
+    return factory_->GetLocalProcessWindowAtPoint(screen_point, ignore);
+  return NULL;
+}
+
+bool DockInfo::GetWindowBounds(gfx::Rect* bounds) const {
+  NOTIMPLEMENTED();
+  return true;
+}
+
+void DockInfo::SizeOtherWindowTo(const gfx::Rect& bounds) const {
+  NOTIMPLEMENTED();
+}
diff --git a/chrome/browser/views/tabs/tab.cc b/chrome/browser/views/tabs/tab.cc
index d5aa9a3..55fadc2 100644
--- a/chrome/browser/views/tabs/tab.cc
+++ b/chrome/browser/views/tabs/tab.cc
@@ -5,13 +5,16 @@
 #include "chrome/browser/views/tabs/tab.h"
 
 #include "app/gfx/canvas.h"
+#include "app/gfx/font.h"
 #include "app/gfx/path.h"
 #include "app/l10n_util.h"
 #include "app/resource_bundle.h"
 #include "base/gfx/size.h"
 #include "grit/generated_resources.h"
+#if defined(OS_WIN)
 #include "views/controls/menu/chrome_menu.h"
 #include "views/widget/tooltip_manager.h"
+#endif
 #include "views/widget/widget.h"
 
 const std::string Tab::kTabClassName = "browser/tabs/Tab";
@@ -20,6 +23,7 @@ static const SkScalar kTabCapWidth = 15;
 static const SkScalar kTabTopCurveWidth = 4;
 static const SkScalar kTabBottomCurveWidth = 3;
 
+#if defined(OS_WIN)
 class Tab::ContextMenuController : public views::MenuDelegate {
  public:
   explicit ContextMenuController(Tab* tab)
@@ -119,6 +123,7 @@ class Tab::ContextMenuController : public views::MenuDelegate {
 
   DISALLOW_COPY_AND_ASSIGN(ContextMenuController);
 };
+#endif
 
 ///////////////////////////////////////////////////////////////////////////////
 // Tab, public:
@@ -126,14 +131,19 @@ class Tab::ContextMenuController : public views::MenuDelegate {
 Tab::Tab(TabDelegate* delegate)
     : TabRenderer(),
       delegate_(delegate),
-      closing_(false),
-      menu_controller_(NULL) {
+      closing_(false)
+#if defined(OS_WIN)
+      , menu_controller_(NULL) {
+#else
+      {
+#endif
   close_button()->SetAccessibleName(l10n_util::GetString(IDS_ACCNAME_CLOSE));
   close_button()->SetAnimationDuration(0);
   SetContextMenuController(this);
 }
 
 Tab::~Tab() {
+#if defined(OS_WIN)
   if (menu_controller_) {
     // The menu is showing. Close the menu.
     menu_controller_->Cancel();
@@ -141,6 +151,7 @@ Tab::~Tab() {
     // Invoke this so that we hide the highlight.
     ContextMenuClosed();
   }
+#endif
 }
 
 ///////////////////////////////////////////////////////////////////////////////
@@ -211,7 +222,9 @@ bool Tab::GetTooltipText(int x, int y, std::wstring* tooltip) {
 bool Tab::GetTooltipTextOrigin(int x, int y, gfx::Point* origin) {
   gfx::Font font;
   origin->set_x(title_bounds().x() + 10);
+#if defined(OS_WIN)
   origin->set_y(-views::TooltipManager::GetTooltipHeight() - 4);
+#endif
   return true;
 }
 
@@ -232,11 +245,13 @@ bool Tab::GetAccessibleName(std::wstring* name) {
 
 void Tab::ShowContextMenu(views::View* source, int x, int y,
                           bool is_mouse_gesture) {
+#if defined(OS_WIN)
   if (menu_controller_)
     return;
   menu_controller_ = new ContextMenuController(this);
   menu_controller_->RunMenuAt(x, y);
   // ContextMenuController takes care of deleting itself.
+#endif
 }
 
 ///////////////////////////////////////////////////////////////////////////////
@@ -278,5 +293,7 @@ void Tab::MakePathForTab(gfx::Path* path) const {
 
 void Tab::ContextMenuClosed() {
   delegate()->StopAllHighlighting();
+#if defined(OS_WIN)
   menu_controller_ = NULL;
+#endif
 }
diff --git a/chrome/browser/views/tabs/tab.h b/chrome/browser/views/tabs/tab.h
index 920a849..15737aa 100644
--- a/chrome/browser/views/tabs/tab.h
+++ b/chrome/browser/views/tabs/tab.h
@@ -129,8 +129,10 @@ class Tab : public TabRenderer,
   // True if the tab is being animated closed.
   bool closing_;
 
+#if defined(OS_WIN)
   // If non-null it means we're showing a menu for the tab.
   ContextMenuController* menu_controller_;
+#endif
 
   DISALLOW_COPY_AND_ASSIGN(Tab);
 };
diff --git a/chrome/browser/views/tabs/tab_renderer.cc b/chrome/browser/views/tabs/tab_renderer.cc
index c27ece6..20df3bb 100644
--- a/chrome/browser/views/tabs/tab_renderer.cc
+++ b/chrome/browser/views/tabs/tab_renderer.cc
@@ -10,7 +10,6 @@
 #include "app/gfx/font.h"
 #include "app/l10n_util.h"
 #include "app/resource_bundle.h"
-#include "app/win_util.h"
 #include "chrome/browser/browser.h"
 #include "chrome/browser/browser_theme_provider.h"
 #include "chrome/browser/profile.h"
@@ -34,7 +33,6 @@ static const int kCloseButtonVertFuzz = 0;
 static const int kCloseButtonHorzFuzz = 5;
 static const int kFaviconSize = 16;
 static const int kSelectedTitleColor = SK_ColorBLACK;
-static const int kUnselectedTitleColor = SkColorSetRGB(64, 64, 64);
 
 // How long the hover state takes.
 static const int kHoverDurationMs = 90;
@@ -214,8 +212,8 @@ TabRenderer::TabRenderer()
       showing_icon_(false),
       showing_download_icon_(false),
       showing_close_button_(false),
-      crash_animation_(NULL),
       fav_icon_hiding_offset_(0),
+      crash_animation_(NULL),
       should_display_crashed_favicon_(false),
       theme_provider_(NULL) {
   InitResources();
@@ -676,7 +674,6 @@ void TabRenderer::PaintActiveTabBackground(gfx::Canvas* canvas) {
 
 void TabRenderer::PaintHoverTabBackground(gfx::Canvas* canvas,
                                           double opacity) {
-  bool is_otr = data_.off_the_record;
   SkBitmap left = skia::ImageOperations::CreateBlendedBitmap(
                   *tab_inactive.image_l, *tab_active.image_l, opacity);
   SkBitmap center = skia::ImageOperations::CreateBlendedBitmap(
diff --git a/chrome/chrome.gyp b/chrome/chrome.gyp
index 48da587..a07fac0 100644
--- a/chrome/chrome.gyp
+++ b/chrome/chrome.gyp
@@ -817,6 +817,7 @@
         'browser/debugger/devtools_window_win.cc',
         'browser/debugger/inspectable_tab_proxy.cc',
         'browser/debugger/inspectable_tab_proxy.h',
+        'browser/dock_info_gtk.cc',
         'browser/dock_info.cc',
         'browser/dock_info.h',
         'browser/dom_operation_notification_details.h',
@@ -1678,8 +1679,18 @@
           'conditions': [
             ['toolkit_views==1',{
               'sources/': [
+                ['include', '^browser/dock_info_gtk.cc'],
                 ['include', '^browser/dock_info.cc'],
                 ['include', '^browser/dock_info.h'],
+                ['include', '^browser/views/tabs/tab.cc'],
+                ['include', '^browser/views/tabs/tab.h'],
+                ['include', '^browser/views/tabs/tab_renderer.cc'],
+                ['include', '^browser/views/tabs/tab_renderer.h'],
+              ],
+            }],
+            ['toolkit_views==0',{
+              'sources/': [
+                ['exclude', '^browser/dock_info_gtk.cc'],
               ],
             }],
           ],
diff --git a/chrome/common/temp_scaffolding_stubs.h b/chrome/common/temp_scaffolding_stubs.h
index bcf4dca..79ea94d 100644
--- a/chrome/common/temp_scaffolding_stubs.h
+++ b/chrome/common/temp_scaffolding_stubs.h
@@ -247,6 +247,7 @@ class Window {
 class InputWindowDelegate {
 };
 
+#if !defined(TOOLKIT_VIEWS)
 namespace views {
 
 class Menu {
@@ -282,6 +283,7 @@ class Menu {
 };
 
 }  // namespace view
+#endif
 
 class BookmarkManagerView {
  public: