diff options
| author | tim@chromium.org <tim@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-01-09 16:50:14 +0000 |
|---|---|---|
| committer | tim@chromium.org <tim@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-01-09 16:50:14 +0000 |
| commit | 91dfdd8d8f1b173c9c3801bd0351db1245183406 (patch) | |
| tree | 8d009883599999967986da02940e9c5070655468 /chrome | |
| parent | 15f63bc371d62d147ccbc05a877c0dc909f3c045 (diff) | |
| download | chromium_src-91dfdd8d8f1b173c9c3801bd0351db1245183406.zip chromium_src-91dfdd8d8f1b173c9c3801bd0351db1245183406.tar.gz chromium_src-91dfdd8d8f1b173c9c3801bd0351db1245183406.tar.bz2 | |
HtmlDialogView is hard-wired to the gears application shortcut dialogs but it doesn't have to be. The delegates don't need to be strictly gears either, but for now they are only used by gears and this simple change allows re-use of HtmlDialogView + HtmlDialogContents + HtmlDialogContentsDelegate.
Review URL: http://codereview.chromium.org/17441
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7804 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome')
| -rw-r--r-- | chrome/browser/chrome_plugin_host.cc | 1 | ||||
| -rw-r--r-- | chrome/browser/modal_html_dialog_delegate.h | 1 | ||||
| -rw-r--r-- | chrome/browser/views/html_dialog_view.cc | 2 |
3 files changed, 3 insertions, 1 deletions
diff --git a/chrome/browser/chrome_plugin_host.cc b/chrome/browser/chrome_plugin_host.cc index 1c7af93..008a7fe 100644 --- a/chrome/browser/chrome_plugin_host.cc +++ b/chrome/browser/chrome_plugin_host.cc @@ -278,6 +278,7 @@ class ModelessHtmlDialogDelegate : public HtmlDialogContentsDelegate { // views::WindowDelegate implementation: virtual bool IsModal() const { return false; } + virtual std::wstring GetWindowTitle() const { return L"Google Gears"; } // HtmlDialogContentsDelegate implementation: virtual GURL GetDialogContentURL() const { return params_.url; } diff --git a/chrome/browser/modal_html_dialog_delegate.h b/chrome/browser/modal_html_dialog_delegate.h index 34dd0ef..dd5e5d60 100644 --- a/chrome/browser/modal_html_dialog_delegate.h +++ b/chrome/browser/modal_html_dialog_delegate.h @@ -29,6 +29,7 @@ class ModalHtmlDialogDelegate // views::WindowDelegate implementation: virtual bool IsModal() const; + virtual std::wstring GetWindowTitle() const { return L"Google Gears"; } // ModalHtmlDialogContents::ModalHTMLDialogContentsDelegate implementation: virtual GURL GetDialogContentURL() const; diff --git a/chrome/browser/views/html_dialog_view.cc b/chrome/browser/views/html_dialog_view.cc index ea8fd14..58f9efe 100644 --- a/chrome/browser/views/html_dialog_view.cc +++ b/chrome/browser/views/html_dialog_view.cc @@ -46,7 +46,7 @@ bool HtmlDialogView::IsModal() const { } std::wstring HtmlDialogView::GetWindowTitle() const { - return L"Google Gears"; + return delegate_->GetWindowTitle(); } void HtmlDialogView::WindowClosing() { |