summaryrefslogtreecommitdiffstats
path: root/chrome
diff options
context:
space:
mode:
authordank@chromium.org <dank@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-08-05 20:53:17 +0000
committerdank@chromium.org <dank@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-08-05 20:53:17 +0000
commitba15f7a45453eaf4f4c928d0c8a572b48d6f7541 (patch)
tree99472491344dc60badfea5e7add9312c77c8eaf7 /chrome
parent259b08c5bee1c39f333f017f08a8d21d54de40c8 (diff)
downloadchromium_src-ba15f7a45453eaf4f4c928d0c8a572b48d6f7541.zip
chromium_src-ba15f7a45453eaf4f4c928d0c8a572b48d6f7541.tar.gz
chromium_src-ba15f7a45453eaf4f4c928d0c8a572b48d6f7541.tar.bz2
Fishing expedition in mac ui tests.
Adds suppressions for lots of bugs. The only problems left I know of result in valgrind internal error messages. Widen suppression for 16128 to match on Mac. Remove suppression for 16210, which is a dup of 16128, and was out of date. The reference builds don't have symbols on the mac, so suppressions don't work. And they have old known valgrind issues. Disable SunSpiderReferenceTest.Perf and V8BenchmarkReferenceTest.Perf under valgrind until those problems are addressed (and possibly longer -- reference builds tend to have old valgrind errors since fixed and no longer of interest). Also, disable DownloadTest.UnknownSize under valgrind, it is known to send garbage. None of these errors are showing up on the bots for some reason; they only show up when you do a local run of shard_all_tests.sh, which does one test at a time instead of the normal batches of 30. It seems valgrind on the mac isn't stable enough to do large batches of ui tests in a single run. BUG=6522,16128,16210,17113,17451,18189,18223,18236,18252,18253,18268,18540 TEST=run tools/valgrind/shard_all_tests.sh for ui_tests on mac, verify it finds no normal valgrind warnings Review URL: http://codereview.chromium.org/159770 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22533 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome')
-rw-r--r--chrome/test/data/valgrind/ui_tests.gtest.txt6
1 files changed, 6 insertions, 0 deletions
diff --git a/chrome/test/data/valgrind/ui_tests.gtest.txt b/chrome/test/data/valgrind/ui_tests.gtest.txt
index 4605a7e..bbf54cf 100644
--- a/chrome/test/data/valgrind/ui_tests.gtest.txt
+++ b/chrome/test/data/valgrind/ui_tests.gtest.txt
@@ -2,3 +2,9 @@
BrowserTest.ThirtyFourTabs
# FIXME: these tests hang frequently in valgrind
SessionRestoreUITest.*
+# The reference builds have old problems; don't run them until they're updated
+# And on the Mac, they don't have symbols, even, so suppressions don't work
+SunSpiderReferenceTest.Perf
+V8BenchmarkReferenceTest.Perf
+# Buggy test; see http://crbug.com/6522
+DownloadTest.UnknownSize