diff options
author | pinkerton@chromium.org <pinkerton@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-02-27 18:32:54 +0000 |
---|---|---|
committer | pinkerton@chromium.org <pinkerton@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-02-27 18:32:54 +0000 |
commit | cecc80a3e4eff12b20ce8c68b8857e4596a62ec9 (patch) | |
tree | 556503769dbb14c49aa8b5aaf82885c7a070b6ab /chrome | |
parent | 4be9e7e041fa15f090c96e9b446cc3ce48fdbe0f (diff) | |
download | chromium_src-cecc80a3e4eff12b20ce8c68b8857e4596a62ec9.zip chromium_src-cecc80a3e4eff12b20ce8c68b8857e4596a62ec9.tar.gz chromium_src-cecc80a3e4eff12b20ce8c68b8857e4596a62ec9.tar.bz2 |
Remove a few more NOTIMPLEMENTED methods.
Review URL: http://codereview.chromium.org/28263
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10616 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome')
-rw-r--r-- | chrome/browser/cocoa/browser_window_cocoa.mm | 3 | ||||
-rw-r--r-- | chrome/common/temp_scaffolding_stubs.cc | 9 | ||||
-rw-r--r-- | chrome/common/temp_scaffolding_stubs.h | 6 |
3 files changed, 15 insertions, 3 deletions
diff --git a/chrome/browser/cocoa/browser_window_cocoa.mm b/chrome/browser/cocoa/browser_window_cocoa.mm index 6af331b..554619a 100644 --- a/chrome/browser/cocoa/browser_window_cocoa.mm +++ b/chrome/browser/cocoa/browser_window_cocoa.mm @@ -65,7 +65,8 @@ void BrowserWindowCocoa::SelectedTabToolbarSizeChanged(bool is_animating) { } void BrowserWindowCocoa::UpdateTitleBar() { - NOTIMPLEMENTED(); + // This is used on windows to update the favicon and title in the window + // icon, which we don't use on the mac. } void BrowserWindowCocoa::UpdateLoadingAnimations(bool should_animate) { diff --git a/chrome/common/temp_scaffolding_stubs.cc b/chrome/common/temp_scaffolding_stubs.cc index d43bb4f..9aeda0f 100644 --- a/chrome/common/temp_scaffolding_stubs.cc +++ b/chrome/common/temp_scaffolding_stubs.cc @@ -351,6 +351,15 @@ void TabContents::UpdateMaxPageID(int32 page_id) { max_page_id_ = std::max(max_page_id_, page_id); } +void TabContents::SetIsCrashed(bool state) { + if (state == is_crashed_) + return; + + is_crashed_ = state; + if (delegate_) + delegate_->ContentsStateChanged(this); +} + //-------------------------------------------------------------------------- void RLZTracker::CleanupRlz() { diff --git a/chrome/common/temp_scaffolding_stubs.h b/chrome/common/temp_scaffolding_stubs.h index add5e75..e280f9e 100644 --- a/chrome/common/temp_scaffolding_stubs.h +++ b/chrome/common/temp_scaffolding_stubs.h @@ -422,7 +422,7 @@ class TabContents : public PageNavigator, public NotificationObserver { INVALIDATE_EVERYTHING = 0xFFFFFFFF }; TabContents(TabContentsType type) - : type_(type), is_active_(true), is_loading_(false), + : type_(type), is_crashed_(false), is_active_(true), is_loading_(false), is_being_destroyed_(false), controller_(), delegate_(), max_page_id_(-1) { } virtual ~TabContents() { } @@ -458,7 +458,8 @@ class TabContents : public PageNavigator, public NotificationObserver { virtual void SetDownloadShelfVisible(bool) { NOTIMPLEMENTED(); } virtual void Destroy(); virtual void SetIsLoading(bool, LoadNotificationDetails*); - virtual void SetIsCrashed(bool) { NOTIMPLEMENTED(); } + bool is_crashed() const { return is_crashed_; } + virtual void SetIsCrashed(bool); bool capturing_contents() const { NOTIMPLEMENTED(); return false; @@ -507,6 +508,7 @@ class TabContents : public PageNavigator, public NotificationObserver { friend class AutomationProvider; TabContentsType type_; + bool is_crashed_; bool is_active_; bool is_loading_; bool is_being_destroyed_; |