diff options
| author | rkc@chromium.org <rkc@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-10-08 00:00:44 +0000 |
|---|---|---|
| committer | rkc@chromium.org <rkc@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-10-08 00:00:44 +0000 |
| commit | cf90a518555b24d7af6205ec264db297e104e53d (patch) | |
| tree | c76d3539514fdaddc5e106a5e4236d85424c94ba /chrome | |
| parent | 5a3925d795c6f1072b56ad20c675d3da6f6309ab (diff) | |
| download | chromium_src-cf90a518555b24d7af6205ec264db297e104e53d.zip chromium_src-cf90a518555b24d7af6205ec264db297e104e53d.tar.gz chromium_src-cf90a518555b24d7af6205ec264db297e104e53d.tar.bz2 | |
Implement disable_pie for all executables.
On setting disable_pie=1 would only build Chrome with the PIE flag disabled. This helped debugging Chrome but browser_tests, ui_tests and other tests + executables were still built with PIE making remote debugging them not possible.
Now when disable_pie=1 is specified, all executables will be built non-PIE.
R=zelidrag@chromium.org,thakis@chromium.org
BUG=None.
TEST=Tested with a complete build. Only and all executables are being linked with '-nopie' with disable_pie=1 specified.
Review URL: http://codereview.chromium.org/8207010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104609 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome')
| -rw-r--r-- | chrome/chrome_exe.gypi | 8 |
1 files changed, 2 insertions, 6 deletions
diff --git a/chrome/chrome_exe.gypi b/chrome/chrome_exe.gypi index 9eb8551..46d1553 100644 --- a/chrome/chrome_exe.gypi +++ b/chrome/chrome_exe.gypi @@ -10,7 +10,6 @@ 'mac_bundle': 1, 'variables': { 'use_system_xdg_utils%': 0, - 'disable_pie%': 0, }, 'sources': [ 'app/breakpad_win.cc', @@ -86,11 +85,8 @@ ], }, ], - # TODO(rkc): Remove disable_pie (and instead always use - # -pie) once we have a fix for remote gdb and are able to - # correctly get section header offsets for pie - # executables. Currently -pie breaks remote debugging. - ['profiling==1 or disable_pie==1', { + # TODO(rkc): Remove once crosbug.com/15266 is fixed. + ['profiling==1', { 'ldflags': ['-nopie'], }, { # Building with -pie needs investigating on ARM. |