diff options
| author | mirandac@chromium.org <mirandac@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-03-26 15:53:55 +0000 |
|---|---|---|
| committer | mirandac@chromium.org <mirandac@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-03-26 15:53:55 +0000 |
| commit | fdeb7ac65e407aa5334b6f5308f15be3dae70dd6 (patch) | |
| tree | 5e7403d9e1b76ed2cf66739816e34d52d745ee9a /chrome | |
| parent | b364f9e7b87fb8e1fbd015b9942274026a4e0f66 (diff) | |
| download | chromium_src-fdeb7ac65e407aa5334b6f5308f15be3dae70dd6.zip chromium_src-fdeb7ac65e407aa5334b6f5308f15be3dae70dd6.tar.gz chromium_src-fdeb7ac65e407aa5334b6f5308f15be3dae70dd6.tar.bz2 | |
Fix crasher in LocationBarViewMac::PageActionImageView::OnImageLoaded.
Scott's insight in comment 18 on the bug report was correct; fixed by relinquishing control on call to UpdatePageActions, so that we don't try to look at the private variables of a dying this ptr.
BUG= 35864
TEST= no crash.
Review URL: http://codereview.chromium.org/1397001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42764 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome')
| -rw-r--r-- | chrome/browser/cocoa/location_bar_view_mac.mm | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/chrome/browser/cocoa/location_bar_view_mac.mm b/chrome/browser/cocoa/location_bar_view_mac.mm index ee795b8..0035101 100644 --- a/chrome/browser/cocoa/location_bar_view_mac.mm +++ b/chrome/browser/cocoa/location_bar_view_mac.mm @@ -187,6 +187,7 @@ void LocationBarViewMac::UpdatePageActions() { Source<LocationBar>(this), NotificationService::NoDetails()); } + [field_ setNeedsDisplay:YES]; } void LocationBarViewMac::InvalidatePageActions() { @@ -699,9 +700,6 @@ void LocationBarViewMac::PageActionImageView::OnImageLoaded( } owner_->UpdatePageActions(); - - if (preview_enabled_) - [owner_->GetAutocompleteTextField() display]; } void LocationBarViewMac::PageActionImageView::UpdateVisibility( |