Relanding Coverity fixes from http://codereview.chromium.org/159862 excluding the broken ones.

The change of GURL -> const GURL& caused some nasty crash and the change got reverted.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/164095

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22682 0039d316-1c4b-4281-b951-d872f2087c98

3 files changed, 3 insertions, 3 deletions

diff --git a/chrome/common/child_thread.cc b/chrome/common/child_thread.cc
index 9168570..8e9e90c 100644
--- a/chrome/common/child_thread.cc
+++ b/chrome/common/child_thread.cc
@@ -22,7 +22,7 @@ ChildThread::ChildThread() {
   Init();
 }
 
-ChildThread::ChildThread(const std::string channel_name)
+ChildThread::ChildThread(const std::string& channel_name)
     : channel_name_(channel_name) {
   Init();
 }
diff --git a/chrome/common/child_thread.h b/chrome/common/child_thread.h
index 91ea9b7..afcd803 100644
--- a/chrome/common/child_thread.h
+++ b/chrome/common/child_thread.h
@@ -20,7 +20,7 @@ class ChildThread : public IPC::Channel::Listener,
   // Creates the thread.
   ChildThread();
   // Used for single-process mode.
-  ChildThread(const std::string channel_name);
+  ChildThread(const std::string& channel_name);
   virtual ~ChildThread();
 
   // IPC::Message::Sender implementation:
diff --git a/chrome/test/automation/automation_proxy_uitest.cc b/chrome/test/automation/automation_proxy_uitest.cc
index 75395af..c67c1f7 100644
--- a/chrome/test/automation/automation_proxy_uitest.cc
+++ b/chrome/test/automation/automation_proxy_uitest.cc
@@ -829,7 +829,7 @@ TEST_F(ExternalTabTestType, IncognitoMode) {
   tab = NULL;
   CloseBrowserAndServer();
 
-  value_result.empty();
+  value_result.clear();
   clear_profile_ = false;
   external_tab_container = NULL;
   tab_wnd = NULL;