diff options
author | csharp@chromium.org <csharp@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-01-24 21:38:34 +0000 |
---|---|---|
committer | csharp@chromium.org <csharp@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-01-24 21:38:34 +0000 |
commit | 677b9fdb680482fc92cd90db87b37262309cb54c (patch) | |
tree | 599fde8c3e3e76814d9855302f4b0f44bb226e1b /chrome_elf | |
parent | 1d8155427b2f30c16b3b948f143c058551eebc8e (diff) | |
download | chromium_src-677b9fdb680482fc92cd90db87b37262309cb54c.zip chromium_src-677b9fdb680482fc92cd90db87b37262309cb54c.tar.gz chromium_src-677b9fdb680482fc92cd90db87b37262309cb54c.tar.bz2 |
Add logs to chrome_elf_unittests to ensure the correct target is built.
If users just build chrome_elf_unittests.exe, a few tests will fail due
to missing dependencies. Tell the user to build chrome_elf_unittests
instead if they encounter these failures.
BUG=
Review URL: https://codereview.chromium.org/145053002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246975 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome_elf')
-rw-r--r-- | chrome_elf/elf_imports_unittest.cc | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/chrome_elf/elf_imports_unittest.cc b/chrome_elf/elf_imports_unittest.cc index 3e9b4f9..5833b1f 100644 --- a/chrome_elf/elf_imports_unittest.cc +++ b/chrome_elf/elf_imports_unittest.cc @@ -55,7 +55,8 @@ TEST_F(ELFImportsTest, ChromeElfSanityCheck) { GetImports(dll, &elf_imports); // Check that ELF has imports. - ASSERT_LT(0u, elf_imports.size()); + ASSERT_LT(0u, elf_imports.size()) << "Ensure the chrome_elf_unittests " + "target was built, instead of chrome_elf_unittests.exe"; std::vector<std::string>::iterator it(elf_imports.begin()); @@ -93,11 +94,13 @@ TEST_F(ELFImportsTest, MAYBE_ChromeExeSanityCheck) { GetImports(exe, &exe_imports); // Check that chrome.exe has imports. - ASSERT_LT(0u, exe_imports.size()); + ASSERT_LT(0u, exe_imports.size()) << "Ensure the chrome_elf_unittests " + "target was built, instead of chrome_elf_unittests.exe"; // Chrome.exe's first import must be ELF. EXPECT_EQ("chrome_elf.dll", exe_imports[0]) << - "Illegal import order in chrome.exe"; + "Illegal import order in chrome.exe (ensure the chrome_elf_unittest " + "target was built, instead of just chrome_elf_unittests.exe)"; } } // namespace |