summaryrefslogtreecommitdiffstats
path: root/chrome_frame/bho.h
diff options
context:
space:
mode:
authorericu@google.com <ericu@google.com@0039d316-1c4b-4281-b951-d872f2087c98>2010-03-12 20:50:11 +0000
committerericu@google.com <ericu@google.com@0039d316-1c4b-4281-b951-d872f2087c98>2010-03-12 20:50:11 +0000
commit502415277b63821cc18422e177b73de41985bec6 (patch)
tree9625e2de0cef611528ee73b2f8d43c1a58245e7f /chrome_frame/bho.h
parent15d8edb4918b3729fc72200f5c19a67409fc0180 (diff)
downloadchromium_src-502415277b63821cc18422e177b73de41985bec6.zip
chromium_src-502415277b63821cc18422e177b73de41985bec6.tar.gz
chromium_src-502415277b63821cc18422e177b73de41985bec6.tar.bz2
Reverting due to two broken tests: FullTabModeIE_SubIFram and FullTabModeIE_UnloadEventTest.
Revert 41463 - When ChromeFrame switches to IE on receiving the OnHttpEquiv notification indicating the presence of a meta tag indicating that the page is to be rendered in Chrome, we check if the notification is received for a site rendered in an IFrame to ensure that we don't switch in this case. This code is not reliable and we end up assuming that a top level navigation is actually an embedded frame. To work around this we now maintain a pending navigation count in BeforeNavigate2, which is decremented in NavigateComplete2 and NavigateError. We perform the check for an embedded document only if the pending navigation count is greater than 1. This fixes http://code.google.com/p/chromium/issues/detail?id=36825 The other change made is to add a delay of 100ms in SendString between each character to better reflect actual timing for real user input. Bug=36825 Review URL: http://codereview.chromium.org/837008 TBR=ananta@chromium.org Review URL: http://codereview.chromium.org/877009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41477 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome_frame/bho.h')
-rw-r--r--chrome_frame/bho.h23
1 files changed, 0 insertions, 23 deletions
diff --git a/chrome_frame/bho.h b/chrome_frame/bho.h
index 5992746..c82f000 100644
--- a/chrome_frame/bho.h
+++ b/chrome_frame/bho.h
@@ -64,10 +64,6 @@ END_COM_MAP()
BEGIN_SINK_MAP(Bho)
SINK_ENTRY_INFO(0, DIID_DWebBrowserEvents2, DISPID_BEFORENAVIGATE2,
BeforeNavigate2, &kBeforeNavigate2Info)
- SINK_ENTRY_INFO(0, DIID_DWebBrowserEvents2, DISPID_NAVIGATECOMPLETE2,
- NavigateComplete2, &kNavigateComplete2Info)
- SINK_ENTRY_INFO(0, DIID_DWebBrowserEvents2, DISPID_NAVIGATEERROR,
- OnNavigateError, &kNavigateErrorInfo)
END_SINK_MAP()
// Lifetime management methods
@@ -78,17 +74,10 @@ END_SINK_MAP()
// IObjectWithSite
STDMETHODIMP SetSite(IUnknown* site);
-
STDMETHOD(BeforeNavigate2)(IDispatch* dispatch, VARIANT* url, VARIANT* flags,
VARIANT* target_frame_name, VARIANT* post_data, VARIANT* headers,
VARIANT_BOOL* cancel);
- STDMETHOD_(void, NavigateComplete2)(IDispatch* dispatch, VARIANT* url);
-
- STDMETHOD_(void, OnNavigateError)(IDispatch* dispatch, VARIANT* url,
- VARIANT* frame_name, VARIANT* status_code,
- VARIANT* cancel);
-
HRESULT NavigateToCurrentUrlInCF(IBrowserService* browser);
// mshtml sends an IOleCommandTarget::Exec of OLECMDID_HTTPEQUIV
@@ -124,10 +113,6 @@ END_SINK_MAP()
static void ProcessOptInUrls(IWebBrowser2* browser, BSTR url);
- int pending_navigation_count() const {
- return pending_navigation_count_;
- }
-
protected:
bool PatchProtocolHandler(const CLSID& handler_clsid);
@@ -137,14 +122,6 @@ END_SINK_MAP()
static base::LazyInstance<base::ThreadLocalPointer<Bho> >
bho_current_thread_instance_;
static _ATL_FUNC_INFO kBeforeNavigate2Info;
- static _ATL_FUNC_INFO kNavigateComplete2Info;
- static _ATL_FUNC_INFO kNavigateErrorInfo;
-
- // This variable holds the pending navigation count seen by the BHO. It is
- // incremented in BeforeNavigate2 and decremented in NavigateComplete2.
- // Used to determine whether there are embedded frames loading for the
- // current document.
- int pending_navigation_count_;
};
#endif // CHROME_FRAME_BHO_H_