diff options
| author | ananta@chromium.org <ananta@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-02-28 22:18:33 +0000 |
|---|---|---|
| committer | ananta@chromium.org <ananta@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-02-28 22:18:33 +0000 |
| commit | f4fbae68a3fbdea8d14af164ddaa5986b4eefd6c (patch) | |
| tree | f89c5ee0329d5ab17ad0281ff45589f4cb1e3940 /chrome_frame/bind_context_info.cc | |
| parent | 1d9104aa2450fd4dd21cfb2e1a73ddc0e0613f50 (diff) | |
| download | chromium_src-f4fbae68a3fbdea8d14af164ddaa5986b4eefd6c.zip chromium_src-f4fbae68a3fbdea8d14af164ddaa5986b4eefd6c.tar.gz chromium_src-f4fbae68a3fbdea8d14af164ddaa5986b4eefd6c.tar.bz2 | |
Download requests in ChromeFrame which occur in response to a POST request need to pass
the post data as well while reissuing the navigation. This ensures that a POST request is
correctly sent out at all times instead of a GET request. While the assumption is that reusing
the bind context would achieve this behavior, it does not appear to be true at all times.
While fixing this I also found that reissuing a navigation via a NavigateWithBindCtx call
causes the current chrome frame document to receive an Unload call at times, leading to
the page being rendered useless after the request finishes. We should reissue the navigation
on a new window to work around this problem.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=73985
BUG=73985
TEST=As described in the bug.
Review URL: http://codereview.chromium.org/6598016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76282 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome_frame/bind_context_info.cc')
| -rw-r--r-- | chrome_frame/bind_context_info.cc | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/chrome_frame/bind_context_info.cc b/chrome_frame/bind_context_info.cc index 28cb239..89d6991 100644 --- a/chrome_frame/bind_context_info.cc +++ b/chrome_frame/bind_context_info.cc @@ -45,7 +45,6 @@ HRESULT BindContextInfo::FromBindContext(IBindCtx* bind_context, if (context) { ScopedComPtr<IBindContextInfoInternal> internal; hr = internal.QueryFrom(context); - DCHECK(SUCCEEDED(hr)); if (SUCCEEDED(hr)) { hr = internal->GetCppObject(reinterpret_cast<void**>(info)); DCHECK_EQ(hr, S_OK); |