diff options
author | ananta@chromium.org <ananta@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-11-05 18:50:31 +0000 |
---|---|---|
committer | ananta@chromium.org <ananta@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-11-05 18:50:31 +0000 |
commit | d118f54157b7a2cd0b76ff4c59027ae67024e438 (patch) | |
tree | f615fcefc7289662c28b4ba6d90bf0f449d6d364 /chrome_frame/chrome_active_document.cc | |
parent | 222d11e382022d51bfc4ec560ae3d9f2b7fdb2e5 (diff) | |
download | chromium_src-d118f54157b7a2cd0b76ff4c59027ae67024e438.zip chromium_src-d118f54157b7a2cd0b76ff4c59027ae67024e438.tar.gz chromium_src-d118f54157b7a2cd0b76ff4c59027ae67024e438.tar.bz2 |
Back forward transitions would not work within ChromeFrame when attempted via the context menu.
This was because the Back and Forward menu items on the context menu were disabled. The context
menu is displayed by the active document in IE and it attempts to enable/disable these items
based on entries in the IE travel log. The enabling of these items was failing as we were
incorrectly passing in the string id of these options instead of their command id equivalents
Should fix bug http://code.google.com/p/chromium/issues/detail?id=34657
Bug=34657
Test=Covered by new ChromeFrame context menu back forward test.
Review URL: http://codereview.chromium.org/4500002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65231 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome_frame/chrome_active_document.cc')
-rw-r--r-- | chrome_frame/chrome_active_document.cc | 11 |
1 files changed, 6 insertions, 5 deletions
diff --git a/chrome_frame/chrome_active_document.cc b/chrome_frame/chrome_active_document.cc index 9dfe739..979d9d7 100644 --- a/chrome_frame/chrome_active_document.cc +++ b/chrome_frame/chrome_active_document.cc @@ -958,13 +958,14 @@ bool ChromeActiveDocument::PreProcessContextMenu(HMENU menu) { if (!browser_service || !travel_log) return true; - EnableMenuItem(menu, IDS_CONTENT_CONTEXT_BACK, MF_BYCOMMAND | - (SUCCEEDED(travel_log->GetTravelEntry(browser_service, TLOG_BACK, NULL)) ? + EnableMenuItem(menu, IDC_BACK, MF_BYCOMMAND | + (SUCCEEDED(travel_log->GetTravelEntry(browser_service, TLOG_BACK, + NULL)) ? MF_ENABLED : MF_DISABLED)); - EnableMenuItem(menu, IDS_CONTENT_CONTEXT_FORWARD, MF_BYCOMMAND | - (SUCCEEDED(travel_log->GetTravelEntry(browser_service, TLOG_FORE, NULL)) ? + EnableMenuItem(menu, IDC_FORWARD, MF_BYCOMMAND | + (SUCCEEDED(travel_log->GetTravelEntry(browser_service, TLOG_FORE, + NULL)) ? MF_ENABLED : MF_DISABLED)); - // Call base class (adds 'About' item) return BaseActiveX::PreProcessContextMenu(menu); } |