diff options
| author | ananta@chromium.org <ananta@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-06-17 01:19:04 +0000 |
|---|---|---|
| committer | ananta@chromium.org <ananta@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-06-17 01:19:04 +0000 |
| commit | e3a91e7d2cb359692c59b86a29453f1931f87760 (patch) | |
| tree | 83d18e33d0041e888e580dee0e81b15cf3d490fc /chrome_frame/chrome_active_document.h | |
| parent | 584245e578427abc2bc19f224609f820ad71aca0 (diff) | |
| download | chromium_src-e3a91e7d2cb359692c59b86a29453f1931f87760.zip chromium_src-e3a91e7d2cb359692c59b86a29453f1931f87760.tar.gz chromium_src-e3a91e7d2cb359692c59b86a29453f1931f87760.tar.bz2 | |
window.open calls issued by pages within ChromeFrame would not honor the suggested dimensions and would end up
opening a default top level browser window in IE.
ChromeFrame does receive the dimensions from the external tab container when it is notified about a popup being
opened.
Fix is to honor these dimensions by passing them off in the specially crafted url containing other arguments.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=42250
This fix is currently implemented for IE full tab mode only.
Bug=42250
Test=Covered by augmenting the existing window open test to also validate the window size. Added a new unit test
to test the ParseAttachExternalTabUrl helper function.
Review URL: http://codereview.chromium.org/2867007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50064 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome_frame/chrome_active_document.h')
| -rw-r--r-- | chrome_frame/chrome_active_document.h | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/chrome_frame/chrome_active_document.h b/chrome_frame/chrome_active_document.h index 5c3d8fb..977ed90 100644 --- a/chrome_frame/chrome_active_document.h +++ b/chrome_frame/chrome_active_document.h @@ -454,6 +454,10 @@ END_EXEC_COMMAND_MAP() UrlmonUrlRequestManager::PrivacyInfo::PrivacyRecords::iterator next_privacy_record_; + // Dimensions of the window. Used only when opening popups. + gfx::Rect dimensions_; + // Set to true if the document was loaded by a window.open in chrome. + bool is_new_navigation_; public: ScopedComPtr<IOleInPlaceFrame> in_place_frame_; OLEINPLACEFRAMEINFO frame_info_; |