diff options
| author | ananta@chromium.org <ananta@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-05-02 14:47:14 +0000 |
|---|---|---|
| committer | ananta@chromium.org <ananta@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-05-02 14:47:14 +0000 |
| commit | ca982ec4920857adf2d22a5a92cc54829718d805 (patch) | |
| tree | 36664a2941699fdbd6655075ea1818e73c2b752e /chrome_frame/chrome_frame_activex.h | |
| parent | 84ae53dda0bc194ca7dda812bd5d5b535e4afaab (diff) | |
| download | chromium_src-ca982ec4920857adf2d22a5a92cc54829718d805.zip chromium_src-ca982ec4920857adf2d22a5a92cc54829718d805.tar.gz chromium_src-ca982ec4920857adf2d22a5a92cc54829718d805.tar.bz2 | |
Fixes to address code review comments from tommi from CL http://codereview.chromium.org/1823001/show
Changes include the following:-
1. Removing the IObjectWithSite::SetSite implementation from the chrome frame activex.
2. Removing the site_ member and using the ATL m_spUnkSite member.
3. Renaming the RegisterBHOIfNeeded member function to registerBhoIfNeeded to be consistent with the
other methods in the IChromeFrame interface.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=42790
Bug=42790
TBR=tommi
Review URL: http://codereview.chromium.org/1831001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46200 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome_frame/chrome_frame_activex.h')
| -rw-r--r-- | chrome_frame/chrome_frame_activex.h | 7 |
1 files changed, 1 insertions, 6 deletions
diff --git a/chrome_frame/chrome_frame_activex.h b/chrome_frame/chrome_frame_activex.h index 7192126..ffe7880 100644 --- a/chrome_frame/chrome_frame_activex.h +++ b/chrome_frame/chrome_frame_activex.h @@ -85,14 +85,11 @@ END_MSG_MAP() // Overridden to perform security checks. STDMETHOD(put_src)(BSTR src); - // IObjectWithSite - STDMETHOD(SetSite)(IUnknown* site); - // IChromeFrame // On a fresh install of ChromeFrame the BHO will not be loaded in existing // IE tabs/windows. This function instantiates the BHO and registers it // explicitly. - STDMETHOD(RegisterBHOIfNeeded)(); + STDMETHOD(registerBhoIfNeeded)(); protected: // ChromeFrameDelegate overrides @@ -149,8 +146,6 @@ END_MSG_MAP() // A hook attached to the top-level window containing the ActiveX control. HHOOK chrome_wndproc_hook_; - - ScopedComPtr<IUnknown> site_; }; #endif // CHROME_FRAME_CHROME_FRAME_ACTIVEX_H_ |