diff options
author | ananta@chromium.org <ananta@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-12-03 21:32:19 +0000 |
---|---|---|
committer | ananta@chromium.org <ananta@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-12-03 21:32:19 +0000 |
commit | 3eb8a7049a1678c35845c10e95ecc4bf303b59e2 (patch) | |
tree | ac63296aaca85259b015036af4d34acccbb62ea1 /chrome_frame/chrome_frame_activex_base.h | |
parent | 2d8099cf56475b6989911ea8e573cbeb26724f3d (diff) | |
download | chromium_src-3eb8a7049a1678c35845c10e95ecc4bf303b59e2.zip chromium_src-3eb8a7049a1678c35845c10e95ecc4bf303b59e2.tar.gz chromium_src-3eb8a7049a1678c35845c10e95ecc4bf303b59e2.tar.bz2 |
Refreshing a ChromeFrame page which was received in response to a top level POST to a page
in IE should reissue the POST request after bringing up a confirmation dialog.
This CL adds support to ChromeFrame to achieve this. Ideally we would want IE to display
the confirmation dialog for the POST. However the doc object host which is implemented by
IEFrame expects the doc object to implement the IHTMLDocument interface and a bunch of private
interfaces.
To reissue the POST request we save away the POST data and headers in the navigation manager
instance which is per BHO. When we refresh the page in ChromeFrame the active document on
seeing that we have posted data issues a navigation back to the URL with the posted data
and saved headers. All other refreshes continue to work the same way as before, i.e. the
refresh request is sent to Chrome on the automation channel. The confirmation dialog is
put up by the active document with the same text and caption as that in Chrome.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=64901
BUG=64901
TEST=Covered by new ChromeFrame unit test
Review URL: http://codereview.chromium.org/5595002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68213 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome_frame/chrome_frame_activex_base.h')
-rw-r--r-- | chrome_frame/chrome_frame_activex_base.h | 11 |
1 files changed, 2 insertions, 9 deletions
diff --git a/chrome_frame/chrome_frame_activex_base.h b/chrome_frame/chrome_frame_activex_base.h index 1dd2755..c7dd5cf 100644 --- a/chrome_frame/chrome_frame_activex_base.h +++ b/chrome_frame/chrome_frame_activex_base.h @@ -251,17 +251,12 @@ END_MSG_MAP() DECLARE_PROTECT_FINAL_CONSTRUCT() - virtual void SetResourceModule() { + void SetResourceModule() { DCHECK(NULL == prev_resource_instance_); SimpleResourceLoader* loader_instance = SimpleResourceLoader::instance(); DCHECK(loader_instance); HMODULE res_dll = loader_instance->GetResourceModuleHandle(); - prev_resource_instance_ = _AtlBaseModule.SetResourceInstance(res_dll); - } - - virtual void ClearResourceModule() { - _AtlBaseModule.SetResourceInstance(prev_resource_instance_); - prev_resource_instance_ = NULL; + _AtlBaseModule.SetResourceInstance(res_dll); } HRESULT FinalConstruct() { @@ -286,8 +281,6 @@ END_MSG_MAP() void FinalRelease() { Uninitialize(); - - ClearResourceModule(); } void ResetUrlRequestManager() { |