diff options
author | ananta@chromium.org <ananta@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-10-19 17:34:57 +0000 |
---|---|---|
committer | ananta@chromium.org <ananta@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-10-19 17:34:57 +0000 |
commit | b36a9f99e21193b08a58336a1a974893ac46a31a (patch) | |
tree | eb3c80709ae56c234454fe7388fe32f54a2ce1b5 /chrome_frame/chrome_frame_automation.cc | |
parent | 5779bad3e1753ca61a0de9fa28ce44df63f08579 (diff) | |
download | chromium_src-b36a9f99e21193b08a58336a1a974893ac46a31a.zip chromium_src-b36a9f99e21193b08a58336a1a974893ac46a31a.tar.gz chromium_src-b36a9f99e21193b08a58336a1a974893ac46a31a.tar.bz2 |
When Chrome hands off a URL to be opened by the external host by the ViewHostMsg_OpenURL IPC, it
needs to pass the referrer as well. The Chrome fixes in this CL are mostly related to passing the
HTTP referer off to the browser and from there to the ExternalTabContainer to ChromeFrame and back.
The ChromeFrame changes are basically around the same lines with one exception. When we handle the
AutomationMsg_OpenURL IPC in the activex and the active document we pass the referer if applicable
to the WebBrowser2::Navigate2 interface, which is then read by the BHO in BeforeNavigate2. We then
save away an AddRef'ed BHO pointer in TLS which is then referenced by the Active document for reading
the referer and passing it off to Chrome in the NavigateInExternalTab message.
Added a unit test in ChromeFrame which tests this case.
This fixes http://code.google.com/p/chromium/issues/detail?id=22994
Bug=22994
Review URL: http://codereview.chromium.org/274071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29420 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome_frame/chrome_frame_automation.cc')
-rw-r--r-- | chrome_frame/chrome_frame_automation.cc | 12 |
1 files changed, 7 insertions, 5 deletions
diff --git a/chrome_frame/chrome_frame_automation.cc b/chrome_frame/chrome_frame_automation.cc index 104f2c3..7793f1a 100644 --- a/chrome_frame/chrome_frame_automation.cc +++ b/chrome_frame/chrome_frame_automation.cc @@ -483,8 +483,8 @@ void ChromeFrameAutomationClient::Uninitialize() { init_state_ = UNINITIALIZED; } -bool ChromeFrameAutomationClient::InitiateNavigation(const std::string& url, - bool is_privileged) { +bool ChromeFrameAutomationClient::InitiateNavigation( + const std::string& url, const std::string& referrer, bool is_privileged) { if (url.empty()) return false; @@ -498,7 +498,7 @@ bool ChromeFrameAutomationClient::InitiateNavigation(const std::string& url, } if (is_initialized()) { - BeginNavigate(GURL(url)); + BeginNavigate(GURL(url), GURL(referrer)); } return true; @@ -538,7 +538,8 @@ bool ChromeFrameAutomationClient::SetProxySettings( return true; } -void ChromeFrameAutomationClient::BeginNavigate(const GURL& url) { +void ChromeFrameAutomationClient::BeginNavigate(const GURL& url, + const GURL& referrer) { // Could be NULL if we failed to launch Chrome in LaunchAutomationServer() if (!automation_server_ || !tab_.get()) { DLOG(WARNING) << "BeginNavigate - can't navigate."; @@ -554,7 +555,8 @@ void ChromeFrameAutomationClient::BeginNavigate(const GURL& url) { } IPC::SyncMessage* msg = - new AutomationMsg_NavigateInExternalTab(0, tab_->handle(), url, NULL); + new AutomationMsg_NavigateInExternalTab(0, tab_->handle(), url, + referrer, NULL); automation_server_->SendAsAsync(msg, NewCallback(this, &ChromeFrameAutomationClient::BeginNavigateCompleted), this); |