summaryrefslogtreecommitdiffstats
path: root/chrome_frame/chrome_frame_automation.cc
diff options
context:
space:
mode:
authorgrt@chromium.org <grt@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-04-06 18:41:15 +0000
committergrt@chromium.org <grt@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-04-06 18:41:15 +0000
commit92c79d30b2d16cadd448c7cfd702f3ebd4e10bf5 (patch)
tree07ae765fb06593881920926459c339830d2fb339 /chrome_frame/chrome_frame_automation.cc
parent1baff834aaaadbcc16c340542da9dd0c8c1ad724 (diff)
downloadchromium_src-92c79d30b2d16cadd448c7cfd702f3ebd4e10bf5.zip
chromium_src-92c79d30b2d16cadd448c7cfd702f3ebd4e10bf5.tar.gz
chromium_src-92c79d30b2d16cadd448c7cfd702f3ebd4e10bf5.tar.bz2
Remove locked histogram macros since jar@chromium.org made the base macros threadsafe in http://crrev.com/80412.
BUG=none TEST=metrics should work as before Review URL: http://codereview.chromium.org/6800008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80668 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome_frame/chrome_frame_automation.cc')
-rw-r--r--chrome_frame/chrome_frame_automation.cc29
1 files changed, 11 insertions, 18 deletions
diff --git a/chrome_frame/chrome_frame_automation.cc b/chrome_frame/chrome_frame_automation.cc
index d3626eb..6024972 100644
--- a/chrome_frame/chrome_frame_automation.cc
+++ b/chrome_frame/chrome_frame_automation.cc
@@ -42,11 +42,6 @@ int kDefaultSendUMADataInterval = 20000; // in milliseconds.
static const wchar_t kUmaSendIntervalValue[] = L"UmaSendInterval";
-// This lock ensures that histograms created by ChromeFrame are thread safe.
-// The histograms created in ChromeFrame can be initialized on multiple
-// threads.
-base::Lock g_ChromeFrameHistogramLock;
-
class ChromeFrameAutomationProxyImpl::TabProxyNotificationMessageFilter
: public IPC::ChannelProxy::MessageFilter {
public:
@@ -191,8 +186,7 @@ struct LaunchTimeStats {
void Dump() {
base::TimeDelta launch_time = base::Time::Now() - launch_time_begin_;
- THREAD_SAFE_UMA_HISTOGRAM_TIMES("ChromeFrame.AutomationServerLaunchTime",
- launch_time);
+ UMA_HISTOGRAM_TIMES("ChromeFrame.AutomationServerLaunchTime", launch_time);
const int64 launch_milliseconds = launch_time.InMilliseconds();
if (launch_milliseconds > kAutomationServerReasonableLaunchDelay) {
LOG(WARNING) << "Automation server launch took longer than expected: " <<
@@ -346,18 +340,18 @@ void AutomationProxyCacheEntry::CreateProxy(ChromeFrameLaunchParams* params,
base::TimeTicks::Now() - automation_server_launch_start_time_;
if (launch_result_ == AUTOMATION_SUCCESS) {
- THREAD_SAFE_UMA_HISTOGRAM_TIMES(
+ UMA_HISTOGRAM_TIMES(
"ChromeFrame.AutomationServerLaunchSuccessTime", delta);
} else {
- THREAD_SAFE_UMA_HISTOGRAM_TIMES(
+ UMA_HISTOGRAM_TIMES(
"ChromeFrame.AutomationServerLaunchFailedTime", delta);
}
- THREAD_SAFE_UMA_HISTOGRAM_CUSTOM_COUNTS("ChromeFrame.LaunchResult",
- launch_result_,
- AUTOMATION_SUCCESS,
- AUTOMATION_CREATE_TAB_FAILED,
- AUTOMATION_CREATE_TAB_FAILED + 1);
+ UMA_HISTOGRAM_CUSTOM_COUNTS("ChromeFrame.LaunchResult",
+ launch_result_,
+ AUTOMATION_SUCCESS,
+ AUTOMATION_CREATE_TAB_FAILED,
+ AUTOMATION_CREATE_TAB_FAILED + 1);
}
TRACE_EVENT_END("chromeframe.createproxy", this, "");
@@ -873,12 +867,11 @@ void ChromeFrameAutomationClient::CreateExternalTab() {
!chrome_launch_params_->widget_mode(),
chrome_launch_params_->route_all_top_level_navigations());
- THREAD_SAFE_UMA_HISTOGRAM_CUSTOM_COUNTS(
+ UMA_HISTOGRAM_CUSTOM_COUNTS(
"ChromeFrame.HostNetworking", !use_chrome_network_, 0, 1, 2);
- THREAD_SAFE_UMA_HISTOGRAM_CUSTOM_COUNTS(
- "ChromeFrame.HandleTopLevelRequests", handle_top_level_requests_, 0, 1,
- 2);
+ UMA_HISTOGRAM_CUSTOM_COUNTS("ChromeFrame.HandleTopLevelRequests",
+ handle_top_level_requests_, 0, 1, 2);
IPC::SyncMessage* message =
new AutomationMsg_CreateExternalTab(settings, NULL, NULL, 0, 0);