diff options
author | ananta@chromium.org <ananta@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-10-27 21:50:07 +0000 |
---|---|---|
committer | ananta@chromium.org <ananta@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-10-27 21:50:07 +0000 |
commit | 885362ca4a5a6df6d2625e9db7807d07ab225804 (patch) | |
tree | f0af8b1a17a1afaa7f32ddf82a9ed0d0701d7a61 /chrome_frame/chrome_frame_automation.cc | |
parent | d45ab6164496793b199a22ed82c6aa5263674536 (diff) | |
download | chromium_src-885362ca4a5a6df6d2625e9db7807d07ab225804.zip chromium_src-885362ca4a5a6df6d2625e9db7807d07ab225804.tar.gz chromium_src-885362ca4a5a6df6d2625e9db7807d07ab225804.tar.bz2 |
If a HTTP post to a server returns any redirect code other than 307, then browsers don't preserve the
request method, i.e. they convert the POST request to GET. For 307 redirects browsers preserve redirects.
This CL fixes the following issues :-
1. As per the above description, we reset the method which
ensures that we don't generate the post related headers.
The Post302RedirectGet net test does test this very case.
However it works correctly as Chrome follows the redirect
and reissues the GET request. In this case this does not
occur as the only calls which are invoked on the bind
status callback after the redirect are GetBindInfo and
BeginningTransaction where we incorrectly return the post
related information. Ideally we would want to turn off
follow redirects in Urlmon or Chrome. I tried the latter
which has a number of issues.
2. In debug mode the chrome_frame_net_tests cause a DCHECK
to be fired which indicates that the test is not being
run on the UI thread.
3. As the Urlmon requests are now destroyed asynchronously
having a DCHECK after the Stop call on the Urlmon
request object in the CleanupAsyncRequests function is
incorrect. Removed this DCHECK
Fixes bug http://code.google.com/p/chromium/issues/detail?id=25643
Bug=25643
Review URL: http://codereview.chromium.org/333043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30261 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome_frame/chrome_frame_automation.cc')
-rw-r--r-- | chrome_frame/chrome_frame_automation.cc | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/chrome_frame/chrome_frame_automation.cc b/chrome_frame/chrome_frame_automation.cc index 4529ca3..e02173d 100644 --- a/chrome_frame/chrome_frame_automation.cc +++ b/chrome_frame/chrome_frame_automation.cc @@ -1060,7 +1060,6 @@ void ChromeFrameAutomationClient::CleanupAsyncRequests() { index++; } - DCHECK(request_map_.empty()); request_map_.clear(); } |