diff options
| author | jam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-12-23 22:15:34 +0000 |
|---|---|---|
| committer | jam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-12-23 22:15:34 +0000 |
| commit | f5494d49ab74e3d116540b14db3457558f54c88e (patch) | |
| tree | beb367c01c187652d02091a5067a69d5bc0fa064 /chrome_frame/chrome_frame_npapi.cc | |
| parent | a9f39a313b7ecc11d98727d869e15094481f3a65 (diff) | |
| download | chromium_src-f5494d49ab74e3d116540b14db3457558f54c88e.zip chromium_src-f5494d49ab74e3d116540b14db3457558f54c88e.tar.gz chromium_src-f5494d49ab74e3d116540b14db3457558f54c88e.tar.bz2 | |
Clean up Automation and Chrome Frame IPC code.-only use routed messages when needed-use routing IDs to avoid manually unpacking messages-remove data structures from IPC namespace (that should only be used for IPC code, and param traits)Note that I temporarily commented out part of a test in external_tab_test.cc because I couldn't figure out how to get the updated gmock macros to compile.
Review URL: http://codereview.chromium.org/5998006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70105 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome_frame/chrome_frame_npapi.cc')
| -rw-r--r-- | chrome_frame/chrome_frame_npapi.cc | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/chrome_frame/chrome_frame_npapi.cc b/chrome_frame/chrome_frame_npapi.cc index c36c1b7..a010fac 100644 --- a/chrome_frame/chrome_frame_npapi.cc +++ b/chrome_frame/chrome_frame_npapi.cc @@ -901,7 +901,7 @@ void ChromeFrameNPAPI::OnAutomationServerLaunchFailed( } } -void ChromeFrameNPAPI::OnCloseTab(int tab_handle) { +void ChromeFrameNPAPI::OnCloseTab() { std::string arg; FireEvent("close", arg); ScopedNpVariant result; @@ -1487,8 +1487,8 @@ bool ChromeFrameNPAPI::PreProcessContextMenu(HMENU menu) { return true; } -bool ChromeFrameNPAPI::HandleContextMenuCommand(UINT cmd, - const IPC::MiniContextMenuParams& params) { +bool ChromeFrameNPAPI::HandleContextMenuCommand( + UINT cmd, const MiniContextMenuParams& params) { if (cmd == IDC_ABOUT_CHROME_FRAME) { // TODO: implement "About Chrome Frame" } |