diff options
| author | ananta@chromium.org <ananta@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-09-30 21:38:50 +0000 |
|---|---|---|
| committer | ananta@chromium.org <ananta@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-09-30 21:38:50 +0000 |
| commit | 9eeb35e21e43c6a91fe45b03feb9cf1d42b88b65 (patch) | |
| tree | 06d0ad7b09dd3fa48a20565a622f8a5f0c6552da /chrome_frame/chrome_frame_npapi.h | |
| parent | f1cde5f421b507601fd23a7ec25962e5a1dbc3ba (diff) | |
| download | chromium_src-9eeb35e21e43c6a91fe45b03feb9cf1d42b88b65.zip chromium_src-9eeb35e21e43c6a91fe45b03feb9cf1d42b88b65.tar.gz chromium_src-9eeb35e21e43c6a91fe45b03feb9cf1d42b88b65.tar.bz2 | |
Top level navigations are not sent to the host browser in the ChromeFrame NPAPI implementation.
These include window.open requests, hrefs with target _blank, etc.
The ChromeFrame NPAPI plugin needs to set the renderer pref which indicates that the host browser
can handle top level requests.
We also pass an additional flag in the CreateExternal tab IPC which indicates whether the host
browser supports full tab mode browsing or not. This defaults to true for IE, as the activex
implementation relies on being able to launch a new window with the attach external tab prefix.
which assumes support for full tab mode for IE being available. If the host browser does not
support full tab browsing the window.open request which comes into the ExternalTabContainer
instance creates a dummy ExternalTabContainer instance which is destroyed when the top level
navigation info is sent back to the host browser.
This CL is a short term fix for the issues with the NPAPI ChromeFrame plugin. Will do some
investigation into a better approach.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=57319
Test=Covered by existing ChromeFrame widget mode tests WidgetModeIE_SrcProperty and
WidgetModeFF_SrcProperty
Fixed incorrect assumptions in the test files used by these tests.
Bug=57319
Review URL: http://codereview.chromium.org/3549006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61117 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome_frame/chrome_frame_npapi.h')
| -rw-r--r-- | chrome_frame/chrome_frame_npapi.h | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/chrome_frame/chrome_frame_npapi.h b/chrome_frame/chrome_frame_npapi.h index 8fd0c6f7..994b178 100644 --- a/chrome_frame/chrome_frame_npapi.h +++ b/chrome_frame/chrome_frame_npapi.h @@ -132,7 +132,8 @@ END_MSG_MAP() // instance. virtual void OnAcceleratorPressed(int tab_handle, const MSG& accel_message); virtual void OnTabbedOut(int tab_handle, bool reverse); - virtual void OnOpenURL(int tab_handle, const GURL& url, int open_disposition); + virtual void OnOpenURL(int tab_handle, const GURL& url, + const GURL& referrer, int open_disposition); virtual void OnLoad(int tab_handle, const GURL& url); virtual void OnMessageFromChromeFrame(int tab_handle, const std::string& message, |