summaryrefslogtreecommitdiffstats
path: root/chrome_frame/com_message_event.cc
diff options
context:
space:
mode:
authoryusukes@chromium.org <yusukes@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-12-09 04:56:19 +0000
committeryusukes@chromium.org <yusukes@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-12-09 04:56:19 +0000
commit18a6d9bbaa6d6e56b2d03e8f2736bb63f9d9b62d (patch)
tree74a02c5ef1485d0fc1c3345820e85eb5c834c627 /chrome_frame/com_message_event.cc
parent1e0c42403998b6294bb79e89667e15265c4694f7 (diff)
downloadchromium_src-18a6d9bbaa6d6e56b2d03e8f2736bb63f9d9b62d.zip
chromium_src-18a6d9bbaa6d6e56b2d03e8f2736bb63f9d9b62d.tar.gz
chromium_src-18a6d9bbaa6d6e56b2d03e8f2736bb63f9d9b62d.tar.bz2
Remove aura::RootWindow instance from LayerAnimator::observers_ and LayerAnimationSequence::observers_ when the window is deleted.
This would prevent Chrome from crashing (see the example stack trace below) when someone (e.g. ui/aura_shell/shell_accelerator_controller.cc) adds aura::RootWindow as an observer of a LayerAnimationSequence object, and the window is deleted before the animation finishes. pure virtual method called terminate called without an active exception [24029:24029:1206/172212:111412790729:ERROR:process_util_posix.cc(139)] Received signal 6         base::debug::StackTrace::StackTrace() [0x809fbf4]         base::(anonymous namespace)::StackDumpSignalHandler() [0x830b615] ...         ui::LayerAnimationSequence::NotifyAborted() [0x826fcce]         ui::LayerAnimationSequence::Abort() [0x826f95b]         ui::LayerAnimator::ClearAnimations() [0x8274f84]         ui::LayerAnimator::~LayerAnimator() [0x8273a74]         scoped_ptr<>::~scoped_ptr() [0x826c7e3]         ui::Layer::~Layer() [0x8269873]         scoped_ptr<>::~scoped_ptr() [0x81b7891]         aura::Window::~Window() [0x81b4745]         aura::RootWindow::~RootWindow() [0x81ae824]         aura::RootWindow::DeleteInstance() [0x81ace70] With the aura::RootWindow fix, we can reenable one test in shell_accelerator_controller_unittests.cc which checks the Control+Home accelerator. BUG=None TEST=ran aura_shell_unittests Review URL: http://codereview.chromium.org/8816008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113762 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome_frame/com_message_event.cc')
0 files changed, 0 insertions, 0 deletions