diff options
| author | amit@chromium.org <amit@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-12-13 23:26:37 +0000 |
|---|---|---|
| committer | amit@chromium.org <amit@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-12-13 23:26:37 +0000 |
| commit | f7942c4551c2dc8b116f9a58b824baf955728798 (patch) | |
| tree | 90eebb99dd6900518be6b07c720ca2b7c317e001 /chrome_frame/crash_reporting/veh_test.cc | |
| parent | 161888b0b684e032f82045cfa2ccced19390fc1e (diff) | |
| download | chromium_src-f7942c4551c2dc8b116f9a58b824baf955728798.zip chromium_src-f7942c4551c2dc8b116f9a58b824baf955728798.tar.gz chromium_src-f7942c4551c2dc8b116f9a58b824baf955728798.tar.bz2 | |
Improve filtering for false positive crashes
...by inspecting if the module with the crash has the topmost handler
in the SEH chain. If that's the case then the exception will very
likely be handled. This covers the case of IsBadReadPtr adn family
without any special code. It also lets us address IsValidInterface,
an internal helper in urlmon.
BUG=64348
TEST=covered by existing unit tests
Review URL: http://codereview.chromium.org/5622006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69066 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome_frame/crash_reporting/veh_test.cc')
| -rw-r--r-- | chrome_frame/crash_reporting/veh_test.cc | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/chrome_frame/crash_reporting/veh_test.cc b/chrome_frame/crash_reporting/veh_test.cc index bfdb788..ec868ef 100644 --- a/chrome_frame/crash_reporting/veh_test.cc +++ b/chrome_frame/crash_reporting/veh_test.cc @@ -53,7 +53,6 @@ class MockApi : public Win32VEHTraits, public ModuleOfInterestWithExcludedRegion { public: MockApi() { - Win32VEHTraits::InitializeIgnoredBlocks(); ModuleOfInterestWithExcludedRegion::SetModule(&ModuleStart, &ModuleEnd); ModuleOfInterestWithExcludedRegion::SetExcludedRegion(&Undetectable, &UndetectableEnd); |