diff options
| author | robertshield@chromium.org <robertshield@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-06-23 20:20:02 +0000 |
|---|---|---|
| committer | robertshield@chromium.org <robertshield@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-06-23 20:20:02 +0000 |
| commit | 15bb2f4987e01dbb765207d792edbfe48efe68d1 (patch) | |
| tree | a8a59a5f87025e4b113c3ec754312d99456a8f45 /chrome_frame/crash_server_init.h | |
| parent | 710a98ded8a324b8ef534cd2ef9ad6735b1ee21c (diff) | |
| download | chromium_src-15bb2f4987e01dbb765207d792edbfe48efe68d1.zip chromium_src-15bb2f4987e01dbb765207d792edbfe48efe68d1.tar.gz chromium_src-15bb2f4987e01dbb765207d792edbfe48efe68d1.tar.bz2 | |
Fix up crash reporting in unit tests and the Chrome Frame helper processes:
Bother to initialize crash reporting in chrome_frame_tests.exe.
Correctly construct the crash reporting pipe name for non-admin installs.
BUG=86846
TEST=Crash dumps are reported when running Chrome Frame tests in headless mode, user-level Chrome Frame helper processes connect to the crash service.
Review URL: http://codereview.chromium.org/7219007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90255 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome_frame/crash_server_init.h')
| -rw-r--r-- | chrome_frame/crash_server_init.h | 13 |
1 files changed, 7 insertions, 6 deletions
diff --git a/chrome_frame/crash_server_init.h b/chrome_frame/crash_server_init.h index bf7ff95..0c46f43 100644 --- a/chrome_frame/crash_server_init.h +++ b/chrome_frame/crash_server_init.h @@ -1,4 +1,4 @@ -// Copyright (c) 2010 The Chromium Authors. All rights reserved. +// Copyright (c) 2011 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. @@ -15,12 +15,13 @@ extern const wchar_t kChromePipeName[]; extern const wchar_t kGoogleUpdatePipeName[]; extern const wchar_t kSystemPrincipalSid[]; -// Assume this implies headless mode and use kChromePipeName if it shows -// up in the command line. -extern const wchar_t kFullMemoryCrashReport[]; - extern const MINIDUMP_TYPE kLargerDumpType; +enum CrashReportingMode { + HEADLESS, // Used for testing, uses crash_service.exe for dumps. + NORMAL // Regular mode, uses GoogleCrashService.exe for dumps. +}; + // Returns a pointer to a static instance of a CustomClientInfo structure // containing Chrome Frame specific data. google_breakpad::CustomClientInfo* GetCustomInfo(); @@ -29,6 +30,6 @@ google_breakpad::CustomClientInfo* GetCustomInfo(); // constructed ExceptionHandler object. It is the responsibility of the caller // to delete this object which will shut down the crash reporting machinery. google_breakpad::ExceptionHandler* InitializeCrashReporting( - const wchar_t* cmd_line); + CrashReportingMode mode); #endif // CHROME_FRAME_CRASH_SERVER_INIT_H_ |