diff options
| author | ananta@chromium.org <ananta@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-10-26 04:37:20 +0000 |
|---|---|---|
| committer | ananta@chromium.org <ananta@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-10-26 04:37:20 +0000 |
| commit | 22a91288c8d235afb45932dd7633982a04c389f0 (patch) | |
| tree | 431cd53b7ba02ad1d17bf370a7131fc4c308623d /chrome_frame/metrics_service.h | |
| parent | 58580359a452cb7c3b9580edc0843c3ab3d158df (diff) | |
| download | chromium_src-22a91288c8d235afb45932dd7633982a04c389f0.zip chromium_src-22a91288c8d235afb45932dd7633982a04c389f0.tar.gz chromium_src-22a91288c8d235afb45932dd7633982a04c389f0.tar.bz2 | |
ChromeFrame network tests were broken since the change to honor the automation protocol
version in ChromeFrame which basically breaks the automation connection if the protocols
don't match. While this is fine when chrome is the automation client, it breaks chrome
frame net tests because when the automation channel is established the automation provider
sends over the version of the current module in the hello message.
In the case when the current module is chrome the version goes over correctly. For chrome frame
net tests there is no version string. Hence the channel never gets established.
Fix is to retrieve the protocol version via a virtual protected function in the automation
provider. The testing automation provider overrides this function in the network tests
and returns the version of chrome.dll
TBR=amit,robertshield
Review URL: http://codereview.chromium.org/4160002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63860 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome_frame/metrics_service.h')
0 files changed, 0 insertions, 0 deletions