diff options
| author | dpranke@chromium.org <dpranke@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-09-22 19:44:41 +0000 |
|---|---|---|
| committer | dpranke@chromium.org <dpranke@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-09-22 19:44:41 +0000 |
| commit | 6568e6bb74a14bb6be71c1963c223ebe51eb4b4d (patch) | |
| tree | 3855fdcd8a01d31682d566a9317b95a67b4fee3a /chrome_frame/renderer_glue.cc | |
| parent | 9d43e371e6c0b70b938575690f561f3742ad8397 (diff) | |
| download | chromium_src-6568e6bb74a14bb6be71c1963c223ebe51eb4b4d.zip chromium_src-6568e6bb74a14bb6be71c1963c223ebe51eb4b4d.tar.gz chromium_src-6568e6bb74a14bb6be71c1963c223ebe51eb4b4d.tar.bz2 | |
Remove webkit_glue::BuildUserAgent(), change the contract in webkit_glue so that SetUserAgent() must be called before GetUserAgent().
This was causing a dependency inversion between webkit_support and its clients, and was needed for the content component build.
For content users, calling SetContentClient() will automatically initialize the user agent (retrieved from client->GetUserAgent()).
As a bonus, fixing this allowed me to re-test the "mimic_windows" code path and it looks like we no longer need it.
R=jam@chromium.org,tony@chromium.org
BUG=11136,90442
TEST=visit yahoo! mail using Chromium on Linux, ensure that we don't get an "unsupported browser" warning.
Review URL: http://codereview.chromium.org/7922023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102336 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome_frame/renderer_glue.cc')
| -rw-r--r-- | chrome_frame/renderer_glue.cc | 14 |
1 files changed, 1 insertions, 13 deletions
diff --git a/chrome_frame/renderer_glue.cc b/chrome_frame/renderer_glue.cc index d904506..96ccdc1 100644 --- a/chrome_frame/renderer_glue.cc +++ b/chrome_frame/renderer_glue.cc @@ -1,4 +1,4 @@ -// Copyright (c) 2010 The Chromium Authors. All rights reserved. +// Copyright (c) 2011 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. @@ -12,15 +12,3 @@ class GURL; bool IsPluginProcess() { return false; } - -namespace webkit_glue { - -std::string BuildUserAgent(bool mimic_windows) { - chrome::VersionInfo version_info; - std::string product("Chrome/"); - product += version_info.is_valid() ? version_info.Version() - : "0.0.0.0"; - return webkit_glue::BuildUserAgentHelper(mimic_windows, product); -} - -} // end namespace webkit_glue |