Some Chrome Frame cleanup:

1) Rearrange the chrome_frame.gyp file to:
  a) Split out most of CF into a static lib to make writing unit tests easier (not having to re-include source files).
  b) Remove most of the un-needed xulrunner-sdk includes.

2) Move all OBJECT_ENTRY_AUTO macros to chrome_tab.cc since they don't work without extra work when residing in a lib.

3) Rename npchrome_tab.dll to npchrome_frame.dll.

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/523040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35543 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 7 insertions, 6 deletions

diff --git a/chrome_frame/test/chrome_frame_unittests.cc b/chrome_frame/test/chrome_frame_unittests.cc
index 10c3edb..b68dfe8 100644
--- a/chrome_frame/test/chrome_frame_unittests.cc
+++ b/chrome_frame/test/chrome_frame_unittests.cc
@@ -195,7 +195,8 @@ void ChromeFrameTestWithWebServer::VersionTest(BrowserKind browser,
     const wchar_t* page, const wchar_t* result_file_to_check) {
   std::wstring plugin_path;
   PathService::Get(base::DIR_MODULE, &plugin_path);
-  file_util::AppendToPath(&plugin_path, L"servers/npchrome_tab.dll");
+  file_util::AppendToPath(&plugin_path, L"servers");
+  file_util::AppendToPath(&plugin_path, kChromeFrameDllName);
 
   static FileVersionInfo* version_info =
       FileVersionInfo::CreateFileVersionInfo(plugin_path);
@@ -204,7 +205,7 @@ void ChromeFrameTestWithWebServer::VersionTest(BrowserKind browser,
   if (version_info)
     version = version_info->product_version();
 
-  // If we can't find the npchrome_tab.dll in the src tree, we turn to
+  // If we can't find the Chrome Frame DLL in the src tree, we turn to
   // the directory where chrome is installed.
   if (!version_info) {
     installer::Version* ver_system = InstallUtil::GetChromeVersion(true);
@@ -212,11 +213,11 @@ void ChromeFrameTestWithWebServer::VersionTest(BrowserKind browser,
     ASSERT_TRUE(ver_system || ver_user);
 
     bool system_install = ver_system ? true : false;
-    std::wstring npchrome_path(installer::GetChromeInstallPath(system_install));
-    file_util::AppendToPath(&npchrome_path,
+    std::wstring cf_dll_path(installer::GetChromeInstallPath(system_install));
+    file_util::AppendToPath(&cf_dll_path,
         ver_system ? ver_system->GetString() : ver_user->GetString());
-    file_util::AppendToPath(&npchrome_path, L"npchrome_tab.dll");
-    version_info = FileVersionInfo::CreateFileVersionInfo(npchrome_path);
+    file_util::AppendToPath(&cf_dll_path, kChromeFrameDllName);
+    version_info = FileVersionInfo::CreateFileVersionInfo(cf_dll_path);
     if (version_info)
       version = version_info->product_version();
   }