diff options
author | mbelshe@chromium.org <mbelshe@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-05-27 15:38:07 +0000 |
---|---|---|
committer | mbelshe@chromium.org <mbelshe@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-05-27 15:38:07 +0000 |
commit | f55bd486ab0ada0402fdcd34fb70a20d155fd968 (patch) | |
tree | 1eb9cf7c078d40c20320126d34f4cc4694082b1f /chrome_frame/test/exception_barrier_unittest.cc | |
parent | 4b0bd5f4c2d58c1620b49628be68f877928025fd (diff) | |
download | chromium_src-f55bd486ab0ada0402fdcd34fb70a20d155fd968.zip chromium_src-f55bd486ab0ada0402fdcd34fb70a20d155fd968.tar.gz chromium_src-f55bd486ab0ada0402fdcd34fb70a20d155fd968.tar.bz2 |
Enable warning 4389 as an error on windows builds. This will make
windows builds more similar to linux/mac, which already treat signed/
unsigned equality comparisons as warnings (and hence errors).
BUG=44471
TEST=none
Review URL: http://codereview.chromium.org/2222002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48395 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome_frame/test/exception_barrier_unittest.cc')
-rw-r--r-- | chrome_frame/test/exception_barrier_unittest.cc | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/chrome_frame/test/exception_barrier_unittest.cc b/chrome_frame/test/exception_barrier_unittest.cc index eeffd2a..73f006a 100644 --- a/chrome_frame/test/exception_barrier_unittest.cc +++ b/chrome_frame/test/exception_barrier_unittest.cc @@ -29,7 +29,7 @@ void TestSEHChainSane() { MEMORY_BASIC_INFORMATION info = { 0 }; // Note that we pass the address of the info struct just as a handy // moniker to anything at all inside our stack allocation - ASSERT_NE(0, ::VirtualQuery(&info, &info, sizeof(info))); + ASSERT_NE(0u, ::VirtualQuery(&info, &info, sizeof(info))); // The lower bound of our stack. // We use the address of info as a lower bound, this assumes that if this @@ -60,9 +60,9 @@ void TestSEHChainSane() { ASSERT_EQ(0, (reinterpret_cast<UINT_PTR>(prev) & 0x00000003)); // find the module hosting the handler - ASSERT_NE(0, ::VirtualQuery(curr->handler, &info, sizeof(info))); + ASSERT_NE(0u, ::VirtualQuery(curr->handler, &info, sizeof(info))); wchar_t module_filename[MAX_PATH]; - ASSERT_NE(0, ::GetModuleFileName( + ASSERT_NE(0u, ::GetModuleFileName( reinterpret_cast<HMODULE>(info.AllocationBase), module_filename, ARRAYSIZE(module_filename))); } |