diff options
| author | ananta@chromium.org <ananta@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-02-26 00:08:41 +0000 |
|---|---|---|
| committer | ananta@chromium.org <ananta@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-02-26 00:08:41 +0000 |
| commit | d77ca3edc4b240592b94d3287047386b3ab5470c (patch) | |
| tree | 430ea8ddb302741b992c3382215add8b80899ab8 /chrome_frame/test | |
| parent | e59a1c4503496f843391641dbb947043dec2a466 (diff) | |
| download | chromium_src-d77ca3edc4b240592b94d3287047386b3ab5470c.zip chromium_src-d77ca3edc4b240592b94d3287047386b3ab5470c.tar.gz chromium_src-d77ca3edc4b240592b94d3287047386b3ab5470c.tar.bz2 | |
Fix the ui test crashes on Linux. There is a race condition between the channel getting destroyed
and it being referenced in the background thread.
Fix is to use the underlying IPC::Channel pointer passed to the message filter when the
filter gets Added to send and receive messages. This ensures that the SyncChannel is not used across
threads.
Review URL: http://codereview.chromium.org/661109
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40076 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome_frame/test')
| -rw-r--r-- | chrome_frame/test/automation_client_mock.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/chrome_frame/test/automation_client_mock.h b/chrome_frame/test/automation_client_mock.h index aa17937..da51759 100644 --- a/chrome_frame/test/automation_client_mock.h +++ b/chrome_frame/test/automation_client_mock.h @@ -164,7 +164,7 @@ class CFACMockTest : public testing::Test { virtual void SetUp() { dummy_sender_.ForwardTo(&proxy_); - tracker_.reset(new AutomationHandleTracker(&dummy_sender_)); + tracker_.reset(new AutomationHandleTracker()); client_ = new ChromeFrameAutomationClient; client_->set_proxy_factory(&factory_); |