diff options
| author | tommi@chromium.org <tommi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-08-10 14:09:37 +0000 |
|---|---|---|
| committer | tommi@chromium.org <tommi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-08-10 14:09:37 +0000 |
| commit | bbfa9a15797ba107dcae0f7fff85a7f12ffd26b9 (patch) | |
| tree | ee15898939e4989b96c6419217696f63d7a5585b /chrome_frame/test_utils.cc | |
| parent | e721ebe885b159f9b18047392be9a0f5834998fb (diff) | |
| download | chromium_src-bbfa9a15797ba107dcae0f7fff85a7f12ffd26b9.zip chromium_src-bbfa9a15797ba107dcae0f7fff85a7f12ffd26b9.tar.gz chromium_src-bbfa9a15797ba107dcae0f7fff85a7f12ffd26b9.tar.bz2 | |
Handle automation server crashes. When Chrome crashes, we now handle the case and support document refresh or reload.
When chrome crashes, we draw a poor man's sad tab (":-("), so that can clearly be improved.
Another thing is that if the chrome instance that crashed held several navigational entries, then that history is lost.
TEST=There are a couple of tests included, so run those (*TabCrash*) and also verify that when the chrome automation server is killed that we do the right thing. Also check info in bug report.
BUG=25839
Review URL: http://codereview.chromium.org/3061036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55565 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome_frame/test_utils.cc')
| -rw-r--r-- | chrome_frame/test_utils.cc | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/chrome_frame/test_utils.cc b/chrome_frame/test_utils.cc index 95c35af..fb46998 100644 --- a/chrome_frame/test_utils.cc +++ b/chrome_frame/test_utils.cc @@ -297,7 +297,6 @@ bool KillAllNamedProcessesWithArgument(const std::wstring& process_name, base::NamedProcessIterator iter(process_name, &filter); while (const base::ProcessEntry* entry = iter.NextProcessEntry()) { if (!base::KillProcessById(entry->pid(), 0, true)) { - DLOG(ERROR) << "Failed to kill process " << (*entry).th32ProcessID; result = false; } } |