diff options
author | amit@chromium.org <amit@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-05-05 23:46:30 +0000 |
---|---|---|
committer | amit@chromium.org <amit@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-05-05 23:46:30 +0000 |
commit | 040b800f9a064e093255e1e5e2718b1cd51275a3 (patch) | |
tree | e45d8b11ebaf139529e521503fc3a08313d8f3cd /chrome_frame/urlmon_bind_status_callback.h | |
parent | ec140301a87ecf1ba9e70e8031ee521c002b0f32 (diff) | |
download | chromium_src-040b800f9a064e093255e1e5e2718b1cd51275a3.zip chromium_src-040b800f9a064e093255e1e5e2718b1cd51275a3.tar.gz chromium_src-040b800f9a064e093255e1e5e2718b1cd51275a3.tar.bz2 |
Do not wrap the original callback if we can;t initialize sniffing cache
CreateStreamOnHGlobal may fail if the underlying GlobalAlloc fails. It has
a strange behavaior where if we pass in an HGlobal, it can create more
streams per process. So the fix is to:
1. not register us as a bind status callback if we cannot create a stream
for sniffing data and
2. When initializing the data sniffing stream pre-create a HGlobal
BUG=To be filed
TEST=none
Review URL: http://codereview.chromium.org/1983002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46525 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome_frame/urlmon_bind_status_callback.h')
-rw-r--r-- | chrome_frame/urlmon_bind_status_callback.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/chrome_frame/urlmon_bind_status_callback.h b/chrome_frame/urlmon_bind_status_callback.h index 0ecf51f..8b6fd3b 100644 --- a/chrome_frame/urlmon_bind_status_callback.h +++ b/chrome_frame/urlmon_bind_status_callback.h @@ -52,7 +52,7 @@ class SniffData { OTHER }; - bool InitializeCache(const std::wstring& url); + HRESULT InitializeCache(const std::wstring& url); HRESULT ReadIntoCache(IStream* stream, bool force_determination); HRESULT DrainCache(IBindStatusCallback* bscb, DWORD bscf, CLIPFORMAT clip_format); |