diff options
| author | ananta@chromium.org <ananta@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-10-31 19:52:14 +0000 |
|---|---|---|
| committer | ananta@chromium.org <ananta@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-10-31 19:52:14 +0000 |
| commit | 51a2dc019c192b650eaf069a6d1c568b9655730d (patch) | |
| tree | 2c076da1d0a4b0dfe0f232b274f1afc3f2fc330d /chrome_frame/urlmon_url_request.cc | |
| parent | 484262fd875f44de8171a95a8537a519672ade25 (diff) | |
| download | chromium_src-51a2dc019c192b650eaf069a6d1c568b9655730d.zip chromium_src-51a2dc019c192b650eaf069a6d1c568b9655730d.tar.gz chromium_src-51a2dc019c192b650eaf069a6d1c568b9655730d.tar.bz2 | |
Fix a ChromeFrame crash which occurs in the background worker thread while dereferencing a NULL automation client.
This crash occurs when the active document is in the process of shutting down while there are active background
requests still pending.
Fix is to ensure that the background thread has been stopped before returning from the UrlmonUrlRequestManager::StopAll
function which gets called during CF shutdown.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=102393
BUG=102393
Review URL: http://codereview.chromium.org/8429011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107995 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome_frame/urlmon_url_request.cc')
| -rw-r--r-- | chrome_frame/urlmon_url_request.cc | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/chrome_frame/urlmon_url_request.cc b/chrome_frame/urlmon_url_request.cc index 9bade03..9c2b130 100644 --- a/chrome_frame/urlmon_url_request.cc +++ b/chrome_frame/urlmon_url_request.cc @@ -1261,6 +1261,8 @@ void UrlmonUrlRequestManager::StopAll() { NewRunnableMethod( this, &UrlmonUrlRequestManager::StopAllRequestsHelper, &background_request_map_, &background_resource_map_lock_)); + // background_thread_->Stop(); + // background_thread_.reset(); } } |