The cache object used by the UrlmonUrlRequest class in ChromeFrame creates an in memory stream, which is used

to hold data received from Urlmon until Chrome reads it. At times attempts to write to this stream fail
with E_OUTOFMEMORY. 

We don't really need the complexity of an in memory stream for our cache. A vector of bytes would do just fine.

This fixes bug http://code.google.com/p/chromium/issues/detail?id=28658

I verified that it actually fixes this issue.

Bug=28648
Test=covered by existing net tests.

Review URL: http://codereview.chromium.org/469014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34086 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 6 insertions, 8 deletions

diff --git a/chrome_frame/urlmon_url_request.h b/chrome_frame/urlmon_url_request.h
index fc98e8f..d4abee5 100644
--- a/chrome_frame/urlmon_url_request.h
+++ b/chrome_frame/urlmon_url_request.h
@@ -215,24 +215,22 @@ END_MSG_MAP()
   // size less than 2GB
   class Cache {
    public:
-    bool Create();
-
     // Adds data to the end of the cache.
     bool Append(IStream* source, size_t* bytes_copied);
 
     // Reads from the cache.
     bool Read(IStream* dest, size_t size, size_t* bytes_copied);
 
-    size_t Size();
-    size_t CurrentPos();
-    size_t SizeRemaining();
-    void Clear();
+    // Returns the size of the cache.
+    size_t Size() const;
+
+    // Returns true if the cache has valid data.
     bool is_valid() const {
-      return (stream_ != NULL);
+      return Size() != 0;
     }
 
    protected:
-    ScopedComPtr<IStream> stream_;
+    std::vector<byte> cache_;
     char read_buffer_[kCopyChunkSize];
   };