diff options
author | ananta@chromium.org <ananta@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-03-04 06:43:35 +0000 |
---|---|---|
committer | ananta@chromium.org <ananta@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-03-04 06:43:35 +0000 |
commit | 4736610c8c5210c61efbf985b7e56843c7cfa219 (patch) | |
tree | 0842657b27f9055b6653708e9025ee6ff076f2ea /chrome_frame/utils.h | |
parent | b9e8ea61b8b7b897292bfc69814444dd9e938477 (diff) | |
download | chromium_src-4736610c8c5210c61efbf985b7e56843c7cfa219.zip chromium_src-4736610c8c5210c61efbf985b7e56843c7cfa219.tar.gz chromium_src-4736610c8c5210c61efbf985b7e56843c7cfa219.tar.bz2 |
Revert 76880 - ChromeFrame would fail to upload POST data to the server if the webserver requested NTLM
authentication. This is due to a bug in urlmon on IE6 and IE7 which manifests itself when
the post data is passed to urlmon as an IStream.
Fix is to pass in the uploaded data as a HGLOBAL. We always pass in a copy of the HGLOBAL
which points to the posted data to urlmon. This is to have it accessible for reissuing
navigation requests which target downloads.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=62687
BUG=62687
TEST=manually at this point. As we need a server which supports NTLM authentication like IIS.
Review URL: http://codereview.chromium.org/6603006
TBR=ananta@chromium.org
Review URL: http://codereview.chromium.org/6626008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76886 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome_frame/utils.h')
-rw-r--r-- | chrome_frame/utils.h | 13 |
1 files changed, 4 insertions, 9 deletions
diff --git a/chrome_frame/utils.h b/chrome_frame/utils.h index ca5cb87..c2d6ef9 100644 --- a/chrome_frame/utils.h +++ b/chrome_frame/utils.h @@ -301,13 +301,9 @@ HRESULT DoQueryService(const IID& service_id, IUnknown* unk, T** service) { // Navigates an IWebBrowser2 object to a moniker. // |headers| can be NULL. -HRESULT NavigateBrowserToMoniker(IUnknown* browser, - IMoniker* moniker, - const wchar_t* headers, - IBindCtx* bind_ctx, - const wchar_t* fragment, - const uint8* post_data, - int post_data_len); +HRESULT NavigateBrowserToMoniker(IUnknown* browser, IMoniker* moniker, + const wchar_t* headers, IBindCtx* bind_ctx, + const wchar_t* fragment, IStream* post_data); // Raises a flag on the current thread (using TLS) to indicate that an // in-progress navigation should be rendered in chrome frame. @@ -467,8 +463,7 @@ extern base::Lock g_ChromeFrameHistogramLock; struct DownloadInHostParams { IBindCtx* bind_ctx; IMoniker* moniker; - uint8* post_data; - int post_data_len; + IStream* post_data; std::string request_headers; }; |