diff options
author | darin@chromium.org <darin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-09-30 04:29:20 +0000 |
---|---|---|
committer | darin@chromium.org <darin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-09-30 04:29:20 +0000 |
commit | 39fe32a42c9eab376aeefd1ae845085d8828c3ec (patch) | |
tree | a183411c44c9c958fd2f4ce05138c316158b94a1 /chrome_frame | |
parent | 5924fb63dc581087092336c3449e80a24d848492 (diff) | |
download | chromium_src-39fe32a42c9eab376aeefd1ae845085d8828c3ec.zip chromium_src-39fe32a42c9eab376aeefd1ae845085d8828c3ec.tar.gz chromium_src-39fe32a42c9eab376aeefd1ae845085d8828c3ec.tar.bz2 |
Reverting 27389.
Review URL: http://codereview.chromium.org/246027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27594 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome_frame')
-rw-r--r-- | chrome_frame/chrome_frame_automation.cc | 4 | ||||
-rw-r--r-- | chrome_frame/chrome_frame_delegate.h | 7 | ||||
-rw-r--r-- | chrome_frame/test/chrome_frame_unittests.cc | 24 |
3 files changed, 16 insertions, 19 deletions
diff --git a/chrome_frame/chrome_frame_automation.cc b/chrome_frame/chrome_frame_automation.cc index 79c0c38..1f369b5 100644 --- a/chrome_frame/chrome_frame_automation.cc +++ b/chrome_frame/chrome_frame_automation.cc @@ -144,8 +144,8 @@ ProxyFactory::ProxyCacheEntry::ProxyCacheEntry(const std::wstring& profile) } template <> struct RunnableMethodTraits<ProxyFactory> { - static void RetainCallee(ProxyFactory* obj) {} - static void ReleaseCallee(ProxyFactory* obj) {} + void RetainCallee(ProxyFactory* obj) {} + void ReleaseCallee(ProxyFactory* obj) {} }; ProxyFactory::ProxyFactory() diff --git a/chrome_frame/chrome_frame_delegate.h b/chrome_frame/chrome_frame_delegate.h index a3302da..ebde626 100644 --- a/chrome_frame/chrome_frame_delegate.h +++ b/chrome_frame/chrome_frame_delegate.h @@ -37,11 +37,8 @@ class ChromeFrameDelegate { // Template specialization template <> struct RunnableMethodTraits<ChromeFrameDelegate> { - static void RetainCallee(ChromeFrameDelegate* obj) { - } - - static void ReleaseCallee(ChromeFrameDelegate* obj) { - } + void RetainCallee(ChromeFrameDelegate* obj) {} + void ReleaseCallee(ChromeFrameDelegate* obj) {} }; extern UINT kAutomationServerReady; diff --git a/chrome_frame/test/chrome_frame_unittests.cc b/chrome_frame/test/chrome_frame_unittests.cc index 20826b1..d24f5b3 100644 --- a/chrome_frame/test/chrome_frame_unittests.cc +++ b/chrome_frame/test/chrome_frame_unittests.cc @@ -34,7 +34,7 @@ const wchar_t kDocRoot[] = L"chrome_frame\\test\\data"; const int kLongWaitTimeout = 60 * 1000; const int kShortWaitTimeout = 25 * 1000; -_ATL_FUNC_INFO WebBrowserEventSink::kNavigateErrorInfo = {
+_ATL_FUNC_INFO WebBrowserEventSink::kNavigateErrorInfo = { CC_STDCALL, VT_EMPTY, 5, { VT_DISPATCH, VT_VARIANT | VT_BYREF, @@ -51,7 +51,7 @@ _ATL_FUNC_INFO WebBrowserEventSink::kNavigateComplete2Info = { } }; -_ATL_FUNC_INFO WebBrowserEventSink::kBeforeNavigate2Info = {
+_ATL_FUNC_INFO WebBrowserEventSink::kBeforeNavigate2Info = { CC_STDCALL, VT_EMPTY, 7, { VT_DISPATCH, VT_VARIANT | VT_BYREF, @@ -797,7 +797,7 @@ class ChromeFrameTestEnvironment: public testing::Environment { public: ~ChromeFrameTestEnvironment() { } - + void SetUp() { ScopedChromeFrameRegistrar::RegisterDefaults(); } @@ -806,7 +806,7 @@ class ChromeFrameTestEnvironment: public testing::Environment { } }; -::testing::Environment* const chrome_frame_env =
+::testing::Environment* const chrome_frame_env = ::testing::AddGlobalTestEnvironment(new ChromeFrameTestEnvironment); // TODO(stoyan): - Move everything below in separate file(s). @@ -988,18 +988,18 @@ struct MockAutomationMessageSender : public AutomationMessageSender { }; template <> struct RunnableMethodTraits<ProxyFactory::LaunchDelegate> { - static void RetainCallee(ProxyFactory::LaunchDelegate* obj) {} - static void ReleaseCallee(ProxyFactory::LaunchDelegate* obj) {} + void RetainCallee(ProxyFactory::LaunchDelegate* obj) {} + void ReleaseCallee(ProxyFactory::LaunchDelegate* obj) {} }; template <> struct RunnableMethodTraits<MockProxyFactory> { - static void RetainCallee(MockProxyFactory* obj) {} - static void ReleaseCallee(MockProxyFactory* obj) {} + void RetainCallee(MockProxyFactory* obj) {} + void ReleaseCallee(MockProxyFactory* obj) {} }; template <> struct RunnableMethodTraits<ChromeFrameAutomationClient> { - static void RetainCallee(ChromeFrameAutomationClient* obj) {} - static void ReleaseCallee(ChromeFrameAutomationClient* obj) {} + void RetainCallee(ChromeFrameAutomationClient* obj) {} + void ReleaseCallee(ChromeFrameAutomationClient* obj) {} }; // MessageLoopForUI wrapper that runs only for a limited time. @@ -1019,8 +1019,8 @@ struct TimedMsgLoop { }; template <> struct RunnableMethodTraits<TimedMsgLoop> { - static void RetainCallee(TimedMsgLoop* obj) {} - static void ReleaseCallee(TimedMsgLoop* obj) {} + void RetainCallee(TimedMsgLoop* obj) {} + void ReleaseCallee(TimedMsgLoop* obj) {} }; // Saves typing. It's somewhat hard to create a wrapper around |