diff options
| author | estade@chromium.org <estade@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-11-18 19:18:49 +0000 |
|---|---|---|
| committer | estade@chromium.org <estade@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-11-18 19:18:49 +0000 |
| commit | 26d6e92975118c66047e7a3df83d6acf6c9b9db3 (patch) | |
| tree | f7b9f5ea6ef8d0a5fff9819acf0f8e5a7ea067a2 /chrome_frame | |
| parent | 0b2ad450ab0496c55a7825573ce93f5ff401fe5b (diff) | |
| download | chromium_src-26d6e92975118c66047e7a3df83d6acf6c9b9db3.zip chromium_src-26d6e92975118c66047e7a3df83d6acf6c9b9db3.tar.gz chromium_src-26d6e92975118c66047e7a3df83d6acf6c9b9db3.tar.bz2 | |
GTK: fix link button double free.
If set_normal_color was called while native_markup == normal_markup, then the string could be double freed. To fix this problem and prevent similar future mistakes, I made native_markup stdup normal_markup instead of just copying the pointer (the optimization wasn't worth the trickiness). Also, I cleaned up destruction logic.
BUG=27855
TEST=tried every flavor of chrome link button:
- classic theme
- non classic theme
- gtk theme
- gtk theme system theme that has non-default link text color property
Review URL: http://codereview.chromium.org/400009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32358 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome_frame')
0 files changed, 0 insertions, 0 deletions